From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7FE6C433E0 for ; Wed, 3 Jun 2020 11:15:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8AC5E20678 for ; Wed, 3 Jun 2020 11:15:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Fq4ebGsx"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="dHtLL2bj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8AC5E20678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GBAgNlzMwiRA/dy6NE7/qbA2P5p5hU5isTgpVeMUORY=; b=Fq4ebGsxwOTmZnRltWlBo+Wlb ORZ/gi/MPV88FEaZy0dFABZExPUt/nRF7K91bXi22PNZaD7tr66k8eDzBpgZ2rxit6xoaAt92ra9o 9TflyvsgCHZPjMk1tqSn2P5a7shF4YB5JRc3dNqzCW0WtoTJDwdVjU83g7EbKxVRmvUBFwJUGOJMr R6wYTJdZTDLfCttRBJandsMZKy232odVNdFK6auetsoYHEPznUQyUkoDoOEhPsAAIhLi8m/+1Rbku aqzXk3fuhnRMo+zwjyRVIHyuU1ABfm9P16DB8h0R5MgOlk//nLTPrVQxxMImvf1SxNCMhrreWhgBf e6+vAy6BA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgRMT-0001v8-Mh; Wed, 03 Jun 2020 11:15:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgRMP-0001H8-W0 for linux-arm-kernel@lists.infradead.org; Wed, 03 Jun 2020 11:15:07 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 885C02067B; Wed, 3 Jun 2020 11:15:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591182905; bh=DIzdZtES3weee8kFjADfjxp0jxzg8+EHuNSTFll5o64=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dHtLL2bjjmWlybWqZVA7JugSObOSlVQlMOrxeXn8QK/b8Ox/RqzeafeE5m5ch1Izs Tz1D7UKIVGzJUyx6siommZjcz7WJlmZrcScBIPFjDjjWJANJMLTnAV9K+k1W5XgjN2 DRGRpfciWQDzfqPiZ5dCG1Z2jQ8NYtIkuq4PJjPo= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jgRMO-00HQQ8-22; Wed, 03 Jun 2020 12:15:04 +0100 MIME-Version: 1.0 Date: Wed, 03 Jun 2020 12:15:04 +0100 From: Marc Zyngier To: Kunihiko Hayashi Subject: Re: [PATCH v3 1/6] PCI: dwc: Add msi_host_isr() callback In-Reply-To: <1591174481-13975-2-git-send-email-hayashi.kunihiko@socionext.com> References: <1591174481-13975-1-git-send-email-hayashi.kunihiko@socionext.com> <1591174481-13975-2-git-send-email-hayashi.kunihiko@socionext.com> User-Agent: Roundcube Webmail/1.4.4 Message-ID: <95bb3ffbfab4923854e20266c6b0b098@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: hayashi.kunihiko@socionext.com, bhelgaas@google.com, lorenzo.pieralisi@arm.com, jingoohan1@gmail.com, gustavo.pimentel@synopsys.com, robh+dt@kernel.org, yamada.masahiro@socionext.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, masami.hiramatsu@linaro.org, jaswinder.singh@linaro.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200603_041506_078858_666CFDDF X-CRM114-Status: GOOD ( 16.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Lorenzo Pieralisi , Masami Hiramatsu , Jassi Brar , Jingoo Han , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Masahiro Yamada , Rob Herring , Gustavo Pimentel , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-06-03 09:54, Kunihiko Hayashi wrote: > This adds msi_host_isr() callback function support to describe > SoC-dependent service triggered by MSI. > > For example, when AER interrupt is triggered by MSI, the callback > function > reads SoC-dependent registers and detects that the interrupt is from > AER, > and invoke AER interrupts related to MSI. > > Cc: Marc Zyngier > Cc: Jingoo Han > Cc: Gustavo Pimentel > Signed-off-by: Kunihiko Hayashi > --- > drivers/pci/controller/dwc/pcie-designware-host.c | 8 ++++---- > drivers/pci/controller/dwc/pcie-designware.h | 1 + > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c > b/drivers/pci/controller/dwc/pcie-designware-host.c > index 0a4a5aa..9b628a2 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-host.c > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c > @@ -112,13 +112,13 @@ irqreturn_t dw_handle_msi_irq(struct pcie_port > *pp) > static void dw_chained_msi_isr(struct irq_desc *desc) > { > struct irq_chip *chip = irq_desc_get_chip(desc); > - struct pcie_port *pp; > + struct pcie_port *pp = irq_desc_get_handler_data(desc); > > - chained_irq_enter(chip, desc); > + if (pp->ops->msi_host_isr) > + pp->ops->msi_host_isr(pp); Why is this call outside of the enter/exit guards? Do you still need to execute the standard handler? > > - pp = irq_desc_get_handler_data(desc); > + chained_irq_enter(chip, desc); > dw_handle_msi_irq(pp); > - > chained_irq_exit(chip, desc); > } > > diff --git a/drivers/pci/controller/dwc/pcie-designware.h > b/drivers/pci/controller/dwc/pcie-designware.h > index 656e00f..e741967 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.h > +++ b/drivers/pci/controller/dwc/pcie-designware.h > @@ -170,6 +170,7 @@ struct dw_pcie_host_ops { > void (*scan_bus)(struct pcie_port *pp); > void (*set_num_vectors)(struct pcie_port *pp); > int (*msi_host_init)(struct pcie_port *pp); > + void (*msi_host_isr)(struct pcie_port *pp); > }; > > struct pcie_port { Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel