From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19D7EC433F5 for ; Wed, 4 May 2022 11:34:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QcezjtQUvGrY3Fy2WSNzpPstWCttgMvxVVT5JWNlNlA=; b=cjnzh8lbESQnDA 4lkxswcn/5RI+DsnvPKznfeVJh3zYFNN7VjbwjG5CcjariSHLhIJJE1FRuVMXqwdYxMb/y+C/qWr7 G3uLrllStEBYsFx7OhlP818QTkqLMQFdMhZs9UgOcxBJM70sHHs7Di8Iwc4EeFyPL3HjFIAfFx2C+ JXIIFX8/79ppOwvSWnJctWawtYosUk9+dU2M3zt9LUAaIfSvASJeZ2KYMerg8aTxDTRThkZTceb9a u56sOPE2cmFYAx+3EAlTtMsEC13R5eD/y0uYlsCm72+T1mmvX9ciIYjWP4Dy+vw+Ajo4jpZUTBvnh vgzlOQuz/lT2+F85N32A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmDGH-00ASJb-3d; Wed, 04 May 2022 11:33:41 +0000 Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmDF5-00ARSS-SX for linux-arm-kernel@lists.infradead.org; Wed, 04 May 2022 11:32:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1651663947; x=1683199947; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=W3uhH8QSuWoqMo3coiHySJmLORQN/e2Vzk0NgNP+CjA=; b=LZ56+HYU8cdvk0GHiFLS76PXwRJ9I31BJJo8j/et3gF62jOPfIkula/T 42EVG2N9zjqh3OPsoKcd0turk/k8bfEnSVqjySGDZLWgu/WMdOeyO4IF9 JTyTcgjGJNE2odxSC/IaYEUd5Qwl/terOJCgMVGUjVwrfOy8NrF3SZPkI w=; Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by alexa-out-sd-02.qualcomm.com with ESMTP; 04 May 2022 04:32:27 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg03-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2022 04:32:27 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 4 May 2022 04:32:26 -0700 Received: from [10.50.60.188] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 4 May 2022 04:32:22 -0700 Message-ID: <95c828ce-e0c8-adde-84da-bc37c215aaf1@quicinc.com> Date: Wed, 4 May 2022 17:02:18 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCHv14 0/9] lib/rwmmio/arm64: Add support to trace register reads/writes Content-Language: en-US To: , , CC: , , , , , , , References: From: Sai Prakash Ranjan In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220504_043227_996539_E222DE9A X-CRM114-Status: GOOD ( 30.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd, On 5/4/2022 4:58 PM, Sai Prakash Ranjan wrote: > Generic MMIO read/write i.e., __raw_{read,write}{b,l,w,q} accessors > are typically used to read/write from/to memory mapped registers > and can cause hangs or some undefined behaviour in following cases, > > * If the access to the register space is unclocked, for example: if > there is an access to multimedia(MM) block registers without MM > clocks. > > * If the register space is protected and not set to be accessible from > non-secure world, for example: only EL3 (EL: Exception level) access > is allowed and any EL2/EL1 access is forbidden. > > * If xPU(memory/register protection units) is controlling access to > certain memory/register space for specific clients. > > and more... > > Such cases usually results in instant reboot/SErrors/NOC or interconnect > hangs and tracing these register accesses can be very helpful to debug > such issues during initial development stages and also in later stages. > > So use ftrace trace events to log such MMIO register accesses which > provides rich feature set such as early enablement of trace events, > filtering capability, dumping ftrace logs on console and many more. > > Sample output: > > rwmmio_write: __qcom_geni_serial_console_write+0x160/0x1e0 width=32 val=0xa0d5d addr=0xfffffbfffdbff700 > rwmmio_post_write: __qcom_geni_serial_console_write+0x160/0x1e0 width=32 val=0xa0d5d addr=0xfffffbfffdbff700 > rwmmio_read: qcom_geni_serial_poll_bit+0x94/0x138 width=32 addr=0xfffffbfffdbff610 > rwmmio_post_read: qcom_geni_serial_poll_bit+0x94/0x138 width=32 val=0x0 addr=0xfffffbfffdbff610 > > This series is a follow-up for the series [1] and a recent series [2] making use > of both. > > [1] https://lore.kernel.org/lkml/cover.1536430404.git.saiprakash.ranjan@codeaurora.org/ > [2] https://lore.kernel.org/lkml/1604631386-178312-1-git-send-email-psodagud@codeaurora.org/ > > Note in v4 version, Arnd suggested to benchmark and compare size with callback > based implementation, please see [3] for more details on that with brief comparison below. > > > **Inline version with CONFIG_FTRACE=y and CONFIG_TRACE_MMIO_ACCESS=y** > $ size vmlinux > text data bss dec hex filename > 23884219 14284468 532568 38701255 24e88c7 vmlinux > > **Callback version with CONFIG_FTRACE=y and CONFIG_TRACE_MMIO_ACCESS=y** > $ size vmlinux > text data bss dec hex filename > 24108179 14279596 532568 38920343 251e097 vmlinux > > $ ./scripts/bloat-o-meter inline-vmlinux callback-vmlinux > add/remove: 8/3 grow/shrink: 4889/89 up/down: 242244/-11564 (230680) > Total: Before=25812612, After=26043292, chg +0.89% > > [3] https://lore.kernel.org/lkml/466449a1-36da-aaa9-7e4f-477f36b52c9e@quicinc.com/ > > Changes in v14: > * Add more description to disabling MMIO traces in geni serial drivers (Steve). > > Changes in v13: > * Remove the copyright update as one line change doesn't warrant it (Greg and Lawyers :)) > * Update the comment about disabling MMIO traces in geni se and uart drivers. > * Add description for the build time flag to asm-generic/io.h. > > Changes in v12: > * Split the generic flag addition patch (Greg). > * Move the flag from makefile to driver .c file (Greg). > > Changes in v11: > * Use unsigned long for caller ip and current ip addr (Steven Rostedt). > * Include review tags from Arnd. > > Changes in v10: > * Use GENMASK(31, 0) for -Woverflow warning in irqchip tegra driver (Marc). > * Convert ETM4x ARM64 driver to use asm-generic IO memory barriers (Catalin). > * Collect ack from Catalin for arm64 change. > > Changes in v9: > * Use TRACE_EVENT_CLASS for rwmmio_write and post_write (Steven Rostedt). > > Changes in v8: > * Fix build error reported by kernel test robot. > > Changes in v7: > * Use lib/ instead of kernel/trace/ based on review comment by Steven Rostedt. > > Changes in v6: > * Implemented suggestions by Arnd Bergmann: > - Use arch independent IO barriers in arm64/asm > - Add ARCH_HAVE_TRACE_MMIO_ACCESS > - Add post read and post write logging support > - Remove tracepoint_active check > * Fix build error reported by kernel test robot. > > Changes in v5: > * Move arm64 to use asm-generic provided high level MMIO accessors (Arnd). > * Add inline logging for MMIO relaxed and non-relaxed accessors. > * Move nVHE KVM comment to makefile (Marc). > * Fix overflow warning due to switch to inline accessors instead of macro. > * Modify trace event field to include caller and parent details for more detailed logs. > > Changes in v4: > * Drop dynamic debug based filter support since that will be developed later with > the help from Steven (Ftrace maintainer). > * Drop value passed to writel as it is causing hangs when tracing is enabled. > * Code cleanup for trace event as suggested by Steven for earlier version. > * Fixed some build errors reported by 0-day bot. > > Changes in v3: > * Create a generic mmio header for instrumented version (Earlier suggested in [1] > by Will Deacon and recently [2] by Greg to have a generic version first). > * Add dynamic debug support to filter out traces which can be very useful for targeted > debugging specific to subsystems or drivers. > * Few modifications to the rwmmio trace event fields to include the mmio width and print > addresses in hex. > * Rewrote commit msg to explain some more about usecases. > > Prasad Sodagudi (1): > lib: Add register read/write tracing support > > Sai Prakash Ranjan (8): > arm64: io: Use asm-generic high level MMIO accessors > coresight: etm4x: Use asm-generic IO memory barriers > irqchip/tegra: Fix overflow implicit truncation warnings > drm/meson: Fix overflow implicit truncation warnings > KVM: arm64: Add a flag to disable MMIO trace for nVHE KVM > asm-generic/io: Add logging support for MMIO accessors > serial: qcom_geni_serial: Disable MMIO tracing for geni serial > soc: qcom: geni: Disable MMIO tracing for GENI SE > > arch/Kconfig | 3 + > arch/arm64/Kconfig | 1 + > arch/arm64/include/asm/io.h | 41 ++------ > arch/arm64/kvm/hyp/nvhe/Makefile | 7 +- > drivers/gpu/drm/meson/meson_viu.c | 22 ++--- > .../coresight/coresight-etm4x-core.c | 8 +- > drivers/hwtracing/coresight/coresight-etm4x.h | 8 +- > drivers/irqchip/irq-tegra.c | 10 +- > drivers/soc/qcom/qcom-geni-se.c | 3 + > drivers/tty/serial/qcom_geni_serial.c | 3 + > include/asm-generic/io.h | 91 ++++++++++++++++- > include/trace/events/rwmmio.h | 97 +++++++++++++++++++ > lib/Kconfig | 7 ++ > lib/Makefile | 2 + > lib/trace_readwrite.c | 47 +++++++++ > 15 files changed, 288 insertions(+), 62 deletions(-) > create mode 100644 include/trace/events/rwmmio.h > create mode 100644 lib/trace_readwrite.c > Could you take first 4 patches which are independent and not related to MMIO tracing? And the rest can be taken once we get ack from Steve for the tracing part. Thanks, Sai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel