From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38801CD1297 for ; Thu, 4 Apr 2024 06:37:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sMP02Da4q/ygWx4UNsOE3eZHJocVxEvbxyHIqZqSDPg=; b=EDvWAhqz4slzUw vMY5ETNa5WCxgkVqEz7d/rvrD/9SIHoCNFAKOCLQYxx4sUDzXWOz3f1YCHIOYVTNNs3IyJMQXvJkn 1RF5/nGV4AocDHE/eesQusW+O9MBXxMBe9/L7QhhV0eKWyXncqH6LiNtbD5r7nTZLpp7o2H7uHPhC 9/qanihVAYESV0Ux1rqn3sh4+/SQXyDEDOlpN+GktV+8M/N0yMf9wTrfrabUKbgrjd+7D+ySvpa7+ u9adb029judC7QtYSw3SEuy4XXex1yzexKF2Oa04pBNuzDja9CFaSIuj40XcnyGPIGgxLDpyFrY9+ X2mxV7hNXXdRbBOqfNFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsGiR-00000001TY8-2u69; Thu, 04 Apr 2024 06:36:51 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsGiO-00000001TX0-2Yl8 for linux-arm-kernel@lists.infradead.org; Thu, 04 Apr 2024 06:36:50 +0000 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-516c1bbe314so942186e87.1 for ; Wed, 03 Apr 2024 23:36:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712212606; x=1712817406; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=2zKAxFOY7Srl3ScO6WnUAH2vVBLJhCxKCIkxZt7ZVco=; b=GfhrUSP0dGcNCJxjfp/+a2JLnxuzijW7bibLOI4oG1jMrp2vzxzZqVHjD75dS+zonp +e3yyyPGK6JPTqyiTvq3I3eKBDUsBrExolzATAnWvRmlYw/QU558pHangKWbzoo6T3SV p6RVud+LvrYAlMAbdI3UXE0HpwWLedgQDqPmJnEHtkGcPmWWBDY5BOrkeVtZWdoz5FS6 NWn5U7PztuDpRX2+qfeJJTvejsb1aLXskR9EiH46UYgBHoL9ftpN191wqpGBM4uGxD3e 8lxbXDSQL8gH+8vFEjsDyI21b4vp9XL9cQ3DFQf4f8CsCueMq8GkAtvCIqKnQQNGETYE BeZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712212606; x=1712817406; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2zKAxFOY7Srl3ScO6WnUAH2vVBLJhCxKCIkxZt7ZVco=; b=ILCAMy8ZutbFumtcS4ai955h9ahhU2flxyfpnZfQ3IXgainFfQ0b53431AXc6Qoo68 WayWSc/+TZKo2KO7mlVljgmTJR4gVLv1WGOYdZDNekc3Rr+X4/CSDWxgVEnYOUno9nUE KfDbaKFFK3O32I/p6h9ay97vW837t7grMT4z2bUEzeLcYdqyoHCnbERr4qoRhb0GDHu1 LRpd0brzKmEnmiZ0vsYKTHHDkw3iEMw4iDwWAVSh/2O3jLGtBC40+C2YjPAOw/p4vPxL 6MiFNsAnI8GzyHbSFO9v2lFN2LmbOSjy2SV86uexvXN57abEnYuapD/VoKRTfMUCPT4A EJbQ== X-Forwarded-Encrypted: i=1; AJvYcCUu11OhMGnboijQO+dxNQd6g0zcYaY+WlUcNPLWJ8Tqd35pzi/twgrqNnRpxEosmCO3zQZxVPM8KNwKIivsPjSbO2QEwm1+9XuuRIhUjNVLMTyiZMs= X-Gm-Message-State: AOJu0YzT+pz+nhVGzRqUzFae4NS3UQCApko4N788LKKVK8noNoxl7rHh QuhgOMZU8nyxQygK5qpc/otp6xR2DNz+aUe/yYVIA8GvLEoJHIFNluQLAu1uAcA= X-Google-Smtp-Source: AGHT+IGAojjYjuQHbsZ23M5TUMeoOaZmWr8G+SCEhCS4dvxhe6ieyt4tVHaLgJej+gwKtAG8GNIHKg== X-Received: by 2002:a05:6512:3b99:b0:516:bea2:5931 with SMTP id g25-20020a0565123b9900b00516bea25931mr1433669lfv.23.1712212606016; Wed, 03 Apr 2024 23:36:46 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id p6-20020a170906a00600b00a46d04b6117sm8668766ejy.64.2024.04.03.23.36.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Apr 2024 23:36:45 -0700 (PDT) Message-ID: <95d194ed-86fe-45df-88f1-ae460eb36eaf@linaro.org> Date: Thu, 4 Apr 2024 08:36:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] clk: en7523: add EN7581 support To: Lorenzo Bianconi , linux-clk@vger.kernel.org Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nbd@nbd.name, john@phrozen.org, devicetree@vger.kernel.org, dd@embedd.com, catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com, lorenzo.bianconi83@gmail.com, angelogioacchino.delregno@collabora.com References: <3aaf638b846ecfdbfc1c903206b7d519d56c9130.1712160869.git.lorenzo@kernel.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <3aaf638b846ecfdbfc1c903206b7d519d56c9130.1712160869.git.lorenzo@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_233649_279505_2A5327D4 X-CRM114-Status: GOOD ( 15.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/04/2024 18:20, Lorenzo Bianconi wrote: > Introduce EN7581 clock support to clk-en7523 driver. > > Tested-by: Zhengping Zhang > Signed-off-by: Lorenzo Bianconi > + return 0; > +} > + > static int en7523_clk_probe(struct platform_device *pdev) > { > struct device_node *node = pdev->dev.of_node; > @@ -306,6 +413,12 @@ static int en7523_clk_probe(struct platform_device *pdev) > if (IS_ERR(np_base)) > return PTR_ERR(np_base); > > + if (of_device_is_compatible(node, "airoha,en7581-scu")) { Having matching and compatible comparisons inside various code is discouraged. Does not scale. Use driver/match data to store some sort of flags and check for the flag or some other parameter. The best if compatible appears once and only once: in of_device_id. > + r = en7581_clk_hw_init(pdev, base, np_base); > + if (r) > + return r; > + } > + > clk_data = devm_kzalloc(&pdev->dev, > struct_size(clk_data, hws, EN7523_NUM_CLOCKS), > GFP_KERNEL); > @@ -329,8 +442,15 @@ static const struct clk_ops en7523_pcie_ops = { > .unprepare = en7523_pci_unprepare, > }; > > +static const struct clk_ops en7581_pcie_ops = { > + .is_enabled = en7581_pci_is_enabled, > + .prepare = en7581_pci_prepare, > + .unprepare = en7581_pci_unprepare, > +}; > + > static const struct of_device_id of_match_clk_en7523[] = { > { .compatible = "airoha,en7523-scu", .data = &en7523_pcie_ops }, > + { .compatible = "airoha,en7581-scu", .data = &en7581_pcie_ops }, > { /* sentinel */ } > }; > Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel