From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 218E5CD3431 for ; Wed, 4 Sep 2024 09:46:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9RGuzKvIeYLmaPxh+OH8P69f+WSpAfCh6ohNYrSmNCA=; b=z9122xMraR4tSIbM2qk/cq/PiR myzj+RuapPP8V9Bm/siPxxY5V9kVpF/OiA5eoJF6D5JlbxgNBdzTRvI2zXenMX2TfpsQBf2bIOjkG I7bKTm6lL08OqlMHyMmddlkAVPoVhmTtJ1eBAGJCZ34X0zq6s61kkpJAZ1GcSeKPdoFnh0B+BOYFc s4QxGycAfXvu/7niAA1N3QnF7g3rH4xaWABUWitZLSC33Pq0Su1i0mmmAQcRwakEvZxf1j8JYFk11 mw72JXviwdX7fVwAEAfZANVmAk8WiYEPKRm7F0zD3LbTUF6FR2ypjuQDkmwFHvI2H4dXZj8z7i9A4 UVtFC0Kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slmb5-00000003ks1-0c2f; Wed, 04 Sep 2024 09:46:43 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sllwv-00000003aDD-0SdT for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2024 09:05:14 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sllwo-0004y2-V0; Wed, 04 Sep 2024 11:05:06 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sllwo-005Pbe-FT; Wed, 04 Sep 2024 11:05:06 +0200 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1sllwo-0005fP-1F; Wed, 04 Sep 2024 11:05:06 +0200 Message-ID: <95efd6b6491069d04b4bfae6616d9a43ba8467a6.camel@pengutronix.de> Subject: Re: [PATCH v2 1/2] gpu: ipu-v3: vdic: Simplify ipu_vdi_setup() From: Philipp Zabel To: Marek Vasut , linux-media@vger.kernel.org Cc: Daniel Vetter , David Airlie , Fabio Estevam , Greg Kroah-Hartman , Helge Deller , Mauro Carvalho Chehab , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Steve Longerbeam , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev Date: Wed, 04 Sep 2024 11:05:06 +0200 In-Reply-To: <20240724002044.112544-1-marex@denx.de> References: <20240724002044.112544-1-marex@denx.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_020513_241668_3404328E X-CRM114-Status: UNSURE ( 8.64 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mi, 2024-07-24 at 02:19 +0200, Marek Vasut wrote: > The 'code' parameter only ever selects between YUV 4:2:0 and 4:2:2 > subsampling, turn it into boolean to select exactly that and update > related code accordingly. >=20 > Signed-off-by: Marek Vasut I'd prefer this to be an enum ipu_chroma_subsampling or similar, instead of a boolean. Otherwise, Reviewed-by: Philipp Zabel regards Philipp