RE: [PATCH V5] regulator: da9062: Make the use of IRQ optional

From: Christoph Niedermaier <cniedermaier@dh-electronics.com>
To: Mark Brown <broonie@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Support Opensource <support.opensource@diasemi.com>,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	Liam Girdwood <lgirdwood@gmail.com>, Marek Vasut <marex@denx.de>,
	kernel <kernel@dh-electronics.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V5] regulator: da9062: Make the use of IRQ optional
Date: Thu, 13 Jul 2023 15:36:38 +0000	[thread overview]
Message-ID: <9629970cc2c3452e83a43660823319e5@dh-electronics.com> (raw)
In-Reply-To: <d8f60e51-2d62-4370-9032-51eda744239d@sirena.org.uk>

From: Mark Brown [mailto:broonie@kernel.org]
Sent: Thursday, July 13, 2023 2:30 PM
> On Thu, Jul 13, 2023 at 11:03:28AM +0200, Christoph Niedermaier wrote:
> 
>> This patch makes the use of IRQ optional to make the DA9061/62 usable
>> for designs that don't have the IRQ pin connected, because the regulator
>> is usable without IRQ.
> 
> Are there any dependencies for this patch?  The fact that I acked it
> makes me think there were MFD parts

It's a patch series. This patch is the last one in this series, that is
missing to have the ability to run the DA9061/62 without a connected IRQ
pin. The other patches are already upstreamed and yes there are MFD parts,
see below:

1: commit 7ef5c57758c4 ("dt-bindings: mfd: da9062: Move IRQ to optional properties")
2: commit 7d61f6313e90 ("mfd: da9062: Use MFD_CELL_OF macro")
3: commit c923d5001ba0 ("mfd: da9062: Remove IRQ requirement")
4: This patch ("regulator: da9062: Make the use of IRQ optional")

>> Reported-by: kernel test robot <lkp@intel.com>
>> Link: https://lore.kernel.org/oe-kbuild-all/202303082246.GuLdPL0t-lkp@intel.com/
> 
> I really doubt that the LKP bot ran into an issue due to a system with
> this device without an IRQ wired up...

In V3 of this patch the kernel test robot found an issue. I had really
overlooked that. Thanks to LKP. I forgot to replace the irq variable in
the function devm_request_threaded_irq(). So it affected the path with
IRQ. In V4 I fixed that. In V5 I only rebased it on the current next
20230713 and add Marek's Reviewed-by tag.

Regards
Christoph

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel