From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 630A2C54EBC for ; Tue, 10 Jan 2023 16:42:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JP3k0fiT9ZP0S1SlU1ZC7AuCZ9IxJ1PLIWvKrhn+H1o=; b=wgaCPdmbrnv4mU 2UpU1Yc2aoqkwvv0Jec+GMJKvG3tPY26LEBHlm/oNeRfJAm/MuZAP1wdmrt04Futpvq5uWMw79/+3 vhotXSP9HVqia2zO8MrZ6hioHgMu2A0jXsNzJFxNGon2IioU6NjbXccZBX1SpM2AhA8mtACEP/8R9 E4/lS6snoxD/8K1rQUpDxaF8Pvm/Pc0xAcAWtil3sVpwtOjZnjKLBZQIE6WVIkZY+unviafAFYNdv gn2wGzCdfc6SqkL6mNnEWmxp7zzuli/RotMgFrPIctgohpdGXPCPz+ptIWbFAOK3W2ybF1FxnQL57 TCVT/fnHsR9m5GSkVqHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFHgS-007pRJ-1W; Tue, 10 Jan 2023 16:41:08 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFHgO-007pPl-PJ for linux-arm-kernel@lists.infradead.org; Tue, 10 Jan 2023 16:41:06 +0000 Received: by mail-wm1-x32a.google.com with SMTP id p1-20020a05600c1d8100b003d8c9b191e0so10542870wms.4 for ; Tue, 10 Jan 2023 08:41:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Th4XS3ExnJps+ejGgAt+lEc+wt5pkhQaMhYYIYNJy0U=; b=a2RI/NAz23mB851gzvwuv+p7hExudFo71Jz2+0oDw0T1EhzC7jwPZqmqwBS3mZ7Pk5 XN+mp23UWm76WcYPMr+2b0ss91RHKvx5Q3bTO6u/8pXjO8pCxW5ph1dwoq/P9vV/hU8P uotbWX0UA1lJXNzp/yuQyd+Lybnq+sTqqt4Wu8jG1aiinRxynfX9xOUkrXVM8KlULoUd 8fO+I6pUurdwv+JnjMTH1bjinN+feq4bT35Uf3/Uy+IpzcgzqQ7JahwDt2J12PTMjSky UqYsIc6fT9oEA/mGd0GtJKQnrOVgfM4z/YU/ABm/7341rcFsAxWKw8PKuZUveZxmvBsH 2hHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Th4XS3ExnJps+ejGgAt+lEc+wt5pkhQaMhYYIYNJy0U=; b=4PSx86HaenJwkE6OK+1amw6nz7Ty9LQH139VNcqit7zLtSdoEZbZK0Zz4biFniLmLb toz5Txtc8foLD7untO7xb/stFlCLpGTE9DVt4t069yPFH//7uquGyHEi0WH1zO4C8pCJ cPIKgkkQCv0cpPMfAFmZZ6mcGHBTO5ti8RRw5ghB4WVvqZ/ACDWS3gMuMXHpmpiLa5x2 mKa6F0wXUij1KBmGjGrHTebXgAid8AvbVf4+tWR2JyznlxnkPfPjjgAjMhX6ak5mi+NZ lPZLtyOSMCV1ckgnOSSfAuWk8pXUnAnGO3uQetpTiTkgn2ZgefhRNs/qGQqSHHnFXXPs sGMA== X-Gm-Message-State: AFqh2koI4FOeZOdYtOjR8pTZN+zXoCPmj4pNcJ0YpywrQQWYkZPYusev mtGhYk2rA+dnTphNhE4IeGfTM77VSZFX+uQY X-Google-Smtp-Source: AMrXdXskmZw3ugW9Pk8CVGZsMZh1RbFbAqdASFjBu3L9/SbBgfi3fYgfSX8zXMjI3EW8xExE+p+a9Q== X-Received: by 2002:a05:600c:46c7:b0:3d9:ee3d:2f54 with SMTP id q7-20020a05600c46c700b003d9ee3d2f54mr6883493wmo.13.1673368863486; Tue, 10 Jan 2023 08:41:03 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id he12-20020a05600c540c00b003d9ddc82450sm15086035wmb.45.2023.01.10.08.41.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 08:41:03 -0800 (PST) Message-ID: <9640d2a0-7245-285e-0e7a-d75bfe3f88ac@linaro.org> Date: Tue, 10 Jan 2023 17:40:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 09/11] dt-bindings: mmc: convert amlogic,meson-gx.txt to dt-schema Content-Language: en-US To: neil.armstrong@linaro.org, Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Srinivas Kandagatla , Wim Van Sebroeck , Guenter Roeck , Mauro Carvalho Chehab , Alessandro Zummo , Alexandre Belloni , Daniel Lezcano , Thomas Gleixner , Vinod Koul , Kishon Vijay Abraham I , Ulf Hansson , Bjorn Helgaas , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Heiner Kallweit , Russell King Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-media@vger.kernel.org, linux-rtc@vger.kernel.org, linux-phy@lists.infradead.org, linux-mmc@vger.kernel.org, linux-pci@vger.kernel.org, netdev@vger.kernel.org References: <20221117-b4-amlogic-bindings-convert-v2-0-36ad050bb625@linaro.org> <20221117-b4-amlogic-bindings-convert-v2-9-36ad050bb625@linaro.org> <2037156d-5113-4b96-8f86-c8ef1c1fdf96@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <2037156d-5113-4b96-8f86-c8ef1c1fdf96@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230110_084104_870419_253FA02F X-CRM114-Status: GOOD ( 19.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/01/2023 15:17, Neil Armstrong wrote: > On 10/01/2023 11:17, Krzysztof Kozlowski wrote: >> On 09/01/2023 13:53, Neil Armstrong wrote: >>> Convert the Amlogic SD / eMMC controller for S905/GXBB family SoCs >>> to dt-schema. >>> >>> Take in account the used variant with amlogic,meson-gx-mmc. >>> >>> Signed-off-by: Neil Armstrong >>> --- >>> .../bindings/mmc/amlogic,meson-gx-mmc.yaml | 75 ++++++++++++++++++++++ >>> .../devicetree/bindings/mmc/amlogic,meson-gx.txt | 39 ----------- >>> 2 files changed, 75 insertions(+), 39 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml >>> new file mode 100644 >>> index 000000000000..30228964fd9c >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml >>> @@ -0,0 +1,75 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/mmc/amlogic,meson-gx-mmc.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Amlogic SD / eMMC controller for S905/GXBB family SoCs >>> + >>> +description: >>> + The MMC 5.1 compliant host controller on Amlogic provides the >>> + interface for SD, eMMC and SDIO devices >>> + >>> +maintainers: >>> + - Neil Armstrong >>> + >>> +allOf: >>> + - $ref: mmc-controller.yaml# >>> + >>> +properties: >>> + compatible: >>> + oneOf: >>> + - enum: >>> + - amlogic,meson-gx-mmc >>> + - amlogic,meson-axg-mmc >>> + - items: >>> + - const: amlogic,meson-gx-mmc >> >> This does not look correct. Either gx is alone (not compatible with >> gxbb) or it is compatible with gxbb. Cannot be both. > > This ishow it's used in DT: > > arch/arm64/boot/dts/amlogic/meson-gx.dtsi: compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc"; > arch/arm64/boot/dts/amlogic/meson-axg.dtsi: compatible = "amlogic,meson-axg-mmc"; > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi: compatible = "amlogic,meson-axg-mmc"; > > So I'll drop the amlogic,meson-gx-mmc in the first enum to have : > +properties: > + compatible: > + oneOf: > + - const: amlogic,meson-axg-mmc > + - items: > + - const: amlogic,meson-gx-mmc > + - const: amlogic,meson-gxbb-mmc > > It's right ? Yes. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel