From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Maíra Canal" <mcanal@igalia.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Melissa Wen" <mwen@igalia.com>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Andre Przywara" <andre.przywara@arm.com>,
"Romain Perier" <romain.perier@gmail.com>,
"Stefan Wahren" <wahrenst@gmx.net>
Cc: dri-devel@lists.freedesktop.org,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, kernel-dev@igalia.com
Subject: Re: [PATCH] ARM: dts: bcm2835: Enable 3D rendering through V3D
Date: Fri, 12 Apr 2024 15:33:35 +0200 [thread overview]
Message-ID: <9647e461-a299-41fe-a078-5bbfffcc985c@linaro.org> (raw)
In-Reply-To: <20240412132559.2365947-1-mcanal@igalia.com>
On 12/04/2024 15:25, Maíra Canal wrote:
> RPi 0-3 is packed with a GPU that provides 3D rendering capabilities to
> the RPi. Currently, the downstream kernel uses an overlay to enable the
> GPU and use GPU hardware acceleration. When deploying a mainline kernel
> to the RPi 0-3, we end up without any GPU hardware acceleration
> (essentially, we can't use the OpenGL driver).
>
> Therefore, enable the V3D core for the RPi 0-3 in the mainline kernel.
>
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>
> I decided to add the status property to the `bcm2835-common.dtsi`, but
> there are two other options:
>
> 1. To add the status property to the `bcm2835-rpi-common.dtsi` file
> 2. To add the status property to each individual RPi model, e.g.
> `bcm2837-rpi-3-b.dts`.
>
> Let me know which option is more suitable, and if `bcm2835-common.dtsi`
> is not the best option, I can send a v2.
>
> Best Regards,
> - Maíra
>
> arch/arm/boot/dts/broadcom/bcm2835-common.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/broadcom/bcm2835-common.dtsi b/arch/arm/boot/dts/broadcom/bcm2835-common.dtsi
> index 9261b67dbee1..851a6bce1939 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2835-common.dtsi
> +++ b/arch/arm/boot/dts/broadcom/bcm2835-common.dtsi
> @@ -139,6 +139,7 @@ v3d: v3d@7ec00000 {
> compatible = "brcm,bcm2835-v3d";
> reg = <0x7ec00000 0x1000>;
> interrupts = <1 10>;
> + status = "okay";
Please point me where this is being disabled? Could not find.
Anyway, enabling should be done in last place of override/extend, which
provides additional properties. I believe it is being extend further, so
that's not the place.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-12 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 13:25 [PATCH] ARM: dts: bcm2835: Enable 3D rendering through V3D Maíra Canal
2024-04-12 13:33 ` Krzysztof Kozlowski [this message]
2024-04-12 17:17 ` Stefan Wahren
2024-04-14 18:43 ` Phil Elwell
2024-04-14 18:54 ` Stefan Wahren
2024-04-14 19:09 ` Maíra Canal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9647e461-a299-41fe-a078-5bbfffcc985c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andre.przywara@arm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-dev@igalia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mcanal@igalia.com \
--cc=mripard@kernel.org \
--cc=mwen@igalia.com \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=romain.perier@gmail.com \
--cc=sbranden@broadcom.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).