From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2ACC3C433EF for ; Sun, 12 Dec 2021 07:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:Subject:From:References:Cc:To: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jfzB8/P+0JqOvNT0dd7lE55I3VdBMecqrh+aExcNPIw=; b=2LOi0k4u33AinF JMMK4+s2biz8MWSRtsPY1vtlvhLXUGC8oNMoGB58SH5eka2w68FigsmcBK+nO2j8GPDulu6VKh+3G gGhkZRsGvALdNkLrKwlMUwfLd/k3yG+5agV90sAS81vBBSuuAnSAg7O8T3gTr//HUYG0nkdcQKEvV my6GtnMZHOz+EKr90TUDqcZ+BMCDtFyT2oMQLpsizyal0c7CihJ7/ISzAv0kPism/Sh4iJ3N+PB36 8G/F8B3aQ/IJCfjdbHwA+5T/xhBWYbePXlpzxgLnjd/ozsQv+E4gPmh+xITss7mrSpNc0+aHU1LQx EOMOMZ+hTw2XDKHbMqFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwIpJ-0062SD-By; Sun, 12 Dec 2021 06:59:17 +0000 Received: from nbd.name ([2a01:4f8:221:3d45::2]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwIpF-0062Rm-Hw for linux-arm-kernel@lists.infradead.org; Sun, 12 Dec 2021 06:59:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=GvGABmN1IzmAjQz5YBl62ziV04ZyJd0OtjQy7W4FVyw=; b=gQkGGePENixu3PJ1t98MyuGZ5F wUzTbb8ka3jGSxUgLqb2jKOjSuxoIU2oX79NFHkUd22/EAvK/5+SPZRA7u+uMUBrMitTWNBL+HuXt ySKt6Qnv2iULLoYC9hHSldZ1qOEqS9xeNTgI7oWXS63XbfrFySm0peyOX2p+ueG6LcpA=; Received: from p54ae911a.dip0.t-ipconnect.de ([84.174.145.26] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1mwIp9-0006eA-1J; Sun, 12 Dec 2021 07:59:07 +0100 Message-ID: <964e56b6-1245-c870-ac86-844c69eac29f@nbd.name> Date: Sun, 12 Dec 2021 07:59:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Content-Language: en-US To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski , john@phrozen.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20211129153330.37719-1-nbd@nbd.name> <20211129153330.37719-13-nbd@nbd.name> From: Felix Fietkau Subject: Re: [PATCH v5 12/13] gpio: Add support for Airoha EN7523 GPIO controller In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211211_225913_853186_CC337B5D X-CRM114-Status: GOOD ( 12.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-12-05 00:57, Linus Walleij wrote: > On Thu, Dec 2, 2021 at 6:59 PM Felix Fietkau wrote: > >> I just looked at the datasheet and the driver code again, and I think >> EN7523 is too strange for proper generic GPIO support. > > Yup I see that John explained it to me in the past, no problem. > Let's do it like this then, but just drop select GPIO_GENERIC > from KConfig since it's not used. > > With that oneliner change: > Reviewed-by: Linus Walleij > > Yours, > Linus Walleij The generic GPIO API is still used for the data register. The driver calls bgpio_init(), so you suggested oneliner change won't work. - Felix _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel