From: "Arnd Bergmann" <arnd@arndb.de>
To: "Angelo Dureghello" <angelo@kernel-space.org>,
"Greg Ungerer" <gerg@linux-m68k.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Steven King" <sfking@fdwdc.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Cc: "Greg Ungerer" <gerg@uclinux.org>,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
"Angelo Dureghello" <adureghello@baylibre.com>
Subject: Re: [PATCH 10/10] iio: dac: add mcf54415 DAC
Date: Mon, 04 May 2026 19:27:14 +0200 [thread overview]
Message-ID: <965cb599-37ac-4d69-a8c0-015152037139@app.fastmail.com> (raw)
In-Reply-To: <20260504-wip-stmark2-dac-v1-10-874c36a4910d@baylibre.com>
On Mon, May 4, 2026, at 19:16, Angelo Dureghello wrote:
> +static void mcf54415_dac_exit(void *data)
> +{
> + struct mcf54415_dac *info = data;
> + int val;
> +
> + val = readw(info->regs + MCF54415_DAC_CR);
> + val |= MCF54415_DAC_CR_PDN;
> + writew(val, info->regs + MCF54415_DAC_CR);
> +}
We've recently discussed changing the MMIO accessors on coldfire
to behave like all the other ones, which makes readw() and writew()
have an implicit byteswap. An additional driver means one more
place to change during the conversion. Maybe you can use the
new mcf_readw()/mcf_writew() helpers that Greg has started
introducing? Those will keep using native big-endian register
definitions.
Arnd
next prev parent reply other threads:[~2026-05-04 17:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 17:16 [PATCH 00/10] add mcf54415 DAC driver Angelo Dureghello
2026-05-04 17:16 ` [PATCH 01/10] m68k: mcf5441x: fix clocks numbering Angelo Dureghello
2026-05-04 17:16 ` [PATCH 02/10] m68k: mcf5441x: add clock for DAC channel 1 Angelo Dureghello
2026-05-04 17:16 ` [PATCH 03/10] m68k: mcf5441x: setup DAC clock name as per driver name Angelo Dureghello
2026-05-04 17:16 ` [PATCH 04/10] m68k: defconfig: update stmark2 defconfig Angelo Dureghello
2026-05-04 17:16 ` [PATCH 05/10] m68k: add DAC modules base addresses Angelo Dureghello
2026-05-04 17:16 ` [PATCH 06/10] m68k: mcf5441x: add CCM registers Angelo Dureghello
2026-05-04 17:16 ` [PATCH 07/10] m68k: mcf5441x: add CCR MISCCR2 bitfields Angelo Dureghello
2026-05-06 14:49 ` Jonathan Cameron
2026-05-06 14:56 ` Jonathan Cameron
2026-05-04 17:16 ` [PATCH 08/10] m68k: stmark2: add mcf5441x DAC platform devices Angelo Dureghello
2026-05-04 17:28 ` Arnd Bergmann
2026-05-06 14:57 ` Jonathan Cameron
2026-05-06 21:07 ` Angelo Dureghello
2026-05-05 8:31 ` Andy Shevchenko
2026-05-04 17:16 ` [PATCH 09/10] m68k: stmark2: enable DACs outputs Angelo Dureghello
2026-05-05 2:12 ` Greg Ungerer
2026-05-05 8:32 ` Andy Shevchenko
2026-05-06 14:53 ` Jonathan Cameron
2026-05-04 17:16 ` [PATCH 10/10] iio: dac: add mcf54415 DAC Angelo Dureghello
2026-05-04 17:27 ` Arnd Bergmann [this message]
2026-05-05 2:06 ` Greg Ungerer
2026-05-05 5:54 ` Angelo Dureghello
2026-05-04 19:13 ` Nuno Sá
2026-05-05 8:45 ` Andy Shevchenko
2026-05-06 15:20 ` Jonathan Cameron
2026-05-04 19:57 ` [PATCH 00/10] add mcf54415 DAC driver Angelo Dureghello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=965cb599-37ac-4d69-a8c0-015152037139@app.fastmail.com \
--to=arnd@arndb.de \
--cc=adureghello@baylibre.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andy@kernel.org \
--cc=angelo@kernel-space.org \
--cc=dlechner@baylibre.com \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nuno.sa@analog.com \
--cc=sfking@fdwdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox