From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0638DC54EBC for ; Sat, 7 Jan 2023 13:24:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6Z7C13pRdUL1WW9+d5JxTU11bc/TOZRtHjhJGQB3lSk=; b=UKv2IeP3eR7x6g AWEajQau08QM1JNaeoJ4geaFgK76I/8ORTYQoq5eea+0TNJgjBDqZpN8bQMWwmHNPhUKo/QgHxqM+ T0/j2wZ/p3zjJLSuoiN/B0Q8Pl4VbD26TkroJ0dAOHJgjHenZRlq0vJ2JEWd/wr0Y6pFb1Zceh2zy 9n/bId2Ih7X0/fm3r+LzOssQwVUchZ7zVHtukWEVci+xu4pQoNho61hzAi+uOs4e2v5JAO1RtFVCq P/sZ219WXvPZD+R7tkr2H3HCxUrU80gNhP75jt6yrwfN8+hu52e1H0v4f05CMA2vx04FiHwq8iYq6 jg7P0CFf4cQFcTxVrMHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pE9AR-005CBu-8T; Sat, 07 Jan 2023 13:23:23 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pE9AI-005Bvc-9l for linux-arm-kernel@lists.infradead.org; Sat, 07 Jan 2023 13:23:16 +0000 Received: by mail-wr1-x42a.google.com with SMTP id co23so3636607wrb.4 for ; Sat, 07 Jan 2023 05:23:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K4D1FN6eoWh6/baEX5q5IhUe1DAOLv2u6UT+9a6+KXo=; b=HgVvj6Lvf1kT1S13QgbEY1hX2YQIt4Tg9f9o4ln/tSbFzVvqrgAL5tc5bGWpL/MQ0S rEUEVMJm1tuGubqk6C4J3rM45jhvhgA4OwhmTSmryJPzK0S1v966jXX12NVUfCA0OguR l9EhZElZa2ofhVzsxP/tokGHCBF76PuLWmVENy2nBmp465JyPZsxZ7kF9OmKiCqfxM5s utv7fWq6azCoC2Uy5BnP89PM18Cq4HF/E3EUa5Z7f/IcVnx4AF4uJ1T1E/1jFbnI0JOf uVwdfaylqR+BRIylcqDHxFA9+IK8qOZe8fir4opy9T9JbMMmrqF+DF2IfDCKd+ldYFJ4 A74Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K4D1FN6eoWh6/baEX5q5IhUe1DAOLv2u6UT+9a6+KXo=; b=S6Dmtn1xxTuIQ4bV5ipe33nibDjukJuUt0JkRgBW1fDLnKjBXUJAt7ill5HlRtVrtZ DRok+m8kJPxSXDluV/le8szJ+h7whNvjE7WOFWDUxd6PJZVYyuyPEyjefM/y62Zy33tm Hck/T8kj7P9uuNQxKk0poBd1rOGMGMq92fHASl8y88BBkhpDwL1XQQ7eW8MsOj1J8UQ9 EFvAQEeCGw8qihDERUzNSRmJA0iY+aFlWPv7a2LJuqrIZkTGi3cIqTPAePrDt59i5ksS hhaxZ8lBIey/rNn3pZcmMGs/CI9NP2Nh4V3SVhDosjdUWbrOc5+YhBQ6O8Z6M6M+saBK b0Tw== X-Gm-Message-State: AFqh2krzRbBLjzlux3LGXWpxvhJfmOHVjiW7jTd0rkceAUNe/5lYR3ix +CYqardL7UOjlVc66DN4Jn19jQ== X-Google-Smtp-Source: AMrXdXt8rJ+gmrzzwuVyvcafa8P6rsX9w8GvR+yJ3ia+IO6yFnBWk/w5pE1qGkuFyw8Ftqd6qRyj7w== X-Received: by 2002:a05:6000:1566:b0:242:2b3c:c7e with SMTP id 6-20020a056000156600b002422b3c0c7emr53021473wrz.17.1673097791738; Sat, 07 Jan 2023 05:23:11 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id s1-20020a5d4ec1000000b002882600e8a0sm3973599wrv.12.2023.01.07.05.23.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Jan 2023 05:23:10 -0800 (PST) Message-ID: <967cc7b7-f0bb-de37-52b9-7bfab05eadd7@linaro.org> Date: Sat, 7 Jan 2023 14:23:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] dt-bindings: mmc: fsl-imx-esdhc: allow more compatible combinations Content-Language: en-US To: Andreas Kemnade Cc: ulf.hansson@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230105213856.1828360-1-andreas@kemnade.info> <20230106203358.14878660@aktux> From: Krzysztof Kozlowski In-Reply-To: <20230106203358.14878660@aktux> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230107_052314_860208_CDF5DBEE X-CRM114-Status: GOOD ( 17.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/01/2023 20:33, Andreas Kemnade wrote: > On Fri, 6 Jan 2023 09:41:01 +0100 > Krzysztof Kozlowski wrote: > >> On 05/01/2023 22:38, Andreas Kemnade wrote: >>> Currently make dtbs_check shows lots of errors because imx*.dtsi does >>> not use single compatibles but combinations of them. >>> Allow all the combinations used there. >>> >>> Patches fixing the dtsi files according to binding documentation were >>> submitted multiple times and are commonly rejected, so relax the rules. >>> Example: >>> https://lore.kernel.org/linux-devicetree/72e1194e10ccb4f87aed96265114f0963e805092.camel@pengutronix.de/ >>> >>> Reason: compatibility of new dtbs with old kernels or bootloaders. >>> >>> This will significantly reduce noise on make dtbs_check. >>> >>> Signed-off-by: Andreas Kemnade >>> --- >>> .../bindings/mmc/fsl-imx-esdhc.yaml | 24 +++++++++++++++++++ >>> 1 file changed, 24 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml >>> index dc6256f04b42..118ebb75f136 100644 >>> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml >>> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml >>> @@ -37,6 +37,30 @@ properties: >>> - fsl,imx8mm-usdhc >>> - fsl,imxrt1050-usdhc >>> - nxp,s32g2-usdhc >> >> You must drop the items from enum above. Binding saying: >> compatible="A" >> or: >> compatible="A", "B" >> >> is not correct. Either A is or is not compatible with B. >> > hmm, here we have A = B + some additional features > or > A = B + some additional features and additional quirks required. So why do you allow A alone? > > For the latter we have e.g. > A= > static const struct esdhc_soc_data usdhc_imx6sx_data = { > .flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING > | ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200 > | ESDHC_FLAG_STATE_LOST_IN_LPMODE > | ESDHC_FLAG_BROKEN_AUTO_CMD23, > }; > B= > static const struct esdhc_soc_data usdhc_imx6sl_data = { > .flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING > | ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_ERR004536 > | ESDHC_FLAG_HS200 > | ESDHC_FLAG_BROKEN_AUTO_CMD23, > }; > > so there is the difference in ESDHC_FLAG_STATE_LOST_IN_LPMODE. > That might make no difference in some usage scenario (e.g. some bootloader > not doing any LPMODE), but I wonder why > we need to *enforce* specifying such half-compatible things. I asked to remove half-compatible. Not to enforce. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel