public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: stefan@agner.ch (Stefan Agner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/fsl-dcu: add COMMON_CLK dependency
Date: Mon, 02 May 2016 14:22:04 -0700	[thread overview]
Message-ID: <96882621acf64dca8d6c1d2f25307385@agner.ch> (raw)
In-Reply-To: <1462186839-2224021-1-git-send-email-arnd@arndb.de>

On 2016-05-02 04:00, Arnd Bergmann wrote:
> The fsl dcu now uses the clk-provider interfaces, which are not available
> when CONFIG_COMMON_CLK is disabled:
> 
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c: In function 'fsl_dcu_drm_probe':
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c:362:20: error: implicit
> declaration of function '__clk_get_name'
> [-Werror=implicit-function-declaration]
>   pix_clk_in_name = __clk_get_name(pix_clk_in);
> 
> This adds a Kconfig dependency to prevent the driver from being enabled
> in this case.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 2d701449bce1 ("drm/fsl-dcu: use common clock framework for
> pixel clock divider")

Oh right, thx!

Acked-by: Stefan Agner <stefan@agner.ch>

@Dave, can you pick that up directly or do you prefer a pull request?

--
Stefan

> ---
>  drivers/gpu/drm/fsl-dcu/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/fsl-dcu/Kconfig b/drivers/gpu/drm/fsl-dcu/Kconfig
> index c78cf3f605d0..b9c714de6e40 100644
> --- a/drivers/gpu/drm/fsl-dcu/Kconfig
> +++ b/drivers/gpu/drm/fsl-dcu/Kconfig
> @@ -1,6 +1,6 @@
>  config DRM_FSL_DCU
>  	tristate "DRM Support for Freescale DCU"
> -	depends on DRM && OF && ARM
> +	depends on DRM && OF && ARM && COMMON_CLK
>  	select BACKLIGHT_CLASS_DEVICE
>  	select BACKLIGHT_LCD_SUPPORT
>  	select DRM_KMS_HELPER

  reply	other threads:[~2016-05-02 21:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-02 11:00 [PATCH] drm/fsl-dcu: add COMMON_CLK dependency Arnd Bergmann
2016-05-02 21:22 ` Stefan Agner [this message]
2016-05-03  8:18   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96882621acf64dca8d6c1d2f25307385@agner.ch \
    --to=stefan@agner.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox