From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60B6DC001B0 for ; Wed, 5 Jul 2023 08:35:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BvyzFWC601zzrD385ZPW2R9DJrGG2qhH71/Unkt6Gkw=; b=S3SQBQMUUahprD J52K8Ay9gfhZ9ftSSx05QUaVZRYTJF5F1YzkaUUuVwdOCtq8anDNohxO15wbYz1ctOTpF7u2d/m2p pJQIXdtpVRqIH+eXLNkwy1bOChng89JYdcteib622jce4GpsPxOg62Mnu/F+8PQ6AISyGFZW2TulV S0MZcGUg6t4yICJqV1sauL3zPGR0RqxNwtNg69BHmbBJddTUCvRKIlZiDCkvSxHWAcb8tNnSYoccp J4T6IkX8hgNucCyhJFwSMdTgRPfUuDoeu9VZ6JyUUJlvXFc3l2ggFLuKJxx058QVcuVdTb09XulVK dXRaVWnRKeUQGqc8HZZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGxy4-00FEPE-2J; Wed, 05 Jul 2023 08:34:32 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGxy1-00FEOS-0A for linux-arm-kernel@lists.infradead.org; Wed, 05 Jul 2023 08:34:30 +0000 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3657kl4r004902; Wed, 5 Jul 2023 08:34:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=47xGRx8X89NPv+AJ+kRPJuy8G/+b0hfke+iKGy566Ok=; b=YTvD4a88CccbuFGCn0ZTovRkkLlj6OHa5npKlnSrRICPQWWzUAobYNU0/aY2cfI7vxZb +lHTM9j9+k22CTM3XRKW2duE7xa8uSj/U5Ij52CaCmMwY+LIKODsl4Ne1DTR8aAj2Ul2 rW5RmHTUSRccIqkW5SqLwxCAhORoLfXw5KzpXR40S+KSYpgxFlPb6aqnwe0z0QObAvUA kuGs2WkNxB8jpKjEubAsx27Fn3NOI+E/M8L3VadbyUSmoBfMn4HpKvNT4wO+4qX8YJB5 21KsB87+aOTrQU+ThaMrgjbYwijyXeJe25AIQBsrAK3vheN2tnZcqy0v8NBI0ms6l6XT Gw== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rmfqjjjj6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Jul 2023 08:34:22 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3658YLES026583 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 5 Jul 2023 08:34:21 GMT Received: from [10.50.20.241] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Wed, 5 Jul 2023 01:34:14 -0700 Message-ID: <968fb5d3-6cd8-7850-47e7-682e26f9ee5f@quicinc.com> Date: Wed, 5 Jul 2023 14:03:47 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH V7 1/2] dt-bindings: firmware: bootstats: Add the dtschema To: Krzysztof Kozlowski , Andy Gross , Konrad Dybcio , "Krzysztof Kozlowski" , Bjorn Andersson , Rob Herring , Arnd Bergmann CC: , , , , Sibi Sankar , Rajendra Nayak References: Content-Language: en-US From: Souradeep Chowdhury In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: y2gyi1B5kMqnpwkpR9XBzlmm-VP4UgI7 X-Proofpoint-ORIG-GUID: y2gyi1B5kMqnpwkpR9XBzlmm-VP4UgI7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-04_16,2023-07-04_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 priorityscore=1501 bulkscore=0 mlxscore=0 suspectscore=0 phishscore=0 adultscore=0 impostorscore=0 mlxlogscore=927 lowpriorityscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307050077 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230705_013429_207958_84DDF2D4 X-CRM114-Status: GOOD ( 25.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/5/2023 11:47 AM, Krzysztof Kozlowski wrote: > On 05/07/2023 07:32, Souradeep Chowdhury wrote: >> Add the device tree bindings for boot stats. This has 2 properties >> pre-abl-time and abl-time which records the timestamps for boot >> stats. >> >> Signed-off-by: Souradeep Chowdhury >> Link: https://lore.kernel.org/linux-arm-kernel/7d397e67-5d56-4975-98af-1ac9746c07f4@app.fastmail.com/ >> --- >> .../bindings/firmware/qcom,bootstats.yaml | 38 +++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/firmware/qcom,bootstats.yaml >> >> diff --git a/Documentation/devicetree/bindings/firmware/qcom,bootstats.yaml b/Documentation/devicetree/bindings/firmware/qcom,bootstats.yaml >> new file mode 100644 >> index 000000000000..22e697524058 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/firmware/qcom,bootstats.yaml >> @@ -0,0 +1,38 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/firmware/qcom,bootstats.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Boot Stats > > This explains nothing... Ack > >> + >> +maintainers: >> + - Souradeep Chowdhury >> + >> +description: | > > Drop | Ack > >> + Qualcomm's proprietary Android boot-loaders capture boot time > > Wrong indentation. Ack > >> + stats, like the time when the bootloader started execution and >> + at what point the bootloader handed over control to the kernel. >> + This is captured in the unit of ms in devicetree property. >> + >> +properties: >> + pre-abl-time: >> + description: The property to store the starting point of abl in ms. > > String instead of ms? No, this is the craziest idea I saw recently. Use > -ms suffix. > >> + $ref: /schemas/types.yaml#/definitions/string-array >> + >> + abl-time: >> + description: The property to store the duration of abl in ms. >> + $ref: /schemas/types.yaml#/definitions/string-array > > I have no clue what this entire binding is about. Nothing can bind to > it, no usage explained. Properties are not used to "store the duration". > This does not look like suitable for DT, drop entire binding. This binding was created as per the suggestion on version 6 of the patch by Arnd. The idea was that these 2 devicetree properties will be used to populate the bootstat values from the bootloader and exposed to the user via /sys/firmware/devicetree/ directly. Details in the link below:- https://lore.kernel.org/lkml/7d397e67-5d56-4975-98af-1ac9746c07f4@app.fastmail.com/T/#mbdc9ad95fcbb5ad7b56c6996a3933899b42d982c Can you suggest any alternative way to represent this as a binding? > >> + >> +required: >> + - pre-abl-time >> + - abl-time >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + bootstats { >> + pre-abl-time="17627"; >> + abl-time="26748"; > > Missing spaces. Open existing DTS and look at existing coding style. Ack > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel