linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: defconfig: Increase CMA size for VC4
@ 2018-05-02 21:31 Stefan Wahren
  2018-05-03 21:20 ` Eric Anholt
  2018-05-13 16:58 ` Florian Fainelli
  0 siblings, 2 replies; 6+ messages in thread
From: Stefan Wahren @ 2018-05-02 21:31 UTC (permalink / raw)
  To: linux-arm-kernel

The VC4 needs more memory than the default setting (16 MB):

  vc4-drm soc:gpu: swiotlb: coherent allocation failed, size=16777216
  [drm:vc4_bo_create [vc4]] *ERROR* Failed to allocate from CMA:
  vc4_v3d 3fc00000.v3d: Failed to allocate memory for tile binning: -12.
    You may need to enable CMA or give it more memory.
  vc4-drm soc:gpu: failed to bind 3fc00000.v3d (ops vc4_v3d_ops [vc4]): -12
  vc4-drm soc:gpu: master bind failed: -12
  vc4-drm: probe of soc:gpu failed with error -12

So increase the value to 32 MB and fix this issue.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---

Hi,
i known it's a little bit late for 4.18 or should i rebase for 4.17?

Regards

 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 7ca583e..0e1f6d7 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -172,6 +172,7 @@ CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
 CONFIG_DEVTMPFS=y
 CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_DMA_CMA=y
+CONFIG_CMA_SIZE_MBYTES=32
 CONFIG_MTD=y
 CONFIG_MTD_BLOCK=y
 CONFIG_MTD_M25P80=y
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] arm64: defconfig: Increase CMA size for VC4
  2018-05-02 21:31 [PATCH] arm64: defconfig: Increase CMA size for VC4 Stefan Wahren
@ 2018-05-03 21:20 ` Eric Anholt
  2018-05-12  9:10   ` Stefan Wahren
  2018-05-13 16:58 ` Florian Fainelli
  1 sibling, 1 reply; 6+ messages in thread
From: Eric Anholt @ 2018-05-03 21:20 UTC (permalink / raw)
  To: linux-arm-kernel

Stefan Wahren <stefan.wahren@i2se.com> writes:

> The VC4 needs more memory than the default setting (16 MB):
>
>   vc4-drm soc:gpu: swiotlb: coherent allocation failed, size=16777216
>   [drm:vc4_bo_create [vc4]] *ERROR* Failed to allocate from CMA:
>   vc4_v3d 3fc00000.v3d: Failed to allocate memory for tile binning: -12.
>     You may need to enable CMA or give it more memory.
>   vc4-drm soc:gpu: failed to bind 3fc00000.v3d (ops vc4_v3d_ops [vc4]): -12
>   vc4-drm soc:gpu: master bind failed: -12
>   vc4-drm: probe of soc:gpu failed with error -12
>
> So increase the value to 32 MB and fix this issue.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>

If there was a way to check how big the CMA pool is, then we could
probably have V3D disable itself when the pool was too small.  It's not
like V3D rendering is going to actually *work* with just a 32mb pool to
play in.

That said, I'd also be fine with this patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180503/04dd6dce/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] arm64: defconfig: Increase CMA size for VC4
  2018-05-03 21:20 ` Eric Anholt
@ 2018-05-12  9:10   ` Stefan Wahren
  2018-05-12 17:36     ` Florian Fainelli
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Wahren @ 2018-05-12  9:10 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Florian,

> Eric Anholt <eric@anholt.net> hat am 3. Mai 2018 um 23:20 geschrieben:
> 
> 
> Stefan Wahren <stefan.wahren@i2se.com> writes:
> 
> > The VC4 needs more memory than the default setting (16 MB):
> >
> >   vc4-drm soc:gpu: swiotlb: coherent allocation failed, size=16777216
> >   [drm:vc4_bo_create [vc4]] *ERROR* Failed to allocate from CMA:
> >   vc4_v3d 3fc00000.v3d: Failed to allocate memory for tile binning: -12.
> >     You may need to enable CMA or give it more memory.
> >   vc4-drm soc:gpu: failed to bind 3fc00000.v3d (ops vc4_v3d_ops [vc4]): -12
> >   vc4-drm soc:gpu: master bind failed: -12
> >   vc4-drm: probe of soc:gpu failed with error -12
> >
> > So increase the value to 32 MB and fix this issue.
> >
> > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> 
> If there was a way to check how big the CMA pool is, then we could
> probably have V3D disable itself when the pool was too small.  It's not
> like V3D rendering is going to actually *work* with just a 32mb pool to
> play in.
> 
> That said, I'd also be fine with this patch.

should i rebase my patch?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] arm64: defconfig: Increase CMA size for VC4
  2018-05-12  9:10   ` Stefan Wahren
@ 2018-05-12 17:36     ` Florian Fainelli
  0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2018-05-12 17:36 UTC (permalink / raw)
  To: linux-arm-kernel

On May 12, 2018 2:10:26 AM PDT, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>Hi Florian,
>
>> Eric Anholt <eric@anholt.net> hat am 3. Mai 2018 um 23:20
>geschrieben:
>> 
>> 
>> Stefan Wahren <stefan.wahren@i2se.com> writes:
>> 
>> > The VC4 needs more memory than the default setting (16 MB):
>> >
>> >   vc4-drm soc:gpu: swiotlb: coherent allocation failed,
>size=16777216
>> >   [drm:vc4_bo_create [vc4]] *ERROR* Failed to allocate from CMA:
>> >   vc4_v3d 3fc00000.v3d: Failed to allocate memory for tile binning:
>-12.
>> >     You may need to enable CMA or give it more memory.
>> >   vc4-drm soc:gpu: failed to bind 3fc00000.v3d (ops vc4_v3d_ops
>[vc4]): -12
>> >   vc4-drm soc:gpu: master bind failed: -12
>> >   vc4-drm: probe of soc:gpu failed with error -12
>> >
>> > So increase the value to 32 MB and fix this issue.
>> >
>> > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>> 
>> If there was a way to check how big the CMA pool is, then we could
>> probably have V3D disable itself when the pool was too small.  It's
>not
>> like V3D rendering is going to actually *work* with just a 32mb pool
>to
>> play in.
>> 
>> That said, I'd also be fine with this patch.
>
>should i rebase my patch?

I was expecting Eric to pick it up, but I can do this as well sorry about the miscommunication here. Let me queue this up and update the defconfig-arm64 pull request with this commit.

-- 
Florian

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] arm64: defconfig: Increase CMA size for VC4
  2018-05-02 21:31 [PATCH] arm64: defconfig: Increase CMA size for VC4 Stefan Wahren
  2018-05-03 21:20 ` Eric Anholt
@ 2018-05-13 16:58 ` Florian Fainelli
  2018-05-13 19:10   ` Stefan Wahren
  1 sibling, 1 reply; 6+ messages in thread
From: Florian Fainelli @ 2018-05-13 16:58 UTC (permalink / raw)
  To: linux-arm-kernel

Le 05/02/18 ? 14:31, Stefan Wahren a ?crit?:
> The VC4 needs more memory than the default setting (16 MB):
> 
>   vc4-drm soc:gpu: swiotlb: coherent allocation failed, size=16777216
>   [drm:vc4_bo_create [vc4]] *ERROR* Failed to allocate from CMA:
>   vc4_v3d 3fc00000.v3d: Failed to allocate memory for tile binning: -12.
>     You may need to enable CMA or give it more memory.
>   vc4-drm soc:gpu: failed to bind 3fc00000.v3d (ops vc4_v3d_ops [vc4]): -12
>   vc4-drm soc:gpu: master bind failed: -12
>   vc4-drm: probe of soc:gpu failed with error -12
> 
> So increase the value to 32 MB and fix this issue.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>

Applied to defconfig-arm64/next, thanks!
-- 
Florian

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] arm64: defconfig: Increase CMA size for VC4
  2018-05-13 16:58 ` Florian Fainelli
@ 2018-05-13 19:10   ` Stefan Wahren
  0 siblings, 0 replies; 6+ messages in thread
From: Stefan Wahren @ 2018-05-13 19:10 UTC (permalink / raw)
  To: linux-arm-kernel


> Florian Fainelli <f.fainelli@gmail.com> hat am 13. Mai 2018 um 18:58 geschrieben:
> 
> 
> Le 05/02/18 ? 14:31, Stefan Wahren a ?crit?:
> > The VC4 needs more memory than the default setting (16 MB):
> > 
> >   vc4-drm soc:gpu: swiotlb: coherent allocation failed, size=16777216
> >   [drm:vc4_bo_create [vc4]] *ERROR* Failed to allocate from CMA:
> >   vc4_v3d 3fc00000.v3d: Failed to allocate memory for tile binning: -12.
> >     You may need to enable CMA or give it more memory.
> >   vc4-drm soc:gpu: failed to bind 3fc00000.v3d (ops vc4_v3d_ops [vc4]): -12
> >   vc4-drm soc:gpu: master bind failed: -12
> >   vc4-drm: probe of soc:gpu failed with error -12
> > 
> > So increase the value to 32 MB and fix this issue.
> > 
> > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> 
> Applied to defconfig-arm64/next, thanks!
> -- 
> Florian

Thank you, i will add a note next time.

Stefan

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-05-13 19:10 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-02 21:31 [PATCH] arm64: defconfig: Increase CMA size for VC4 Stefan Wahren
2018-05-03 21:20 ` Eric Anholt
2018-05-12  9:10   ` Stefan Wahren
2018-05-12 17:36     ` Florian Fainelli
2018-05-13 16:58 ` Florian Fainelli
2018-05-13 19:10   ` Stefan Wahren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).