From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75CF7C98321 for ; Thu, 24 Sep 2026 18:42:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+SaSL5++eI0Om2LO+PuwxL36MtIMLJZWtP+lw/rJZ1g=; b=cOlRsmw5aDulymZem5dbFceYoj ntaIETu9MjQcmirZP3lE3j79nwzm7F9ZGR7HNFIKffsWkvRvYMyV48VIxZ2kh/YW1lLHJGE7IoNht Yq9fActAwnQ+/ELSLOPmtVWo6uRRrtRcCy3kQOQR0lihc8YIRYR6uGKKyNh9MtZzdlUy5cjYJOsMs BzvahHxX3e0e+AanekVd8JDMz0K3WaN0hY2JqlQZOBD2cHLQ8tJA4zDok0ERHx3qXi9amGsnUjELN AgBISX9JhfYAUaHRIgCJnRSVFfGHNEAg3vKaMB7mcA3EyMKiz59s92Fqn3BSYMb7v3lP2jStSfYXe RlJi0zsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9oOf-0000000Bwgf-3h1C; Thu, 24 Sep 2026 18:42:17 +0000 Received: from pidgin.makrotopia.org ([2a07:2ec0:3002::65]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9oOd-0000000Bwef-1DVU; Thu, 24 Sep 2026 18:42:16 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256:X25519MLKEM768) (Exim 4.100) (envelope-from ) id 1x9oOW-000000007QN-33Tw; Thu, 24 Sep 2026 18:42:08 +0000 Date: Thu, 24 Sep 2026 19:42:05 +0100 From: Daniel Golle To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno , Allen Chen , Hermes Wu , Pin-yen Lin , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v7 11/14] drm/bridge: it6505: reject a too short link-frequencies property Message-ID: <96a53555019f573ddc95ab15434a7ca09e19a12b.1790275151.git.daniel@makrotopia.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260924_114215_370003_B14E3FDA X-CRM114-Status: GOOD ( 12.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_property_read_variable_u64_array() is asked for a minimum array size of zero, so a link-frequencies property shorter than one u64 -- a 32-bit value written by mistake, say -- returns 0 without storing anything. it6505_parse_dt() reads that as success and derives max_dpi_pixel_clock from an uninitialised stack variable. Ask for one element so a short property lands in the existing error path. Fixes: 380d920b582d ("drm/bridge: add it6505 driver to read data-lanes and link-frequencies from dt") Signed-off-by: Daniel Golle --- v7: no changes v6: new patch --- drivers/gpu/drm/bridge/ite-it6505.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c index dbef1a1bc5e3..d6ba28d1c963 100644 --- a/drivers/gpu/drm/bridge/ite-it6505.c +++ b/drivers/gpu/drm/bridge/ite-it6505.c @@ -3392,7 +3392,7 @@ static void it6505_parse_dt(struct it6505 *it6505) if (ep) { len = of_property_read_variable_u64_array(ep, "link-frequencies", - &link_frequencies, 0, + &link_frequencies, 1, 1); if (len >= 0) { do_div(link_frequencies, 1000); -- 2.55.0