Re: [PATCH v7 02/10] drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices

Jagan Teki
2022-10-17T02:53:23Z

On Sun, Oct 16, 2022 at 3:18 AM Marek Vasut <marex@denx.de> wrote:
>
> On 10/5/22 17:13, Jagan Teki wrote:
> > The child devices in MIPI DSI can be binding with OF-graph
> > and also via child nodes.
> >
> > The OF-graph interface represents the child devices via
> > remote and associated endpoint numbers like
> >
> > dsi {
> > compatible = "fsl,imx8mm-mipi-dsim";
> >
> > ports {
> > port@0 {
> > reg = <0>;
> >
> > dsi_in_lcdif: endpoint@0 {
> > reg = <0>;
> > remote-endpoint = <&lcdif_out_dsi>;
> > };
> > };
> >
> > port@1 {
> > reg = <1>;
> >
> > dsi_out_bridge: endpoint {
> > remote-endpoint = <&bridge_in_dsi>;
> > };
> > };
> > };
> >
> > The child node interface represents the child devices via
> > conventional child nodes on given DSI parent like
> >
> > dsi {
> > compatible = "samsung,exynos5433-mipi-dsi";
> >
> > ports {
> > port@0 {
> > reg = <0>;
> >
> > dsi_to_mic: endpoint {
> > remote-endpoint = <&mic_to_dsi>;
> > };
> > };
> > };
> >
> > panel@0 {
> > reg = <0>;
> > };
> > };
> >
> > As Samsung DSIM bridge is common DSI IP across all Exynos DSI
> > and NXP i.MX8M host controllers, this patch adds support to
> > lookup the child devices whether its bindings on the associated
> > host represent OF-graph or child node interfaces.
>
> This looks like a good candidate for common/helper code which can be
> reused by other similar drivers.

Tried that but unfortunately, it cannot hold to handle things in a generic way.
80253168dbfd ("drm: of: Lookup if child node has panel or bridge")

Jagan.