Re: [PATCH v7 00/10] drm: bridge: Add Samsung MIPI DSIM bridge

Jagan Teki
2022-10-06T14:22:47Z

Hi Marek,

On Thu, Oct 6, 2022 at 2:21 AM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
>
> Hi Jagan,
>
> On 05.10.2022 17:12, Jagan Teki wrote:
> > This series supports common bridge support for Samsung MIPI DSIM
> > which is used in Exynos and i.MX8MM SoC's.
> >
> > The final bridge supports both the Exynos and i.MX8MM DSI devices.
> >
> > Changes for v7:
> > * fix the drm bridge attach chain for exynos drm dsi driver
> > * fix the hw_type checking logic
> >
> > Changes for v6:
> > * handle previous bridge for exynos dsi while attaching bridge
> >
> > Changes for v5:
> > * bridge changes to support multi-arch
> > * updated and clear commit messages
> > * add hw_type via plat data
> > * removed unneeded quirk
> > * rebased on linux-next
> >
> > Changes for v4:
> > * include Inki Dae in MAINTAINERS
> > * remove dsi_driver probe in exynos_drm_drv to support multi-arch build
> > * update init handling to ensure host init done on first cmd transfer
> >
> > Changes for v3:
> > * fix the mult-arch build
> > * fix dsi host init
> > * updated commit messages
> >
> > Changes for v2:
> > * fix bridge handling
> > * fix dsi host init
> > * correct the commit messages
> >
> > Patch 0001: Samsung DSIM bridge
> >
> > Patch 0002: PHY optional
> >
> > Patch 0003: OF-graph or Child node lookup
> >
> > Patch 0004: DSI host initialization
> >
> > Patch 0005: atomic check
> >
> > Patch 0006: PMS_P offset via plat data
> >
> > Patch 0007: atomic_get_input_bus_fmts
> >
> > Patch 0008: input_bus_flags
> >
> > Patch 0009: document fsl,imx8mm-mipi-dsim
> >
> > Patch 0010: add i.MX8MM DSIM support
> >
> > Tested in Engicam i.Core MX8M Mini SoM.
>
> This finally doesn't break Exynos DSI. :) Feel free to add:
>
> Acked-by: Marek Szyprowski
>
> Tested-by: Marek Szyprowski
>
> The next step would be to merge Dave's patchset and remove the hacks
> added here and there. Otherwise we will end up adding even more hacks soon.

I've some concerns about one of those patches, I will try to comment
on that patch in mailing list or will send updated changes on top of
those.

Thanks,
Jagan.