From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B57BAC43381 for ; Tue, 5 Mar 2019 02:15:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EDEC206B8 for ; Tue, 5 Mar 2019 02:15:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JHFn/tSR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="LmJAOqSm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EDEC206B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DiIJOF3FL62ooZ4VMwHMOhnVOoo0DQeXVWD69kkzfzk=; b=JHFn/tSRHFloFg c/2aJNI7WMoYqa44/kdVrcTJDKOsaQpzIZzIBkhIZeE5IxUqipKQOHJgkY9czzjcbnMAXTlWTvnid X0nXUkviOBHnbeR70osx6sh5tB9B+pQeOYQ2x4cOo6c2GlVmpozu3RlWKeyZp+xUJcjERP8Di3WSS L+ayeCRRvHtAKjb/hfpF9qZw+EjHTw7V/2P9vv6/m6M+7EHGIMvhKU8hLQYjV/WV36VxtcrejxshL WYSF468Emj7HGDejD7mx1qyhfKqoOEIbnW7mT8O1gGR6EFXi5Bh/nPaXKj5deYFhO8rMVpxZBQeQw R0QDEXwXMW6uXDoS9dug==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0zbd-0000QN-TX; Tue, 05 Mar 2019 02:14:57 +0000 Received: from mail-eopbgr130050.outbound.protection.outlook.com ([40.107.13.50] helo=EUR01-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0zbZ-0000PX-KU for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2019 02:14:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pYcxCBdsHjG1vMeGCzuGTn2kYlKozvKDHqJn8Sst4Jo=; b=LmJAOqSm1N2eWAMrGHZsUt1XcB3eb0v46grqAxg3AA/Y0DpZrosGE8B9Q4SuLb0ySvCG3FXE4564tz0HKDfYGQ9U4foi34WD+mnpKIONkMqJQj2Pg5DWKlVcUF/ARfJ+waXMT5Z2QuY/8Fhfrd8eeKnxAYmMSVmRP6EUu2qWkos= Received: from AM4PR08MB2929.eurprd08.prod.outlook.com (10.171.190.138) by AM4PR08MB1233.eurprd08.prod.outlook.com (10.167.92.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.18; Tue, 5 Mar 2019 02:14:47 +0000 Received: from AM4PR08MB2929.eurprd08.prod.outlook.com ([fe80::e522:c03f:3d0c:f4ce]) by AM4PR08MB2929.eurprd08.prod.outlook.com ([fe80::e522:c03f:3d0c:f4ce%4]) with mapi id 15.20.1665.020; Tue, 5 Mar 2019 02:14:47 +0000 From: "Haibo Xu (Arm Technology China)" To: Sudeep Holla Subject: Re: [PATCH 3/6] x86: clean up _TIF_SYSCALL_EMU handling using ptrace_syscall_enter hook Thread-Topic: [PATCH 3/6] x86: clean up _TIF_SYSCALL_EMU handling using ptrace_syscall_enter hook Thread-Index: AQHUz5P9ZKULSdDQbEW1h9vbYNE6xaX7KHCAgAAd14CAAQzrgA== Date: Tue, 5 Mar 2019 02:14:47 +0000 Message-ID: <96d59a68-e5e2-86d9-c707-a79aad438b76@arm.com> References: <20190228183220.15626-1-sudeep.holla@arm.com> <20190228183220.15626-4-sudeep.holla@arm.com> <20190304101205.GA1504@e107155-lin> In-Reply-To: <20190304101205.GA1504@e107155-lin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK0PR01CA0007.apcprd01.prod.exchangelabs.com (2603:1096:203:92::19) To AM4PR08MB2929.eurprd08.prod.outlook.com (2603:10a6:205:c::10) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Haibo.Xu@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b9eb89f9-86d9-476c-520b-08d6a1105712 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM4PR08MB1233; x-ms-traffictypediagnostic: AM4PR08MB1233: x-microsoft-exchange-diagnostics: 1; AM4PR08MB1233; 20:MJditFq3MlIdGxq7d4s3xdvbXB4p0S+K3ivSkGcFUM0NvKi1NkaY/q6A9AH/UmsPFUAoR/tsicars5a2XG5FZHF1bSLrNx4/z/MmGgC7DmPgoKsOZXwqIQE5WCdLEGS7pL1eZgkuXxIxDpojuK1/iG7Be4jpntJXoX3fiW5se3E= x-microsoft-antispam-prvs: x-forefront-prvs: 0967749BC1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(39860400002)(376002)(366004)(346002)(189003)(199004)(40434004)(76176011)(97736004)(7736002)(6862004)(229853002)(102836004)(55236004)(6486002)(186003)(52116002)(305945005)(66066001)(72206003)(71190400001)(6512007)(53546011)(6246003)(26005)(386003)(6506007)(8676002)(71200400001)(4326008)(6436002)(53936002)(81166006)(93886005)(81156014)(5660300002)(36756003)(446003)(6636002)(8936002)(478600001)(14454004)(7416002)(2906002)(105586002)(31686004)(5024004)(14444005)(31696002)(6116002)(256004)(54906003)(486006)(316002)(86362001)(106356001)(476003)(25786009)(11346002)(3846002)(99286004)(37006003)(2616005)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR08MB1233; H:AM4PR08MB2929.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: lpq3QGKD/d+Nl3LL4LEP3XUuw5I2c8ApRLpvttCWev8x9vKjFOKZ4ENxt0YJveNpobls07/K/6ZaQF6QOG+x3Mh3I7veUjmv8S/iMI4th6+1jhkv4J9gVsfeob+ucAql+X+hXBrjWMoI2xcxGAkT3pfTE7BVkk0W1yCTVXv/uMCnUEJrIylM/fFT4NnKPTeslBA7wjFyav0OyQ7l2OpTWw8gGx1O7EsOeedaQZwzoyuQGU2MxqfykF+LmysotqsVxYdD5tDCwF77eSHgVviNhmSRjRL/yyB0YfDkR3JzDG0P6XFZDSTR2lnYBmYcCJg+jtStBVoTuVkr34o4vBtzkP6Q1uxejb31jj3/YyX49zCtWBi/8531e4UY8low7u7FW2fnLeo8kITCF91nM63aImZRiSiP99om+upWL/L+94I= Content-ID: <12D581F16842104093AC565798259132@eurprd08.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9eb89f9-86d9-476c-520b-08d6a1105712 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2019 02:14:47.4652 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB1233 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_181454_012173_12B7159F X-CRM114-Status: GOOD ( 17.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Steve Capper , Catalin Marinas , "jdike@addtoit.com" , "x86@kernel.org" , Will Deacon , "linux-kernel@vger.kernel.org" , Oleg Nesterov , Richard Weinberger , Ingo Molnar , Paul Mackerras , Andy Lutomirski , Michael Ellerman , Borislav Petkov , Thomas Gleixner , "Bin Lu \(Arm Technology China\)" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2019/3/4 18:12, Sudeep Holla wrote: > On Mon, Mar 04, 2019 at 08:25:28AM +0000, Haibo Xu (Arm Technology China) wrote: >> On 2019/3/1 2:32, Sudeep Holla wrote: >>> Now that we have a new hook ptrace_syscall_enter that can be called from >>> syscall entry code and it handles PTRACE_SYSEMU in generic code, we >>> can do some cleanup using the same in syscall_trace_enter. >>> >>> Further the extra logic to find single stepping PTRACE_SYSEMU_SINGLESTEP >>> in syscall_slow_exit_work seems unnecessary. Let's remove the same. >> >> I think we should not change the logic here. Is so, it will double the report of syscall >> when PTRACE_SYSEMU_SINGLESTEP is enabled. >> > > I don't think that should happen, but I may be missing something. > Can you explain how ? > > -- > Regards, > Sudeep > When PTRACE_SYSEMU_SINGLESTEP is enabled, both the _TIF_SYSCALL_EMU and _TIF_SINGLESTEP flags are set, but ptrace only need to report(send SIGTRAP) at the entry of a system call, no need to report at the exit of a system call. Regards, Haibo IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel