From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 642FBC47DB7 for ; Fri, 19 Jan 2024 09:55:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tMckimxNNOXo4rlEldXvVJV+U9xPPtgsXIonDuT3+rw=; b=CBVZig3EI+Hnnc 6zKR93X/uaN9ovTPCDTDYj/ZYpBA2AdmKif20UQ1pIx7aEwGb3gxnAL4IX5Y/WI7Ei449hWU+l8Xz A52nIEch0bv1Kl9jYaygM+8ozVKAMcWlkaauUvY0rX3D/sbonya5D2Pw/SkwHcdoXpDxGnNgsw5yF c2GD9oqbgpRFE3jpM03dc7bLu2LhUjEe6F3BNbYy9PIaOw1nhkZ6CGyOs7cTQizA/hFyfZBeQ950S 2J2wwNBexjMRCt8y3hT2oreA3JB7uT5QIX3nwKSUyB3DK9ZMp9bPNrcrl8rMCNAAD0HhdCpv39ttV gripFAyxciohPh53aj/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQla6-0051Hu-2y; Fri, 19 Jan 2024 09:54:34 +0000 Received: from mail-wr1-f46.google.com ([209.85.221.46]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rQla2-0051HH-2j for linux-arm-kernel@lists.infradead.org; Fri, 19 Jan 2024 09:54:33 +0000 Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-337c5eb1bddso486502f8f.3 for ; Fri, 19 Jan 2024 01:54:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705658068; x=1706262868; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KhS55GkeN1MML94r02ZTRN7Q0q493tFZV5aLoz32KaU=; b=f/EtB5u1eG1fzbaZ2OGPLviKD5UTHSmTZVIFNTXPpdOIc4uRfwhHfFb0RQoa+lvzuD oLIoiTTTR+Y9VYP/bEhbVskCrx9OhDyvjy9YQszEhjfyF7QENT+RNd51b3Dm2X3hLcDy kwLortCBviA3EJl/KlhCD7T/IhCiwffn1ueEYCCdMPiGxstUI5Gf5hG2rrr3PEtMch0A y2z4R7uA/u7uCJCsWNAKlwDUXMXUA+rAVb/J8pJVcWMoSuXPNYnW5ughRu3opvZMF02P 4+gQnk18RNVfcT6AtJdhHGBMThz5lmhx2AAaV+Em2Vey18J9WIuITm8kinbLDCjzHlFe WpjQ== X-Gm-Message-State: AOJu0YyNZPxU+oFVvmCclAm6fefEWj2jmkhtdJu8fU4YcQARu1qmvqc9 fIcF/8QTuECgWjcfNLzlHUnvmE5VynsErx+D3XTT3R6sZLweVIMQ X-Google-Smtp-Source: AGHT+IF/HDQIEWtDT6IvTDCHqb2oiXrFws6SF+Qqn3/6yTi0XH8IS1zXK7pSewpaGHn7XnNPAJEhSw== X-Received: by 2002:a05:600c:b47:b0:40e:95a7:cd3e with SMTP id k7-20020a05600c0b4700b0040e95a7cd3emr1050752wmr.79.1705658067711; Fri, 19 Jan 2024 01:54:27 -0800 (PST) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id o9-20020adfe809000000b00337bf81e06bsm6053961wrm.48.2024.01.19.01.54.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jan 2024 01:54:27 -0800 (PST) Message-ID: <96e3d7e9-737b-484e-bc94-e95533f06ca7@kernel.org> Date: Fri, 19 Jan 2024 10:54:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 17/18] tty: serial: samsung: shrink port feature flags to u8 Content-Language: en-US To: Tudor Ambarus , Sam Protsenko Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com References: <20240110102102.61587-1-tudor.ambarus@linaro.org> <20240110102102.61587-18-tudor.ambarus@linaro.org> <76e1dc42-cabe-4925-8aa1-c8f733fb36a2@linaro.org> <8f3f85d0-866e-4e5a-8177-05c26c08b278@kernel.org> <842d36c7-9452-431f-95c4-ff114484d201@linaro.org> From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <842d36c7-9452-431f-95c4-ff114484d201@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240119_015431_838052_08B5D049 X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 19. 01. 24, 10:43, Tudor Ambarus wrote: >>> If using unsigned int the bitfied is combined with the previous u8 >>> fields, whereas if using u8 the bitfield will be independently defined. >>> So no benefit in terms of memory footprint, it's just a cosmetic change >>> to align the bitfield with the previous u8 fields. Allowing u32 for just >>> a bit can be misleading as one would ask itself where are the other >>> bits. Between a u32 bitfield and a bool a u8 bitfield seems like a good >>> compromise. >> >> Why? What's wrong with bool? bitfields have terrible semantics wrt >> atomic writes for example. >> > > Bool occupies a byte and if more port features will ever be added we'll > occupy more bytes. Here's how the structure will look like with a bool: > > struct s3c24xx_uart_info { > const char * name; /* 0 8 */ > enum s3c24xx_port_type type; /* 8 4 */ > unsigned int port_type; /* 12 4 */ > unsigned int fifosize; /* 16 4 */ > u32 rx_fifomask; /* 20 4 */ > u32 rx_fifoshift; /* 24 4 */ > u32 rx_fifofull; /* 28 4 */ > u32 tx_fifomask; /* 32 4 */ > u32 tx_fifoshift; /* 36 4 */ > u32 tx_fifofull; /* 40 4 */ > u32 clksel_mask; /* 44 4 */ > u32 clksel_shift; /* 48 4 */ > u32 ucon_mask; /* 52 4 */ > u8 def_clk_sel; /* 56 1 */ > u8 num_clks; /* 57 1 */ > u8 iotype; /* 58 1 */ > bool has_divslot; /* 59 1 */ > > /* size: 64, cachelines: 1, members: 17 */ > /* padding: 4 */ > }; > > What's your preference? bool :). -- js suse labs _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel