From: Florian Fainelli <f.fainelli@gmail.com>
To: Alex Dewar <alex.dewar90@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
Rob Herring <robh@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
Bjorn Helgaas <bhelgaas@google.com>,
Jim Quinlan <jquinlan@broadcom.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: Re: [PATCH v2] PCI: brcmstb: Add missing if statement and error path
Date: Mon, 21 Sep 2020 14:21:42 -0700 [thread overview]
Message-ID: <97332b07-6496-ff46-9f05-fda12220264b@gmail.com> (raw)
In-Reply-To: <20200921211623.33908-1-alex.dewar90@gmail.com>
On 9/21/20 2:16 PM, Alex Dewar wrote:
> brcm_pcie_resume() contains a return statement that was presumably
> intended to have an "if (ret)" in front of it, otherwise the function
> returns prematurely. Fix this.
>
> Additionally, redisable the clock on the error path.
>
> I don't know if this code was tested or not, but I assume that this bug
> means that this driver will not resume properly.
>
> Fixes: ad3d29c77e1e ("PCI: brcmstb: Add control of rescal reset")
> Addresses-Coverity: CID 1497099: Control flow issues (UNREACHABLE)
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
> ---
You need to coordinate with Colin, or with whomever is looking at
Coverity defects, because he just submitted a similar patch minutes ago:
https://lore.kernel.org/linux-arm-kernel/20200921211555.383458-1-colin.king@canonical.com/
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-21 21:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 20:45 [PATCH] PCI: brcmstb: Add missing if statement Alex Dewar
2020-09-21 20:56 ` Jim Quinlan
2020-09-21 21:16 ` [PATCH v2] PCI: brcmstb: Add missing if statement and error path Alex Dewar
2020-09-21 21:21 ` Florian Fainelli [this message]
2020-09-23 8:20 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97332b07-6496-ff46-9f05-fda12220264b@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alex.dewar90@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=jquinlan@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nsaenzjulienne@suse.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox