From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5675CCFA13 for ; Thu, 6 Nov 2025 12:43:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xhs4+8dcbkMAZTBfzvawWLtLzaXRFwQ3evVG0RTFMz0=; b=kjUAqhJyjQwSya9iBwDrnY28jN tMBGu3yX16vbOma+YebDXm59FMdPimT7p0Y5/YKlYx2h9O9dn9bb7dKsZNOPjMEs93bn4YLEwKQa7 dQYAkeAE5JXECtSMBW9IFhuoRc2fypsCswr1IMYY9HCuqE3vYTWIKb98K47feEf/hJLEe/0lvXG2e 4UbkXjpt8is1scnjEQvLNKzqC5kK4G8Mj8ln8HExTPBC/wNR6ToPQs5eBXA344xKPu6PkD/J0cYQg ponuqlVjBns7bXTJli9J1a2dtN5QsI9S3ZQgHmJC/hRfe4jF1C3+nOVv9RfCGu8VLbfS9xNoF4Thb +HXcPabw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vGzL3-0000000FTPq-2UVv; Thu, 06 Nov 2025 12:43:41 +0000 Received: from mail-eastusazon11011022.outbound.protection.outlook.com ([52.101.52.22] helo=BL2PR02CU003.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vGzL1-0000000FTPT-1Ogd for linux-arm-kernel@lists.infradead.org; Thu, 06 Nov 2025 12:43:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JYd823quS56tcIJVJB/qVz2NO752/wWJYJ9HX8GMpT1mCiRut9LPnwFSsxGhA93PWWUzB2S6Sao+ACLeUSGv97ZIEjUhrY2zQy1KBKlAtxVBivDJWEoT5nchVQC8hUe8HhvEUnK/TKCDaIkLwoyuo7aWvocbZEeeCCDCpVSmSJLlVxavqW6fd8a1g0Ysy1kz47cWX667JDZ8iBG9ywowSK45XC07S9waqMNGp/K//fFGq7SftSo5XoKFrV6JNUehcaI66UhP8eOwY+bb0wEGFflcZm8c0WvWUR/uV4xlIlH3GZ0rNnxcEVFTCfzp0ShBF9jCKNmVxOHGzcm3HsbV7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xhs4+8dcbkMAZTBfzvawWLtLzaXRFwQ3evVG0RTFMz0=; b=QqX4TgJMnBq/APyvySsMH+xpNaTdF0ErQX04ADrvmarZ9A4mcnTmiVmNRN6RGhDsT+BSVPy9qrvCx1rJuIxbxW5LVzQia9vMCVnGzbN0Frg3w+JbxLuYFyiW/x0Ch4wEMp7v4VkRrt8C7c6GVTys/rUUBV3QhoIqzCXiGI36qJyvAeatCIcG5ryEnB24FW2rDUXBi3tE91MJ+mbNS+aKYEl1m7WCR6pVZgNGy1kxQ54ep8GOYlw6DiHbyRB3Q+SxgLJ4vdZSvLS8XRGbvaS0p0YDC45Vs5pB399FWKIDIpBqu+Jt8UO3Xl5Kh+IF+MLQp59GIkiX/OElE+B1syJi0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.ibm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xhs4+8dcbkMAZTBfzvawWLtLzaXRFwQ3evVG0RTFMz0=; b=egDMC77CxUlUHvYrbiIdYLawG3LjRA+wYdJ7kMYN/8DYyPekGfpAjH/akJSI258AIdNQ6jOPOhoao93DGZiQeq0Oa8oM528wsn54fPucEMDqgXsX27wDb+jMdaUDZTjQCQdR7K3GWznwoockBnB0A4BcNcIgqtNfMcxzf8kcUHw= Received: from BY3PR03CA0024.namprd03.prod.outlook.com (2603:10b6:a03:39a::29) by MN0PR12MB5786.namprd12.prod.outlook.com (2603:10b6:208:375::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.16; Thu, 6 Nov 2025 12:43:30 +0000 Received: from CO1PEPF000044FC.namprd21.prod.outlook.com (2603:10b6:a03:39a:cafe::dc) by BY3PR03CA0024.outlook.office365.com (2603:10b6:a03:39a::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9298.12 via Frontend Transport; Thu, 6 Nov 2025 12:43:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by CO1PEPF000044FC.mail.protection.outlook.com (10.167.241.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.0 via Frontend Transport; Thu, 6 Nov 2025 12:43:30 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 6 Nov 2025 04:43:29 -0800 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 6 Nov 2025 04:43:29 -0800 Received: from [172.31.39.154] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Thu, 6 Nov 2025 04:43:18 -0800 Message-ID: <977b68ad-6796-4c3d-9c34-d023597f8ab2@amd.com> Date: Thu, 6 Nov 2025 18:13:11 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 24/35] vdso/datastore: Allocate data pages dynamically To: Heiko Carstens , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= CC: Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , Arnd Bergmann , "David S. Miller" , Andreas Larsson , Nick Alcock , John Stultz , Stephen Boyd , "John Paul Adrian Glaubitz" , Shuah Khan , Catalin Marinas , Will Deacon , Theodore Ts'o , "Jason A. Donenfeld" , Russell King , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Huacai Chen" , WANG Xuerui , "Thomas Bogendoerfer" , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "Nagarathnam Muthusamy" , Shannon Nelson , , , , , , , , References: <20251014-vdso-sparc64-generic-2-v4-0-e0607bf49dea@linutronix.de> <20251014-vdso-sparc64-generic-2-v4-24-e0607bf49dea@linutronix.de> <20251105153426.16228C13-hca@linux.ibm.com> Content-Language: en-US From: "Aithal, Srikanth" In-Reply-To: <20251105153426.16228C13-hca@linux.ibm.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044FC:EE_|MN0PR12MB5786:EE_ X-MS-Office365-Filtering-Correlation-Id: d2eee96c-9b85-46e0-9f63-08de1d3216d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|7416014|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Z2s3YWdLZTI3SUZFRHhyZkdPUmlCSFlndkFaZ1YwQ3NmNlFFRmdMaEhvMDht?= =?utf-8?B?YTNrekZOeWk2anYxcWt6Umk5S1MwNlJjaU54ZDNxaCsxT1FVSkFmSlNSa2hJ?= =?utf-8?B?N0tRcVNRZndKWnpNcmtCUWZvbWkzTzhJUkFBN1ZSeTY5cWpWaUVxeW9rMFAy?= =?utf-8?B?aXlINHlRc0gzRjF1bEloNTR5SlNjd1BQMWt6VTZ5VlRLVmxIbHZMWHZoanVQ?= =?utf-8?B?S3FCaU52djljQlFMVTlYWTZTTFNZNDNCbzB4TEQ0alZrM1FjOFF6Y1d1WlJx?= =?utf-8?B?YlF6cCtHcmExRHdGNkxSL0p0SXhNUjR0VTYxUjJ6aGUwNzBCckMzcnNPVkFr?= =?utf-8?B?QUNSZWpSbUR3V240R2dEQThYdjkrV2ZYb0I2d1ZqT2wwSmFJRUw1VmplUGlM?= =?utf-8?B?TGNVVmY3bS9VTEo5MnNoM3kxci8vWkE1RmhJZm9JY0tqa2k0YU5GTUtvdVN4?= =?utf-8?B?UE96b0hTTmNRZTdISGc3OEhFdkZrSmdmM1pERkJqa0oyVHp1KzI4ckUwQUJp?= =?utf-8?B?Vy85U0pOcEF3RFVpcFFHQWo2U1U1aWRScWRMRWQ0VEI2ZGtLMmtVVWd5dG01?= =?utf-8?B?bEZRS1l6SUwyV09KbG5neDJYd290a1I3aER1am1aQ211SW9OVldmM0lNM3pq?= =?utf-8?B?ZnZQWVh3T3o2Y3FZRnhGQTZ2YU9hUnAzNCtkUlBiR3IwcXFKN3ZqTGdLdytL?= =?utf-8?B?ZHdDdFdkQ1dNcUlrVEdtY0l4bDdQK1ZaK0t4T1lWTG5kKzlSc0ZDRmoyb3RZ?= =?utf-8?B?bDBRTEF4OU5NSlBlV08rajkzbnRpUXpiRmxwakRobi9PL1JBbGJaVndxVnox?= =?utf-8?B?WHRDMVd4Q2cwek0rNzNwRjV6RW0rSTAxZEQ4emZwQmVYSTdPdzhELzJIdDhq?= =?utf-8?B?ZGVsdXQ3T0QzdWZDN3VSbHIrSmdyOENLSHR6azVncG9mOHN3NndSS3NCMHBT?= =?utf-8?B?VzMrSjVjb0ZFQ0tMbUZucEpnTzhHL1RUdGhZUFpMQ05SbnJDZ0I4NUZzdXR0?= =?utf-8?B?YlhQRWxQSkg0ZHgveVNPamkxSkE3Q0hJUVc0ejJpQ21tK3FMSGZzemFDS1Uz?= =?utf-8?B?L21haEROYXdnaWI1QTd4Rk1lQ1gvSEhEMENMWmpZV3d1NU9EYmVKU1VhVkFS?= =?utf-8?B?cERzWXVuQmdaVmFJNHZudUJEdERPU2FUK3BwUTlnbG0vTjFqT2hoejRXMUpE?= =?utf-8?B?cHpSOWk5RGUzR3hrYnZJZVpYekZ0YytFNWFGSktxYk9PM2ZsOUVRSnk1RXMr?= =?utf-8?B?MURKdm9kanhxbnVabHlzS3BHMEYzSC9XaDRqelJoOUp2TXhhOTBYNlNwYXEz?= =?utf-8?B?UVNxWkJLSjl5UU1nY0w1RjBVbTMrNkM0bHJheE9Hcnp2c045d2xkNHNGeE8v?= =?utf-8?B?RmVsT2VXeGQwTGd1bGpydWFDWDA2V0gwY2hFV1RzZ1kxL05rdzBhQXdJY29U?= =?utf-8?B?TTNzNHpUOWlQOU1yLzlKZEt4ZkVBclZHeEZvSUEvNjBab3FUbkMvMWRjeHFZ?= =?utf-8?B?cG52bW4ySGFrVHpPdDFIK1Fxc3Z0QlZWRUhCa1I4a29JWnFPbHV5MHg3Uk5X?= =?utf-8?B?UGZESHJaQ0xhZ2pDSURSS2NKZDF5TEZ4VzNtenN1Z2J6R0xPcG9JR21qOVNX?= =?utf-8?B?c1NIeGp2K3pUQU9Jd0tLMEdLWC9GTTNvSW1TeStEOVlrdURVOEtnc09DUkVV?= =?utf-8?B?TmdOTnZzZTZWSXBLZUp1ajFJQSttWHA3SC9LMTFEZDhtYzNraEpEcUZLZnlR?= =?utf-8?B?cGJ0ajN0WGhIL2Q1QzVsUW11UHpjeTg1a1VrTjJ4aU5FaisrZ29BQkdoM1l3?= =?utf-8?B?UUdpclkwcmV2RVNYYkVweGtCZXRTVUJZUHR3N3lyL01hSFV6dy9DM3NPZ3RR?= =?utf-8?B?V21yaGI2bGE1Q3FVMGJGN0pkaWVyK1JnOElzRGZnbGhySmdoVEozeGY0UW9Z?= =?utf-8?B?OWkrQ1lSVFhGRHFsbXNJT1JMNklseHBBbUEvQm56OStSQm95OTVrb3FvekpH?= =?utf-8?B?bGhOWHFkd0c3QzVObUdGbld1alZPVmpNYVdBRzdXMUhKK1lWeGZBZDNtRnFN?= =?utf-8?B?Mm55UzcxVEE0S0hiUXgzNEdRK1F1Um12M3BMdHFVUlVsT3ZpQUtQT0ZFVnRG?= =?utf-8?Q?gUrU=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(7416014)(376014)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2025 12:43:30.0259 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d2eee96c-9b85-46e0-9f63-08de1d3216d1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044FC.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5786 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251106_044339_378026_E1F3BB79 X-CRM114-Status: GOOD ( 21.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/5/2025 9:04 PM, Heiko Carstens wrote: > On Tue, Oct 14, 2025 at 08:49:10AM +0200, Thomas Weißschuh wrote: >> Allocating the datapages as part of the kernel image does not work on >> SPARC. It is also problematic with regards to dcache aliasing as there is >> no guarantee that the virtual addresses used by the kernel are compatible >> with those used by userspace. >> >> Allocate the data pages through the page allocator instead. >> Unused pages in the vDSO VMA are still allocated to keep the virtual >> addresses aligned. >> >> These pages are used by both the timekeeping, random pool and architecture >> initialization code. Introduce a new early initialization step, to make >> sure they are available when needed. >> >> Signed-off-by: Thomas Weißschuh >> Tested-by: Andreas Larsson >> Reviewed-by: Andreas Larsson >> --- >> include/linux/vdso_datastore.h | 6 ++++++ >> init/main.c | 2 ++ >> lib/vdso/datastore.c | 44 ++++++++++++++++++++++-------------------- >> 3 files changed, 31 insertions(+), 21 deletions(-) > > ... > >> +void __init vdso_setup_data_pages(void) >> +{ >> + unsigned int order = get_order(VDSO_NR_PAGES * PAGE_SIZE); >> + struct folio *folio = folio_alloc(GFP_KERNEL, order); > > I'm seeing random hangs on s390 too with our CI, but unfortunately I cannot > reproduce it manually. But looking at one of the dumps it looks to me like the > vdso time page contains (more or less) random junk at the end. Or in other > words, shouldn't this be: > > struct folio *folio = folio_alloc(GFP_KERNEL | __GFP_ZERO, order); > > ? At least that is a difference to before as far as I can tell. I was also hitting random hangs with an x86 KVM guest boot on an AMD64 platform. The bisection landed on this commit as the culprit. I see that v5 has been posted. I am in the process of testing that version and will reply to the v5 thread with the results. Thank you Srikanth Aithal