[PATCH 0/2] ARM: shmobile: r8a7793: Add PFC to DT

[PATCH 0/2] ARM: shmobile: r8a7793: Add PFC to DT

[Simon Horman]

This short series adds PFC support to the r8a7793 and its gose board.

The PFC driver is already present and is the same driver as the r8a7791.

Simon Horman (2):
  ARM: shmobile: r8a7793: Add PFC to DT
  ARM: shmobile: gose: Configure PFC in DT

 arch/arm/boot/dts/r8a7793-gose.dts | 31 +++++++++++++++++++++++++++++++
 arch/arm/boot/dts/r8a7793.dtsi     |  6 ++++++
 2 files changed, 37 insertions(+)

-- 
2.1.4

[PATCH 1/2] ARM: shmobile: r8a7793: Add PFC to DT

[Simon Horman]

Instantiate PFC device in r8a7793 DT.

Based on similar work for the r8a7791 by Magnus Damm.

Cc: Magnus Damm <damm@opensource.se>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7793.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
index fcafa87616fa..6597207cd55e 100644
--- a/arch/arm/boot/dts/r8a7793.dtsi
+++ b/arch/arm/boot/dts/r8a7793.dtsi
@@ -114,6 +114,12 @@
 		power-domains = <&cpg_clocks>;
 	};
 
+	pfc: pfc at e6060000 {
+		compatible = "renesas,pfc-r8a7793";
+		reg = <0 0xe6060000 0 0x250>;
+		#gpio-range-cells = <3>;
+	};
+
 	scif0: serial at e6e60000 {
 		compatible = "renesas,scif-r8a7793", "renesas,scif";
 		reg = <0 0xe6e60000 0 64>;
-- 
2.1.4

[PATCH 2/2] ARM: shmobile: gose: Configure PFC in DT

[Simon Horman]

Configure PFC for the already enabled scif and ethernet devices
in the device tree for the gose board.

Based on similar work for the koelsch board by Laurent Pinchart and
Sergei Shtylyov.

Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7793-gose.dts | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7793-gose.dts b/arch/arm/boot/dts/r8a7793-gose.dts
index 96443ec5f6ab..1575ef759047 100644
--- a/arch/arm/boot/dts/r8a7793-gose.dts
+++ b/arch/arm/boot/dts/r8a7793-gose.dts
@@ -37,7 +37,32 @@
 	clock-frequency = <20000000>;
 };
 
+&pfc {
+	scif0_pins: serial0 {
+		renesas,groups = "scif0_data_d";
+		renesas,function = "scif0";
+	};
+
+	scif1_pins: serial1 {
+		renesas,groups = "scif1_data_d";
+		renesas,function = "scif1";
+	};
+
+	ether_pins: ether {
+		renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
+		renesas,function = "eth";
+	};
+
+	phy1_pins: phy1 {
+		renesas,groups = "intc_irq0";
+		renesas,function = "intc";
+	};
+};
+
 &ether {
+	pinctrl-0 = <&ether_pins &phy1_pins>;
+	pinctrl-names = "default";
+
 	phy-handle = <&phy1>;
 	renesas,ether-link-active-low;
 	status = "okay";
@@ -55,9 +80,15 @@
 };
 
 &scif0 {
+	pinctrl-0 = <&scif0_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 };
 
 &scif1 {
+	pinctrl-0 = <&scif1_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 };
-- 
2.1.4

[PATCH 2/2] ARM: shmobile: gose: Configure PFC in DT

[Laurent Pinchart]

Hi Simon,

On Monday 09 November 2015 10:33:19 Simon Horman wrote:
> Configure PFC for the already enabled scif and ethernet devices
> in the device tree for the gose board.
> 
> Based on similar work for the koelsch board by Laurent Pinchart and
> Sergei Shtylyov.

I can't really comment on the patch due to lack of a schematics for the Goose 
board, but it looks good to me in principle.

Acked-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm/boot/dts/r8a7793-gose.dts | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7793-gose.dts
> b/arch/arm/boot/dts/r8a7793-gose.dts index 96443ec5f6ab..1575ef759047
> 100644
> --- a/arch/arm/boot/dts/r8a7793-gose.dts
> +++ b/arch/arm/boot/dts/r8a7793-gose.dts
> @@ -37,7 +37,32 @@
>  	clock-frequency = <20000000>;
>  };
> 
> +&pfc {
> +	scif0_pins: serial0 {
> +		renesas,groups = "scif0_data_d";
> +		renesas,function = "scif0";
> +	};
> +
> +	scif1_pins: serial1 {
> +		renesas,groups = "scif1_data_d";
> +		renesas,function = "scif1";
> +	};
> +
> +	ether_pins: ether {
> +		renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
> +		renesas,function = "eth";
> +	};
> +
> +	phy1_pins: phy1 {
> +		renesas,groups = "intc_irq0";
> +		renesas,function = "intc";
> +	};
> +};
> +
>  &ether {
> +	pinctrl-0 = <&ether_pins &phy1_pins>;
> +	pinctrl-names = "default";
> +
>  	phy-handle = <&phy1>;
>  	renesas,ether-link-active-low;
>  	status = "okay";
> @@ -55,9 +80,15 @@
>  };
> 
>  &scif0 {
> +	pinctrl-0 = <&scif0_pins>;
> +	pinctrl-names = "default";
> +
>  	status = "okay";
>  };
> 
>  &scif1 {
> +	pinctrl-0 = <&scif1_pins>;
> +	pinctrl-names = "default";
> +
>  	status = "okay";
>  };

-- 
Regards,

Laurent Pinchart

[PATCH 2/2] ARM: shmobile: gose: Configure PFC in DT

[Simon Horman]

On Mon, Nov 09, 2015 at 04:16:45PM +0200, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Monday 09 November 2015 10:33:19 Simon Horman wrote:
> > Configure PFC for the already enabled scif and ethernet devices
> > in the device tree for the gose board.
> > 
> > Based on similar work for the koelsch board by Laurent Pinchart and
> > Sergei Shtylyov.
> 
> I can't really comment on the patch due to lack of a schematics for the Goose 
> board, but it looks good to me in principle.
> 
> Acked-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Thanks, I have queued up both patches of this series.