From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E23EAC43458 for ; Mon, 6 Jul 2026 09:21:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0z2y6LE/QNiaZie2U6t5hcyeaoflSldXfYCObvCylqs=; b=pjkoNjqyiSFeELFyWWXFcWxa+V rK9taW0vkLfVeR3B5nrZE36uwlgkjRg5CWWhdrJHa16gUbloF5dUV/NWwgd8Q4ZtMhLOaSKsk9Leg YUOGCl/aBwiOy72LJL+fg+zvIYMvj1EzVZr8nf64+eZZOcw7TIV0OEPu7b6uuqdv1SZ+vLI5IHGsR Q1M+DW+U9BRhJ6+SYEGDBj4bT0oLifklUFKu9597xZqcTEsyo6m+6eM+eIlABSHL5jyTWARI/nzaq 1xfckUExWQ4x7d2/0V11EsxgZ3JN/7Cp5AHkM2ZNqoNlONJxTVzDVNi0NReaNqOHsMw1S6apzXpYh HPZV1AnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgfWD-0000000C0AF-1pVA; Mon, 06 Jul 2026 09:21:37 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgfWB-0000000C095-0Opo for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2026 09:21:36 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B61E228C7; Mon, 6 Jul 2026 02:21:27 -0700 (PDT) Received: from [192.168.178.24] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CEDE33F7B4; Mon, 6 Jul 2026 02:21:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1783329692; bh=1JBo9aYBrCOqV4k9LD/HWHclWEQxNqoysZ2Aob1Jdtk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bhpNUUzzt7h988FqRrP93aumvnNVwYOtonMg08GWB5J4D2QYAtvsZbkUt66scOHwj ixJ3LsVaTnTKR2mM8yIrdRGyh0Di9+GPvIAxUO0+LvWPjK0YNmPtGZuJoVtJB7DLf9 E7alh2RhRaJMc+GFTWlk490rDd51ivOycSXaDojU= Message-ID: <97a674a3-4833-4aa6-a9a2-3ab5472ee4b3@arm.com> Date: Mon, 6 Jul 2026 11:21:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] arm64: dts: allwinner: a523: add IR receiver node To: Justin Suess , Sean Young , Mauro Carvalho Chehab , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Ripard Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Sashiko References: <20260702214750.3428694-1-utilityemal77@gmail.com> <20260702214750.3428694-4-utilityemal77@gmail.com> Content-Language: en-GB From: Andre Przywara In-Reply-To: <20260702214750.3428694-4-utilityemal77@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260706_022135_216260_E691644B X-CRM114-Status: GOOD ( 21.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Justin, I checked the numbers below against the manual, they match up: MMIO base address, interrupt number, clocks and resets. One thing I figured is that the A523/T527 contains another CIR-RX instance, in the "CPUX" domain. That's used for instance on the Avaota-A1. So we need another node describing this instance. Some more below... On 7/2/26 23:47, Justin Suess wrote: > The A523 has a CIR receiver in the RTC power domain, clocked from the > R-CCU, with its RX signal available on PL11. > > Clock the module directly from the 24 MHz host oscillator; the driver > selects a /256 sample divider on this SoC, giving a sample period > close to the legacy 8 MHz / 64 configuration of older SoCs. > > Keep the node disabled by default; boards with an IR receiver can > enable it. > > Signed-off-by: Justin Suess > --- > .../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi > index ca6a16807049..5e46c4b1ee61 100644 > --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi > @@ -927,6 +927,25 @@ r_i2c_pins: r-i2c-pins { > allwinner,pinmux = <2>; > function = "r_i2c0"; > }; > + > + r_ir_rx_pin: r-ir-rx-pin { > + pins = "PL11"; > + allwinner,pinmux = <2>; > + function = "s_cir"; > + }; > + }; > + > + r_ir: ir@7040000 { > + compatible = "allwinner,sun55i-a523-ir"; As mentioned in the other email, I think we can use the fallback compatible, so add this here. > + reg = <0x07040000 0x400>; > + interrupts = ; > + clocks = <&r_ccu CLK_BUS_R_IR_RX>, <&r_ccu CLK_R_IR_RX>; > + clock-names = "apb", "ir"; > + clock-frequency = <24000000>; As said in the other email, I think this property is misnamed and misleading, just drop it, and let the driver select the sample rate. > + resets = <&r_ccu RST_BUS_R_IR_RX>; > + pinctrl-names = "default"; > + pinctrl-0 = <&r_ir_rx_pin>; There is another pin which carries the R-IR-RX signal, on pin PM8. In those cases we do not add the pinctrl properties to the .dtsi DT node, but let each board add it, right next to where they enable the IP. So please drop those two lines from here. Cheers, Andre > + status = "disabled"; > }; > > pck600: power-controller@7060000 {