Re: [PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on PineNote

[Dragan Simic <dsimic@manjaro.org>]

On 2025-02-07 17:39, Diederik de Haas wrote:
> On Fri Feb 7, 2025 at 4:01 PM CET, Dragan Simic wrote:
>> On 2025-02-07 12:11, Diederik de Haas wrote:
>>> Add the recommended chassis-type root node property so userspace can
>>> request the form factor and adjust their behavior accordingly.
>>> 
>>> Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
>>> Link:
>>> https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter3-devicenodes.rst#root-node
>> 
>> Maybe the Link tag should be converted into a "[1]" reference?
>> To me, this is more like a reference for this DT addition.
>> 
>> In general, references can also be placed closer to the contents
>> they back up, which isn't possible with Link tags, but of course
>> that doesn't matter much in this case.
> 
> I generally use the "[1]" format when linking to specific claims, which
> I could've done wrt the "recommended". But I considered this a general
> background link and then I prefer to do it via a Link tag.
> 
> If requested by a maintainer I'll change it ofc, but otherwise I prefer
> to keep it as is.

Indeed, in this case it's pretty much irrelevant which format is used.
In fact, it may look nicer to use a Link tag, because there are only
a few lines in the patch description in total. :)

My comment was more about longer commit/patch descriptions with multiple
references, which should benefit from placing references closer to the
backed-up contents using the "[*]" layout, instead of relying on Link
tags to bunch it all together at the end of the description.