From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4E7DC54749 for ; Wed, 28 Aug 2024 03:30:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5sc6J3Ui5qWEXcQEzNbj36Es+HY8dKW4MEYb+d4FCh4=; b=i34xUP4U7eXAtDPeB0qkn/DiWs KFFd+JNJx4jeaWtNFbpX8VSMTcSsIMC9y+bY70jtTfVOLAUxfTCPclM5H9PZ5muIZk6W0hnBHK5Ic 0MxayKNRFb+IXooUVzHpZz3PdcmMXktwTm01O5LE+GR8qUsp+labGXMkRiIIMgbMoMHTFdc0vuH/l hXOUUjTIc+sUcuKQNVkplZkiVegNYCIWFJbo9ce6+6hk+kuJwY3U4xl0rS+ON3hNUSMWqc7drpoeC QUxY6YHqBGaLEpk5Xa7hn6oz0dTabSmIJYO23KYL8E8zu1fl1N6ok5iKiQAmvNnRqs2/ma9iQ6y+M /bQiQyfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sj9OG-0000000DeZT-3hOM; Wed, 28 Aug 2024 03:30:36 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sj8KX-0000000DTDy-0KGS for linux-arm-kernel@bombadil.infradead.org; Wed, 28 Aug 2024 02:22:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:To:Subject:MIME-Version:Date:Message-ID:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=5sc6J3Ui5qWEXcQEzNbj36Es+HY8dKW4MEYb+d4FCh4=; b=jI7Ru5U2gY5JIio2iIbqNrepis To2jvxyh0HESNf59uZbA8negC44tsxGdsltiMW0qA2IJ/oH1cHk5D0GZGrIxHDajrHfVgLL+zk4kA OM1WGAahaHt/CEDsPrwlF14sntdmeXQoRh7UlRT9C0s+2ntKuV0iF7kBdLhJUPB0Vy8huGDykuUGF oMCcsOylYr5PGsGhh0e/tcMaBEFbysTi5jdd+9Wbuve655WCP2613JoAMDFxqiF94UQjMuwb9lIob Yhzca7rHEJUzGaNFDAtKDeD+lkccOXzSWaUeG0SQ9DH1yZIXZtYsg510nXeHxfLIr+aeLTPFTD10a EXBx0Ohg==; Received: from szxga06-in.huawei.com ([45.249.212.32]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sj7xX-0000000Azrl-1qsP for linux-arm-kernel@lists.infradead.org; Wed, 28 Aug 2024 01:58:58 +0000 Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4WtnZq5xBbz1xty0; Wed, 28 Aug 2024 09:56:35 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 4E261140135; Wed, 28 Aug 2024 09:58:33 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 28 Aug 2024 09:58:32 +0800 Message-ID: <97ff8c02-1a97-7974-06fa-edb35437707d@huawei.com> Date: Wed, 28 Aug 2024 09:58:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH -next 2/8] soc: fsl: cpm1: Simplify with dev_err_probe() To: Krzysztof Kozlowski , , , , , , , , , , , , , , , , , , , References: <20240827114607.4019972-1-ruanjinjie@huawei.com> <20240827114607.4019972-3-ruanjinjie@huawei.com> <87abe3f1-3cf2-4331-8dde-a422716dd94a@kernel.org> Content-Language: en-US From: Jinjie Ruan In-Reply-To: <87abe3f1-3cf2-4331-8dde-a422716dd94a@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.109.254] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemh500013.china.huawei.com (7.202.181.146) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240828_025856_453874_1EA64369 X-CRM114-Status: GOOD ( 14.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024/8/27 21:50, Krzysztof Kozlowski wrote: > On 27/08/2024 13:46, Jinjie Ruan wrote: >> Use the dev_err_probe() helper to simplify error handling during probe. >> This also handle scenario, when EDEFER is returned and useless error >> is printed. > > ? Sorry, this cannot happen. Please point to below code which can defer. > Thank you! This is not referring to a specific one, but rather the benefits it offers，simplify code is the main purpose, if necessary, it will be removed in next version. >> >> Signed-off-by: Jinjie Ruan >> --- >> drivers/soc/fsl/qe/tsa.c | 62 +++++++++++++++------------------------- >> 1 file changed, 23 insertions(+), 39 deletions(-) >> >> diff --git a/drivers/soc/fsl/qe/tsa.c b/drivers/soc/fsl/qe/tsa.c >> index 7fa399b7a47c..fc37d23b746d 100644 >> --- a/drivers/soc/fsl/qe/tsa.c >> +++ b/drivers/soc/fsl/qe/tsa.c >> @@ -453,10 +453,8 @@ static int tsa_of_parse_tdms(struct tsa *tsa, struct device_node *np) >> >> for_each_available_child_of_node_scoped(np, tdm_np) { >> ret = of_property_read_u32(tdm_np, "reg", &tdm_id); >> - if (ret) { >> - dev_err(tsa->dev, "%pOF: failed to read reg\n", tdm_np); >> - return ret; >> - } >> + if (ret) >> + return dev_err_probe(tsa->dev, ret, "%pOF: failed to read reg\n", tdm_np); >> switch (tdm_id) { >> case 0: >> tsa->tdms |= BIT(TSA_TDMA); >> @@ -465,18 +463,15 @@ static int tsa_of_parse_tdms(struct tsa *tsa, struct device_node *np) >> tsa->tdms |= BIT(TSA_TDMB); >> break; >> default: >> - dev_err(tsa->dev, "%pOF: Invalid tdm_id (%u)\n", tdm_np, >> - tdm_id); >> - return -EINVAL; >> + return dev_err_probe(tsa->dev, -EINVAL, "%pOF: Invalid tdm_id (%u)\n", >> + tdm_np, tdm_id); >> } >> } >> >> for_each_available_child_of_node_scoped(np, tdm_np) { >> ret = of_property_read_u32(tdm_np, "reg", &tdm_id); >> - if (ret) { >> - dev_err(tsa->dev, "%pOF: failed to read reg\n", tdm_np); >> - return ret; >> - } >> + if (ret) >> + return dev_err_probe(tsa->dev, ret, "%pOF: failed to read reg\n", tdm_np); >> >> tdm = &tsa->tdm[tdm_id]; >> tdm->simode_tdm = TSA_SIMODE_TDM_SDM_NORM; >> @@ -484,35 +479,26 @@ static int tsa_of_parse_tdms(struct tsa *tsa, struct device_node *np) >> val = 0; >> ret = of_property_read_u32(tdm_np, "fsl,rx-frame-sync-delay-bits", >> &val); >> - if (ret && ret != -EINVAL) { >> - dev_err(tsa->dev, >> - "%pOF: failed to read fsl,rx-frame-sync-delay-bits\n", >> - tdm_np); >> - return ret; >> - } >> - if (val > 3) { >> - dev_err(tsa->dev, >> - "%pOF: Invalid fsl,rx-frame-sync-delay-bits (%u)\n", >> - tdm_np, val); >> - return -EINVAL; >> - } >> + if (ret && ret != -EINVAL) >> + return dev_err_probe(tsa->dev, ret, >> + "%pOF: failed to read fsl,rx-frame-sync-delay-bits\n", >> + tdm_np); >> + if (val > 3) >> + return dev_err_probe(tsa->dev, -EINVAL, >> + "%pOF: Invalid fsl,rx-frame-sync-delay-bits (%u)\n", >> + tdm_np, val); >> tdm->simode_tdm |= TSA_SIMODE_TDM_RFSD(val); >> >> val = 0; >> ret = of_property_read_u32(tdm_np, "fsl,tx-frame-sync-delay-bits", >> &val); >> - if (ret && ret != -EINVAL) { >> - dev_err(tsa->dev, >> - "%pOF: failed to read fsl,tx-frame-sync-delay-bits\n", >> - tdm_np); >> - return ret; >> - } >> - if (val > 3) { >> - dev_err(tsa->dev, >> - "%pOF: Invalid fsl,tx-frame-sync-delay-bits (%u)\n", >> - tdm_np, val); >> - return -EINVAL; >> - } >> + if (ret && ret != -EINVAL) >> + return dev_err_probe(tsa->dev, ret, >> + "%pOF: failed to read fsl,tx-frame-sync-delay-bits\n", tdm_np); >> + if (val > 3) >> + return dev_err_probe(tsa->dev, -EINVAL, >> + "%pOF: Invalid fsl,tx-frame-sync-delay-bits (%u)\n", >> + tdm_np, val); >> tdm->simode_tdm |= TSA_SIMODE_TDM_TFSD(val); >> >> if (of_property_read_bool(tdm_np, "fsl,common-rxtx-pins")) >> @@ -645,10 +631,8 @@ static int tsa_probe(struct platform_device *pdev) >> return PTR_ERR(tsa->si_regs); >> >> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "si_ram"); >> - if (!res) { >> - dev_err(tsa->dev, "si_ram resource missing\n"); >> - return -EINVAL; >> - } >> + if (!res) >> + return dev_err_probe(tsa->dev, -EINVAL, "si_ram resource missing\n"); >> tsa->si_ram_sz = resource_size(res); >> tsa->si_ram = devm_ioremap_resource(&pdev->dev, res); >> if (IS_ERR(tsa->si_ram)) > > Best regards, > Krzysztof >