From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Pin-yen Lin <treapking@chromium.org>,
"Jason-JH.Lin" <jason-jh.lin@mediatek.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Singo Chang <singo.chang@mediatek.com>,
Nancy Lin <nancy.lin@mediatek.com>,
Shawn Sung <shawn.sung@mediatek.com>,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Fei Shao <fshao@chromium.org>
Subject: Re: [PATCH v2 3/3] dts: arm64: mediatek: mt8195: Remove MT8183 compatible for OVL
Date: Fri, 13 Dec 2024 11:33:04 +0100 [thread overview]
Message-ID: <980d28d6-52f0-4430-954b-da673fcd92df@collabora.com> (raw)
In-Reply-To: <CAEXTbpfOv876s3NLTO3oMTtVi_BwBtgb-816Gt5ZjKMjTZZKQg@mail.gmail.com>
Il 13/12/24 11:27, Pin-yen Lin ha scritto:
> Hi Jason,
>
> On Fri, Dec 13, 2024 at 5:50 PM Jason-JH.Lin <jason-jh.lin@mediatek.com> wrote:
>>
>> The OVL hardware capabilities have changed starting from MT8195,
>> making the MT8183 compatible no longer applicable.
>> Therefore, it is necessary to remove the MT8183 compatible for OVL.
>
> Similar to patch 2/3, we need a:
>
> Fixes: b852ee68fd72 ("arm64: dts: mt8195: Add display node for vdosys0")
>
No, we don't, for reasons that are similar to the ones that I explained in the
MT8188 commit.
Besides, this one was already featureful before this commit, so really this is
not worth backporting at all.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>
>> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
>> ---
>> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>> index ade685ed2190..137ee8929e01 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>> @@ -3138,7 +3138,7 @@ larb20: larb@1b010000 {
>> };
>>
>> ovl0: ovl@1c000000 {
>> - compatible = "mediatek,mt8195-disp-ovl", "mediatek,mt8183-disp-ovl";
>> + compatible = "mediatek,mt8195-disp-ovl";
>> reg = <0 0x1c000000 0 0x1000>;
>> interrupts = <GIC_SPI 636 IRQ_TYPE_LEVEL_HIGH 0>;
>> power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>;
>> --
>> 2.43.0
>>
>
> Regards,
> Pin-yen
prev parent reply other threads:[~2024-12-13 10:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 9:50 [PATCH v2 0/3] Update MT8188 OVL compatible from MT8183 to MT8195 Jason-JH.Lin
2024-12-13 9:50 ` [PATCH v2 1/3] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188 Jason-JH.Lin
2024-12-19 11:09 ` AngeloGioacchino Del Regno
2024-12-19 17:26 ` Jason-JH Lin (林睿祥)
2024-12-19 11:45 ` AngeloGioacchino Del Regno
2024-12-13 9:50 ` [PATCH v2 2/3] dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to MT8195 Jason-JH.Lin
2024-12-13 10:26 ` Pin-yen Lin
2024-12-13 10:33 ` AngeloGioacchino Del Regno
2024-12-13 9:50 ` [PATCH v2 3/3] dts: arm64: mediatek: mt8195: Remove MT8183 compatible for OVL Jason-JH.Lin
2024-12-13 10:27 ` Pin-yen Lin
2024-12-13 10:33 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=980d28d6-52f0-4430-954b-da673fcd92df@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=chunkuang.hu@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fshao@chromium.org \
--cc=jason-jh.lin@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nancy.lin@mediatek.com \
--cc=robh@kernel.org \
--cc=shawn.sung@mediatek.com \
--cc=singo.chang@mediatek.com \
--cc=treapking@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox