From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Yu-Chun Lin [林祐君]" <eleanor.lin@realtek.com>
Cc: "mturquette@baylibre.com" <mturquette@baylibre.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"Edgar Lee [李承諭]" <cylee12@realtek.com>,
"afaerber@suse.com" <afaerber@suse.com>,
"Jyan Chou [周芷安]" <jyanchou@realtek.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-realtek-soc@lists.infradead.org"
<linux-realtek-soc@lists.infradead.org>,
"James Tai [戴志峰]" <james.tai@realtek.com>,
"CY_Huang[黃鉦晏]" <cy.huang@realtek.com>,
"Stanley Chang[昌育德]" <stanley_chang@realtek.com>
Subject: Re: [PATCH v4 03/10] clk: realtek: Add basic reset support
Date: Tue, 17 Mar 2026 08:14:49 +0100 [thread overview]
Message-ID: <9817e7b3-c8f0-4904-8652-16008079c388@kernel.org> (raw)
In-Reply-To: <907b6a0128904309991f0a4a9000d8f1@realtek.com>
On 17/03/2026 03:12, Yu-Chun Lin [林祐君] wrote:
>>> diff --git a/drivers/clk/realtek/reset.c b/drivers/clk/realtek/reset.c
>>> new file mode 100644 index 000000000000..45713785d76d
>>> --- /dev/null
>>> +++ b/drivers/clk/realtek/reset.c
>>> @@ -0,0 +1,104 @@
>>> +// SPDX-License-Identifier: GPL-2.0-only
>>> +/*
>>> + * Copyright (C) 2019 Realtek Semiconductor Corporation */
>>> +
>>> +#include <linux/device.h>
>>> +#include <linux/of.h>
>>> +#include <linux/regmap.h>
>>> +#include "reset.h"
>>
>> And here is the proof that none of your reset header constants are bindings -
>> do you see the header here above? No.
>>
>
> The bank mapping is implicitly hardcoded in drivers:
Does not matter. Here is the proof this is not a binding.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-17 7:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 8:10 [PATCH v4 00/10] clk: realtek: Add RTD1625 Clock Support Yu-Chun Lin
2026-03-13 8:10 ` [PATCH v4 01/10] dt-bindings: clock: Add Realtek RTD1625 Clock & Reset Controller Yu-Chun Lin
2026-03-14 9:16 ` Krzysztof Kozlowski
2026-03-17 1:57 ` Yu-Chun Lin [林祐君]
2026-03-17 7:14 ` Krzysztof Kozlowski
2026-03-17 14:13 ` Yu-Chun Lin
2026-03-13 8:10 ` [PATCH v4 02/10] arm64: dts: realtek: Add clock support for RTD1625 Yu-Chun Lin
2026-03-13 8:10 ` [PATCH v4 03/10] clk: realtek: Add basic reset support Yu-Chun Lin
2026-03-14 9:19 ` Krzysztof Kozlowski
2026-03-17 2:12 ` Yu-Chun Lin [林祐君]
2026-03-17 7:14 ` Krzysztof Kozlowski [this message]
2026-03-18 13:02 ` Philipp Zabel
2026-03-13 8:10 ` [PATCH v4 04/10] clk: realtek: Introduce a common probe() Yu-Chun Lin
2026-03-13 8:10 ` [PATCH v4 05/10] clk: realtek: Add support for phase locked loops (PLLs) Yu-Chun Lin
2026-03-13 8:10 ` [PATCH v4 06/10] clk: realtek: Add support for gate clock Yu-Chun Lin
2026-03-13 8:10 ` [PATCH v4 07/10] clk: realtek: Add support for mux clock Yu-Chun Lin
2026-03-13 8:10 ` [PATCH v4 08/10] clk: realtek: Add support for MMC-tuned PLL clocks Yu-Chun Lin
2026-03-13 8:10 ` [PATCH v4 09/10] clk: realtek: Add RTD1625-CRT clock controller driver Yu-Chun Lin
2026-03-13 8:11 ` [PATCH v4 10/10] clk: realtek: Add RTD1625-ISO " Yu-Chun Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9817e7b3-c8f0-4904-8652-16008079c388@kernel.org \
--to=krzk@kernel.org \
--cc=afaerber@suse.com \
--cc=conor+dt@kernel.org \
--cc=cy.huang@realtek.com \
--cc=cylee12@realtek.com \
--cc=devicetree@vger.kernel.org \
--cc=eleanor.lin@realtek.com \
--cc=james.tai@realtek.com \
--cc=jyanchou@realtek.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-realtek-soc@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=stanley_chang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox