From: Sohil Mehta <sohil.mehta@intel.com>
To: Eric Biggers <ebiggers@kernel.org>, <linux-crypto@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Ard Biesheuvel <ardb@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mips@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
<linux-riscv@lists.infradead.org>, <linux-s390@vger.kernel.org>,
<sparclinux@vger.kernel.org>, <x86@kernel.org>
Subject: Re: [PATCH 8/9] lib/crypto/x86: move arch/x86/lib/crypto/ to lib/crypto/x86/
Date: Tue, 17 Jun 2025 17:41:09 -0700 [thread overview]
Message-ID: <983d7906-6510-4867-978f-4f937b29224b@intel.com> (raw)
In-Reply-To: <20250617222726.365148-9-ebiggers@kernel.org>
On 6/17/2025 3:27 PM, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Move the contents of arch/x86/lib/crypto/ into lib/crypto/x86/.
>
> The new code organization makes a lot more sense for how this code
> actually works and is developed. In particular, it makes it possible to
> build each algorithm as a single module, with better inlining and dead
> code elimination. For a more detailed explanation, see the patchset
> which did this for the CRC library code:
> https://lore.kernel.org/r/20250607200454.73587-1-ebiggers@kernel.org/.
> Also see the patchset which did this for SHA-512:
> https://lore.kernel.org/linux-crypto/20250616014019.415791-1-ebiggers@kernel.org/
>
> This is just a preparatory commit, which does the move to get the files
> into their new location but keeps them building the same way as before.
> Later commits will make the actual improvements to the way the
> arch-optimized code is integrated for each algorithm.
>
> arch/x86/lib/crypto/.gitignore is intentionally kept for now. See
> https://lore.kernel.org/r/CAHk-=whu2fb22rEy6+oKx1-+NCHuWucZepvD0H2MD38DrJVKtg@mail.gmail.com/
> I'll remove it later after some time has passed.
>
After this change, arch/x86/lib/ has a lone empty directory crypto with
the .gitignore file.
Instead, would it be cleaner to get rid of the crypto directory
altogether and update the .gitignore of the parent?
As per the link above, commit 2df0c02dab82 ("x86 boot build: make git
ignore stale 'tools' directory") says this:
"So when removing directories that had special .gitignore patterns, make
sure to add a new gitignore entry in the parent directory for the no
longer existing subdirectory."
With that change,
Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
next prev parent reply other threads:[~2025-06-18 0:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 22:27 [PATCH 0/9] lib/crypto: move arch/$(ARCH)/lib/crypto/ to lib/crypto/$(ARCH)/ Eric Biggers
2025-06-17 22:27 ` [PATCH 1/9] lib/crypto/arm: move arch/arm/lib/crypto/ to lib/crypto/arm/ Eric Biggers
2025-06-17 22:27 ` [PATCH 2/9] lib/crypto/arm64: move arch/arm64/lib/crypto/ to lib/crypto/arm64/ Eric Biggers
2025-06-17 22:27 ` [PATCH 3/9] lib/crypto/mips: move arch/mips/lib/crypto/ to lib/crypto/mips/ Eric Biggers
2025-06-17 22:27 ` [PATCH 4/9] lib/crypto/powerpc: move arch/powerpc/lib/crypto/ to lib/crypto/powerpc/ Eric Biggers
2025-06-17 22:27 ` [PATCH 5/9] lib/crypto/riscv: move arch/riscv/lib/crypto/ to lib/crypto/riscv/ Eric Biggers
2025-06-17 22:27 ` [PATCH 6/9] lib/crypto/s390: move arch/s390/lib/crypto/ to lib/crypto/s390/ Eric Biggers
2025-06-17 22:27 ` [PATCH 7/9] lib/crypto/sparc: move arch/sparc/lib/crypto/ to lib/crypto/sparc/ Eric Biggers
2025-06-17 22:27 ` [PATCH 8/9] lib/crypto/x86: move arch/x86/lib/crypto/ to lib/crypto/x86/ Eric Biggers
2025-06-18 0:41 ` Sohil Mehta [this message]
2025-06-18 2:52 ` Eric Biggers
2025-06-17 22:27 ` [PATCH 9/9] MAINTAINERS: drop arch/*/lib/crypto/ pattern Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=983d7906-6510-4867-978f-4f937b29224b@intel.com \
--to=sohil.mehta@intel.com \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sparclinux@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).