From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 190A7C54E58 for ; Wed, 20 Mar 2024 03:46:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:CC:References:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=nASADSWG66jO02haVY+A1MJZsl/Gr+oKawOJAaOJVTs=; b=ATb//m8PVsqHTbsP2USaU4+M29 ZzBjf88umHAiXBDdtMyMS/mD1RT3H3Pz4rehxLtif+efi2F9pg0rQbIRi++Bl6p5oqOxI9AZyo8ih 0UDB8+WSjEK3RPejgM1vTgRc95AWqKTf89QIOXOyBCsuf3RqeZ6Co+LRhjCK0XeoyD7m/MJOhb/86 o5RM0BJRhV5vI78lKZC+2TLd9DZvEuPX8ojLpn5PerF1nzvq9/7HG1sISAE6b4iyRBl58ckpFzF+r e2EOJV5hAprLrQYVmmdh3pG/UtDmGymCRcf9FV7kkaKrYuKnhcLEMmTbINs098eiUxiJ1Lf1McFhA cST2ldoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmmub-0000000FHRN-3Ot1; Wed, 20 Mar 2024 03:46:45 +0000 Received: from szxga05-in.huawei.com ([45.249.212.191]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmmuX-0000000FHP2-3oMa for linux-arm-kernel@lists.infradead.org; Wed, 20 Mar 2024 03:46:43 +0000 Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4TzvdY0Kfqz1HBvb; Wed, 20 Mar 2024 11:46:09 +0800 (CST) Received: from canpemm500010.china.huawei.com (unknown [7.192.105.118]) by mail.maildlp.com (Postfix) with ESMTPS id 0341F1A0172; Wed, 20 Mar 2024 11:46:32 +0800 (CST) Received: from [10.67.111.82] (10.67.111.82) by canpemm500010.china.huawei.com (7.192.105.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 20 Mar 2024 11:46:31 +0800 Subject: Re: [PATCH] ARM: unwind: improve unwinders for noreturn case To: Matthew Wilcox References: <1709516385-7778-1-git-send-email-xiaojiangfeng@huawei.com> <1710901169-22763-1-git-send-email-xiaojiangfeng@huawei.com> <202403191945.661DBCE8@keescook> CC: Kees Cook , , , , , , , , , , , , , , , , , , , , , , , From: Jiangfeng Xiao Message-ID: <98468785-ed75-f812-7263-1adf677f00d2@huawei.com> Date: Wed, 20 Mar 2024 11:46:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.67.111.82] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500010.china.huawei.com (7.192.105.118) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240319_204642_141433_C5566771 X-CRM114-Status: GOOD ( 10.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024/3/20 11:34, Matthew Wilcox wrote: > On Wed, Mar 20, 2024 at 11:30:13AM +0800, Jiangfeng Xiao wrote: >> The checkpatch.pl script reports the "WARNING: printk() should >> include KERN_ facility level" warning. >> >> That's why I changed printk to pr_warn. >> I should change printk to printk(KERN_DEFAULT). > > No, you should ignore checkpatch. For bonus points, figure out why you > should ignore it specifically in this case. > . > Thank you. I think I understand. The checkpatch.pl file is a false report because the 'loglvl' already exists. I'd better keep printk(" %s...", loglvl, ...) still. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel