From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB59C433DB for ; Thu, 25 Mar 2021 09:40:54 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99E3060249 for ; Thu, 25 Mar 2021 09:40:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99E3060249 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+HZjNr2wSWYUQ9B9fMNUkvP2Vc2qweZ09inrO60J11U=; b=BDzCIsVejTcatcMITFIFx2oM2 8AEIYmSuwjW6RnC9q+bTHub/x6zHXSv9Umu1ABYTo1lwFdWvLGgUuSLULC2U/cppzwY6m43ax0Y8b snpEV0cAlSHUf8zoye1sZY70VxqMghUBa0QNpRi1S5S3M4RxqIJ2jnR3/aQW56t9oFUaQ8PnIh7DV cwe35IbCi0pVn75Jz1ua0wdoNor9dC4TUzGYu+kyYJRhXb/x8BS/d63yyE3KfD++TRvOcGwlwRVkT Alnj4TmZ+vZGnZBt6VXMBZClNakMBqSW6uJEU1WONb2dPecjN9EepGkIagzX0cRk8niO105bjwgNT ApGq9Rvdw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPMQX-00177Q-N7; Thu, 25 Mar 2021 09:37:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPMMm-0016X5-Sd for linux-arm-kernel@lists.infradead.org; Thu, 25 Mar 2021 09:33:29 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2CA7F619E3; Thu, 25 Mar 2021 09:33:20 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1lPMMf-003hPI-SL; Thu, 25 Mar 2021 09:33:18 +0000 MIME-Version: 1.0 Date: Thu, 25 Mar 2021 09:33:17 +0000 From: Marc Zyngier To: Shameer Kolothum Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, pbonzini@redhat.com, linuxarm@huawei.com Subject: Re: [PATCH for-stable-5.10 2/2] KVM: arm64: Workaround firmware wrongly advertising GICv2-on-v3 compatibility In-Reply-To: <20210325091424.26348-3-shameerali.kolothum.thodi@huawei.com> References: <20210325091424.26348-1-shameerali.kolothum.thodi@huawei.com> <20210325091424.26348-3-shameerali.kolothum.thodi@huawei.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <9850fc39c1c80840ea77eba60ee5e663@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: shameerali.kolothum.thodi@huawei.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, pbonzini@redhat.com, linuxarm@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210325_093327_240499_FAE6839D X-CRM114-Status: GOOD ( 17.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-03-25 09:14, Shameer Kolothum wrote: > From: Marc Zyngier > > commit 9739f6ef053f104a997165701c6e15582c4307ee upstream. > > It looks like we have broken firmware out there that wrongly advertises > a GICv2 compatibility interface, despite the CPUs not being able to > deal > with it. > > To work around this, check that the CPU initialising KVM is actually > able > to switch to MMIO instead of system registers, and use that as a > precondition to enable GICv2 compatibility in KVM. > > Note that the detection happens on a single CPU. If the firmware is > lying *and* that the CPUs are asymetric, all hope is lost anyway. > > Cc: stable@vger.kernel.org #5.10 > Reported-by: Shameerali Kolothum Thodi > > Tested-by: Shameer Kolothum > Signed-off-by: Marc Zyngier > Message-Id: <20210305185254.3730990-8-maz@kernel.org> > Signed-off-by: Paolo Bonzini > Signed-off-by: Shameer Kolothum Please hold on on that. This patch causes a regression, and needs a fix that is currently queued for 5.12 [1]. Once this hits upstream, please add the fix to the series and post it as a whole. Thanks, M. [1] https://lore.kernel.org/r/20210323162301.2049595-1-maz@kernel.org -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel