From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] i2c: sunxi: Add Reduced Serial Bus (RSB) DT bindings documentation
Date: Tue, 24 Feb 2015 11:37:36 +0100 [thread overview]
Message-ID: <9851276.8ZCd3XfZle@wuerfel> (raw)
In-Reply-To: <1424773744-15106-3-git-send-email-wens@csie.org>
On Tuesday 24 February 2015 18:29:02 Chen-Yu Tsai wrote:
>
> + rsb at 01f03400 {
> + compatible = "allwinner,sun8i-a23-rsb";
> + reg = <0x01f03400 0x400>;
> + interrupts = <0 39 4>;
> + clocks = <&apb0_gates 3>;
> + clock-frequency = <3000000>;
> + resets = <&apb0_rst 3>;
> +
> + axp223: pmic at 2d {
> + compatible = "x-powers,axp223", "x-powers,axp221";
> + reg = <0x2d>;
> + allwinner,rsb-hw-addr = <0x3e3>;
> +
> + /* ... */
> + };
> + };
The child node cannot have a 'reg' property if the parent does not
have #address-cells/#size-cells. You should add these as mandatory
properties in the list.
I don't really understand the need for having two addresses (runtime
and hardware). Could the runtime address be configured at runtime?
Alternatively, could you use #address-cells=<2> and put both into
'reg'?
Arnd
next prev parent reply other threads:[~2015-02-24 10:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 10:29 [PATCH 0/4] i2c: sunxi: Add Reduced Serial Bus (RSB) support Chen-Yu Tsai
2015-02-24 10:29 ` [PATCH 1/4] " Chen-Yu Tsai
2015-02-24 10:29 ` [PATCH 2/4] i2c: sunxi: Add Reduced Serial Bus (RSB) DT bindings documentation Chen-Yu Tsai
2015-02-24 10:37 ` Arnd Bergmann [this message]
2015-02-24 14:01 ` Chen-Yu Tsai
2015-02-24 14:17 ` Arnd Bergmann
2015-02-24 14:32 ` Chen-Yu Tsai
2015-02-25 16:10 ` Arnd Bergmann
2015-02-24 10:29 ` [PATCH 3/4] ARM: dts: sun8i: Add Reduced Serial Bus controller device node to A23 dtsi Chen-Yu Tsai
2015-02-24 10:29 ` [PATCH 4/4] ARM: dts: sun8i: ippo-q8h-v5: Enable Reduced Serial Bus controller Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9851276.8ZCd3XfZle@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).