From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6E0AC3DA4A for ; Fri, 9 Aug 2024 18:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JocOi7P3PjNGxJXi85Ya63UzzmF3ct3nIXqmRfsseYc=; b=ZDdLh56aizH0y5ZEZaJPaaB6lG fVbw/t98LRqxxsCycfZ+P55pc5vqwadmXmcbhuAPM7C8taJ7W4wWRpu3O152jrZ8e1XIsNNm7/YvB fQn/1WVEG+PyPT8UJJpFz+Uy74r7HNaksnoOd8PxX/gKZ3Ix8d+KbtKLOKM4Tp7Blqsz90fn/FxF+ N8aRjGzLqHnCsAyftW09eSUTIjqFr6amoj3ZdIQI1wzjBt0o1JkKHFa3FrAVS0dgxH2e9GZBFeCUv RoGA3F1dRv/Z5qAvfwyxi5Znwx4BMRMgxP+MkLFbUrg/qEkfF1M/B2yBWwoIXY2iZXo7xdO0cvynk 2vG6RRSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1scUmJ-0000000CGV5-2C5E; Fri, 09 Aug 2024 18:55:55 +0000 Received: from out-170.mta1.migadu.com ([2001:41d0:203:375::aa]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1scUlh-0000000CGQ1-0zp9 for linux-arm-kernel@lists.infradead.org; Fri, 09 Aug 2024 18:55:19 +0000 Message-ID: <98826ab8-856a-4bd6-ae8b-bbfce945bdf4@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1723229708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JocOi7P3PjNGxJXi85Ya63UzzmF3ct3nIXqmRfsseYc=; b=YmRVIDw7k2/37Z6EOMldslDBm4DczE3AbIQt9+QBJSgTTso7Hoy7CYBO8ID5Nh8CRMQ7RR XrGcgKsfmndxddCmO+f1WRhvLFSuFWfKNND0ez9JAsKk2IqPIa3sEJqWedDuPxe+t73UMd vwaeYadfizEmSt34bODbewXhiMlsi5E= Date: Fri, 9 Aug 2024 14:55:02 -0400 MIME-Version: 1.0 Subject: Re: [PATCH v5 00/10] drm: zynqmp_dp: IRQ cleanups and debugfs support To: Tomi Valkeinen Cc: linux-arm-kernel@lists.infradead.org, David Airlie , linux-kernel@vger.kernel.org, Daniel Vetter , Michal Simek , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org References: <20240503192922.2172314-1-sean.anderson@linux.dev> <5c5aa8ae-75c4-4f0f-ad19-50ad57c61216@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240809_115517_694590_8438BD03 X-CRM114-Status: GOOD ( 14.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/8/24 08:46, Tomi Valkeinen wrote: > Hi Sean, > > On 17/06/2024 17:48, Sean Anderson wrote: >> On 6/17/24 03:47, Tomi Valkeinen wrote: >>> Hi Sean, >>> >>> On 03/05/2024 22:29, Sean Anderson wrote: >>>> This series cleans up the zyqnmp_dp IRQ and locking situation. Once >>>> that's done, it adds debugfs support. The intent is to enable compliance >>>> testing or to help debug signal-integrity issues. >>>> >>>> Last time I discussed converting the HPD work(s) to a threaded IRQ. I >>>> did not end up doing that for this series since the steps would be >>>> >>>> - Add locking >>>> - Move link retraining to a work function >>>> - Harden the IRQ >>>> - Merge the works into a threaded IRQ (omitted) >>>> >>>> Which with the exception of the final step is the same as leaving those >>>> works as-is. Conversion to a threaded IRQ can be done as a follow-up. >>> >>> I tested this, and the "drm: zynqmp_dp: Convert to a hard IRQ" causes a hang for me when unloading the drivers. Unfortunately I'm not in the condition to debug it at the moment. >>> >>> I have picked the first three patches into drm-misc-next, though, to decrease the number of patches in the series a bit. They looked independent and safe enough to apply. >> >> Are you running into [1]? >> >> --Sean >> >> [1] https://lore.kernel.org/dri-devel/4d8f4c9b-2efb-4774-9a37-2f257f79b2c9@linux.dev/ >> > > No. Afaics, it breaks because the irq handler is requested with IRQF_SHARED, and that means the handler can be called at any time. The handler reads DP registers, but the DP IP could already be powered off. > > You'll probably see it easily if you enable CONFIG_DEBUG_SHIRQ, and unload the module or unbind the device. Ah, looks like I need to use devm_free_irq instead of disable_irq. And after fixing this, [1] turns up again. I guess I'll take a crack at it... --Sean