From: Mark Brown <broonie@kernel.org>
To: Bui Duc Phuc <phucduc.bui@gmail.com>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH v2 2/4] ASoC: mediatek: mt8183: Fix APLL enable error handling
Date: Thu, 27 Aug 2026 17:28:30 +0100 [thread overview]
Message-ID: <98b11d2d-8157-4c1b-8562-42ff11cdff60@sirena.org.uk> (raw)
In-Reply-To: <CAABR9nHyDL8=EiSi+_GBpHM0xLZraH8az+HRXQWudG=1hLZ7qQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
On Thu, Aug 27, 2026 at 02:58:04PM +0700, Bui Duc Phuc wrote:
> To be honest, after looking at the code for other MediaTek SoCs, I found quite
> a few logic issues and inconsistent clock handling. This, along with
> the git log history,
> makes me wonder whether these code paths were ever properly tested on
> real hardware.
> Therefore, I have stopped at mt8186 for now.
There's a lot of code there with shaky error handling; probably the
default case works but things blow up relatively easily on error.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-08-27 16:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 12:29 [PATCH v2 0/4] ASoC: mediatek: mt8183: Fix clock error handling phucduc.bui
2026-08-21 12:29 ` [PATCH v2 1/4] ASoC: mediatek: mt8183: Fix wrong clock cleanup on clk_set_parent() failure phucduc.bui
2026-08-26 18:40 ` Cezary Rojewski
2026-08-21 12:29 ` [PATCH v2 2/4] ASoC: mediatek: mt8183: Fix APLL enable error handling phucduc.bui
2026-08-26 18:31 ` Cezary Rojewski
2026-08-27 7:58 ` Bui Duc Phuc
2026-08-27 16:28 ` Mark Brown [this message]
2026-08-28 4:13 ` Bui Duc Phuc
2026-08-21 12:29 ` [PATCH v2 3/4] ASoC: mediatek: mt8183: Use dev_err_probe() for " phucduc.bui
2026-08-26 18:32 ` Cezary Rojewski
2026-08-21 12:29 ` [PATCH v2 4/4] ASoC: mediatek: mt8183: Drop redundant probe error messages phucduc.bui
2026-08-26 18:33 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98b11d2d-8157-4c1b-8562-42ff11cdff60@sirena.org.uk \
--to=broonie@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=cezary.rojewski@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=phucduc.bui@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox