linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@mailbox.org>
To: Sudeep Holla <sudeep.holla@arm.com>,
	Marek Vasut <marek.vasut+renesas@mailbox.org>
Cc: arm-scmi@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
	Cristian Marussi <cristian.marussi@arm.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: firmware: arm,scmi: Document arm,poll-transport property
Date: Thu, 23 Oct 2025 15:57:51 +0200	[thread overview]
Message-ID: <98ce2726-ab58-447a-bcb5-23b6347fa4fb@mailbox.org> (raw)
In-Reply-To: <20251023-active-blue-collie-2978ea@sudeepholla>

On 10/23/25 3:42 PM, Sudeep Holla wrote:

Hello Sudeep,

>>> diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
>>> index be817fd9cc34b..b53754a318ea1 100644
>>> --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
>>> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
>>> @@ -146,6 +146,13 @@ properties:
>>>         this platform. If set, the value should be non-zero.
>>>       minimum: 1
>>>   
>>> +  arm,poll-transport:
>>> +    type: boolean
>>> +    description:
>>> +      An optional property which unconditionally forces polling in all transports.
>>> +      This is mainly mean to work around uncooperative SCP, which does not generate
>>> +      completion interrupts.
>>> +
>>
>> Could you please clarify which platform and transport this change pertains to?
>>
>> Introducing a property that enforces unconditional polling across all
>> platforms is not ideal - particularly if this is intended as a workaround
>> for a platform- or firmware- specific issue. Such implementations often get
>> replicated across platforms without addressing the root cause, leading to
>> wider inconsistencies.
>>
> 
> Just to clarify what I mean by "enforces unconditional polling" is with the
> added DT property only. I understand this is new property and it much be
> present in DT to enforce polling, but it can be misused initially for testing
> in absence of interrupt support and forgotten in DT. Hence my concern.

I would argue about the "mis" part of "misused" . It can be both "used" 
and "misused". I can add stronger warning into the description ?

-- 
Best regards,
Marek Vasut


  reply	other threads:[~2025-10-23 13:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-23 12:35 [PATCH 1/2] dt-bindings: firmware: arm,scmi: Document arm,poll-transport property Marek Vasut
2025-10-23 12:35 ` [PATCH 2/2] firmware: arm_scmi: Implement " Marek Vasut
2025-10-23 13:07 ` [PATCH 1/2] dt-bindings: firmware: arm,scmi: Document " Geert Uytterhoeven
2025-10-23 13:19   ` Marek Vasut
2025-10-23 13:16 ` Sudeep Holla
2025-10-23 13:42   ` Marek Vasut
2025-10-23 14:30     ` Cristian Marussi
2025-10-23 14:36       ` Marek Vasut
2025-10-23 14:36     ` Sudeep Holla
2025-10-23 14:47       ` Marek Vasut
2025-10-23 13:42   ` Sudeep Holla
2025-10-23 13:57     ` Marek Vasut [this message]
2025-10-23 13:45 ` Cristian Marussi
2025-10-23 14:00   ` Marek Vasut
2025-10-30  0:52     ` Marek Vasut
2025-11-13 11:03       ` Cristian Marussi
2025-11-13 11:34         ` Marek Vasut
2025-11-14  7:21         ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98ce2726-ab58-447a-bcb5-23b6347fa4fb@mailbox.org \
    --to=marek.vasut@mailbox.org \
    --cc=arm-scmi@vger.kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cristian.marussi@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=robh@kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).