From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA38BC6FD1F for ; Tue, 2 Apr 2024 23:23:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v8APp6hFVUU1VoV5byyT4SrPMAkTOT/oQZwXBnQnjJs=; b=E0Z4FHlWC1daM6 GhdI93LUFJRvYT2le8jWEeJ1wzU7A/ZOAVvjf3utEdLgGvsXhyXq6/5CWbFVoklEuS5Toovz3lbma rmPdXLHmSLEXNYuYZvph6Lm/SVfAsIpt2J6eik2oyPnGOyZxlFXFUK37T18j8SrGKDPB2NwU3wMgD 17NTxtqiQgB+T6BclZepelVuUZM+nlR8XqojhpVl5dGncFRhErOL+Sua1wasplzjUAuafqVzfdgzp S4oGZ6pCUKKpaJuyZc58YDY1/i5UEkjGrevkULbKmLHqD8kF+0H37tdJ4VLIVMXjrHxorrQJiWdCs 2blP5c48HoAey5raJ1aA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrnTR-0000000D9nN-03qd; Tue, 02 Apr 2024 23:23:25 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrnTN-0000000D9ly-405G; Tue, 02 Apr 2024 23:23:23 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D56F2CE1E66; Tue, 2 Apr 2024 23:23:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F930C433C7; Tue, 2 Apr 2024 23:23:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712100199; bh=MeLS86YdjnIzGiuXPd5GfJyCavX2wucsvi48OLJIDeY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iDClBlzz9+EtddVYkNAHFxMOaJoQnATld9xN8+G7AiRLrW7spNjrDNZM/uicl1gNC /4s+WZzVoGUN+ZuUz4LGB4ROWhXkjWQizKYDFkZf+cAe1AKNQFgXsDfosJpa0agVxB M5o8dcwAboK6CVcg9uHI7lQ/hN/0aWqMXTdhsK+mcGDXMyKCtQ523hcjTqPEkkJzt2 QsW3JK5SlE5/vyEPltNDECa01GNs189lB/+aCOMZHnHE45q1l/ZlMzWKwP0ybKiXww MK/AsqJ5mpzh8pdRZ12QUp3pV5t8X8m/qbI2RMyDqYR6uPKZIcqHoIE91YuDIw/zuD gU/YCoT6iYU9A== Message-ID: <992dcef1-00d3-456c-b3ee-253ab475f0cf@kernel.org> Date: Wed, 3 Apr 2024 08:23:15 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 17/18] dt-bindings: pci: rockchip,rk3399-pcie-ep: Add ep-gpios property To: Krzysztof Kozlowski , Manivannan Sadhasivam , Lorenzo Pieralisi , Kishon Vijay Abraham I , Shawn Lin , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Rick Wertenbroek , Wilfred Mallawa , Niklas Cassel References: <20240330041928.1555578-1-dlemoal@kernel.org> <20240330041928.1555578-18-dlemoal@kernel.org> <518f04ea-7ff6-4568-be76-60276d18b209@linaro.org> <49ecab2e-8f36-47be-a1b0-1bb0089dab0f@kernel.org> <57d5d6ea-5fef-423c-9f85-5f295bfa4c5f@linaro.org> <80c4c37b-8c5c-4628-a455-fcccfc3b3730@kernel.org> <65b6329a-643c-4adf-9137-281964865d51@linaro.org> Content-Language: en-US From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <65b6329a-643c-4adf-9137-281964865d51@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_162322_290870_FE46708F X-CRM114-Status: GOOD ( 16.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/3/24 03:10, Krzysztof Kozlowski wrote: >> Thinking more about this, I think moving the ep-gpios description to the common >> schema is the right thing to do given that the driver uses common code between >> RC and EP to get that property. But if that is not acceptable, I can rename it >> and get that property in the controller EP mode initialization code. That will >> be add a little more code in the driver. > > I forgot that it is actually the same hardware, so if host has > "ep-gpios" already then EP mode should have the same property. Common > schema is good idea. OK. But this will conflict with the patch you sent to add the missing maxItem. Is that patch a fix or is it for 6.10 ? If it is the former, I can wait for next week to rebase on rc3 and avoid a conflict. > > > Best regards, > Krzysztof > -- Damien Le Moal Western Digital Research _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel