From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 862DCECAAA3 for ; Fri, 26 Aug 2022 10:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:Subject:From:References:Cc:To: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JhGfrZWZepjrElG4EAvfWTRVwYU3C6HUUnRqfb5XZMw=; b=QrbJcJwL8FTXI/ O2y+3KphEEQiZPNJI60C8suD4YufL5jIILusTtYw4z5IYJgN9e2xBxvq12IY0Opq9df4WLFnwXbMc Ba3/vA1W2IntSa4yJ3iq7kkA4QtWdaO/FWOc9KS2qp+Zq9Y69rsp1XTNrNXk+31y9FiYRNtsUY7qE UdlD8EQW7OblFMNsMDgb8/n6vNLpzhwKVMZ8uaJqonvu4mKfy0faHgGBUeIGuQ82h/trvAnMYqgQA 1epTZqfgVUthF5bgWIT8S0h87ky41tFwaE8elTEx9uIyW9c3piXvGjTL58b7cGUAnySTzPIgnikE9 P6b0+YxYMJoGc9dF3qkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRX2r-001kBu-MP; Fri, 26 Aug 2022 10:58:37 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRX2o-001k8D-5N for linux-arm-kernel@lists.infradead.org; Fri, 26 Aug 2022 10:58:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661511512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jMnbTKtNSpTsqq0eZVxc5+MQ+KePmpUNSlwTet2oL2k=; b=DLRI9UhIdD8KBQJWMEPkUr6URwU6A8cazI1uL3707bJd7EQctIhZb1M+rZ4nfRLw0a6NRe JeR5Ilg3uH2Ban3A7hj3OCIOreVgR9qS/RS5bF94clL4gqMwSWxpOvlzY7GwAgFIz6Qegr Dyo4RnwltgAAL4tYqmwKvlD/7u89idQ= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-655-LX1_2EBkPpSnSHHcmKR6SQ-1; Fri, 26 Aug 2022 06:58:29 -0400 X-MC-Unique: LX1_2EBkPpSnSHHcmKR6SQ-1 Received: by mail-ej1-f72.google.com with SMTP id qa35-20020a17090786a300b0073d4026a97dso475296ejc.9 for ; Fri, 26 Aug 2022 03:58:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=jMnbTKtNSpTsqq0eZVxc5+MQ+KePmpUNSlwTet2oL2k=; b=sY1L/M2BeI8Ea9lwk916+OzWl40xci6u9EVa9hzLrMyH/XcYRpUr03ocbu+LFCBLnU mxgS27klOJKAnPiftDEZZiruvDc7Tm0wVNhKMjC4c1YtusbqZ5reWwLfel/G42rysqo6 uyjNht9WWhkVgGaltdzD/8PQPh6el2DvJ88FESW0ElDTrpwmYC2tkpQQLFCL6mJkBKmv 2FFllHjw1Q0a1tWmcIymc4TAKiScTvJ4NvoClKu47KRT0RXrGXYB3/J/kj/hsa9jDZNg NdxMqf3dN8JeoROtDvHsDlVwR4hPwhHHfPRRSBIrAXDcdppBF0NIgd2n0ZpWVBkQx7Qp vReA== X-Gm-Message-State: ACgBeo3hrbuYlJj7GYqK94xYT/2ipBY5sSmx1awQtRoMPTv8FFGQUgga +0ZS7Vfslwr0NRQVlHDC2OYx8tANAV/lkYPiTX6+miE/Oj+2fXNkywuWT0gYdiDBsQYThEw0hWM /COmarb8Xe5qOx+qSxPLT3/79rNo4tA4NvQY= X-Received: by 2002:a05:6402:5150:b0:447:933d:ec65 with SMTP id n16-20020a056402515000b00447933dec65mr6212676edd.80.1661511508657; Fri, 26 Aug 2022 03:58:28 -0700 (PDT) X-Google-Smtp-Source: AA6agR4J7blDIUmOh5lFPHJwf/tJLIYkgJgvljjD4T11ziyn6v4vnxonXD5Bpxyrz7ntlO6vhSx/Hw== X-Received: by 2002:a05:6402:5150:b0:447:933d:ec65 with SMTP id n16-20020a056402515000b00447933dec65mr6212653edd.80.1661511508460; Fri, 26 Aug 2022 03:58:28 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id p17-20020a50cd91000000b004479cec6496sm1102859edi.75.2022.08.26.03.58.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Aug 2022 03:58:27 -0700 (PDT) Message-ID: <99364855-b4e9-8a69-e1ca-ed09d103e4c8@redhat.com> Date: Fri, 26 Aug 2022 12:58:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 To: Marc Zyngier , Oliver Upton Cc: Gavin Shan , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, peterx@redhat.com, corbet@lwn.net, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, shuah@kernel.org, seanjc@google.com, drjones@redhat.com, dmatlack@google.com, bgardon@google.com, ricarkol@google.com, zhenyzha@redhat.com, shan.gavin@gmail.com References: <20220819005601.198436-1-gshan@redhat.com> <20220819005601.198436-2-gshan@redhat.com> <87lerkwtm5.wl-maz@kernel.org> <41fb5a1f-29a9-e6bb-9fab-4c83a2a8fce5@redhat.com> <87fshovtu0.wl-maz@kernel.org> <87a67uwve8.wl-maz@kernel.org> From: Paolo Bonzini Subject: Re: [PATCH v1 1/5] KVM: arm64: Enable ring-based dirty memory tracking In-Reply-To: <87a67uwve8.wl-maz@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220826_035834_303206_ABE05AED X-CRM114-Status: UNSURE ( 9.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/23/22 22:35, Marc Zyngier wrote: >> Heh, yeah I need to get that out the door. I'll also note that Gavin's >> changes are still relevant without that series, as we do write unprotect >> in parallel at PTE granularity after commit f783ef1c0e82 ("KVM: arm64: >> Add fast path to handle permission relaxation during dirty logging"). > > Ah, true. Now if only someone could explain how the whole > producer-consumer thing works without a trace of a barrier, that'd be > great... Do you mean this? void kvm_dirty_ring_push(struct kvm_dirty_ring *ring, u32 slot, u64 offset) { struct kvm_dirty_gfn *entry; /* It should never get full */ WARN_ON_ONCE(kvm_dirty_ring_full(ring)); entry = &ring->dirty_gfns[ring->dirty_index & (ring->size - 1)]; entry->slot = slot; entry->offset = offset; /* * Make sure the data is filled in before we publish this to * the userspace program. There's no paired kernel-side reader. */ smp_wmb(); kvm_dirty_gfn_set_dirtied(entry); ring->dirty_index++; trace_kvm_dirty_ring_push(ring, slot, offset); } The matching smp_rmb() is in userspace. Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel