From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 837AFCD6136 for ; Mon, 9 Oct 2023 20:21:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0KxQk76XL4gVbIibpQJkf7lYEtT4/716vr0dHhGnpzA=; b=uY65TFR6eaol5p 9tqxQcDLMDs9QRb3kVkQQuVng6oDhrTo5HLRyQKHGu/VUQAM0e/oGnwj+AF1HEW+qD8uB+QpTgm3+ PyO22tOtjzDNQGU3t3VpuDVucrcxrixIE3/nEdT5Z8Ge9k80o/UweBToV38ffondX6ovDJgRRRyeb YyJzyUDURgXfkDzBRHtQ/2feZI9S6zv5rPV8vRfuyzhI0ilebBnv3gf9yndRMgR/RacjJum1yyvlw P4ShhVREfJN8SiY2lXaw//pBH6qCixAN2EomrqF+sXuo1W5UXhCXJ4dYL9z/dCH/rrQX7fmHLmRrP aFv2GORCpE10OROBtkWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qpwkI-00BZQF-1A; Mon, 09 Oct 2023 20:20:54 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qpwkF-00BZPe-10 for linux-arm-kernel@lists.infradead.org; Mon, 09 Oct 2023 20:20:53 +0000 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1c5db4925f9so36272235ad.1 for ; Mon, 09 Oct 2023 13:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696882847; x=1697487647; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kpg72YaeEbhD8qqGKD/9GLa/AWvasFLObLtVomu/POM=; b=nl5CpOiByn0afOETT4PCdJVeotOGDDoD0xAumNqc0lZHrqTU+rpKXJpN3IhSegeN7V fV8+S78KKRY7wbJy4Ah6VGeZdD/2Z1ObXpxaSpHWfnPlK6uKVo/c40qN2gw8/e0B+ooD whHYu4VeDeRiWNcgPfjxzC3u3wQFaJjhWiv5t/11DwP0Cc8h4ELfLpSsadlILvwg+WXi YkP9G5xRVCUFNHSfChdMTPx1NJ3279jh+TBGFyRce+aouRrfSBsxaTgwyNocBv5G3w56 jnapW4R+c8TkTEuN6qnK+qZTLrUWvx+XiI3IzyXLSdHeJPjBAHObA0MaYqSQXrptqszT 0tjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696882847; x=1697487647; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kpg72YaeEbhD8qqGKD/9GLa/AWvasFLObLtVomu/POM=; b=LcrfZWUUxnsX+I48IBqu6622xQ9I0ijwJrncBAF6cHxlLf+cJCNOvVYpAnB5N1M/XX hovkHzCxK0tFdkB5Zc9YIg9zEdRBKd4wMPqp2lLbquOCJ2/kz1bGNQjR+l9RzJgijVHP vIKBfS02SvWeJT84SRFrKxKRGpgX8ZoDLNvW2Xzovf7A8Uu2RkM0ylCCrcbfsnB6ap4p artNecJPZgjeQTw8mj016Sg1B8914iBJA/K3c3FljL30uRhTMDeBzFXbK6cDZJTEiVNq LgfI1TAh7YMOemjvj75yWJVvjcHMQTp4gFEI56ZbiQzOG3rSznLbXNGRS9vlhx2ii+k5 z5rg== X-Gm-Message-State: AOJu0YyifoX4pG/n6++OURebwM5ySm2rdDqtebJy21JYV5E+7waLBKtH H+MXnWdoBMtlWuiTbdLprRg= X-Google-Smtp-Source: AGHT+IHXSQqFwyjCffsAEU9BeiEBGB1exh4hMwYC5bQyXYsrHD8qEI50+FFMYhcbkR/s2GpQ6zMjlw== X-Received: by 2002:a17:902:db11:b0:1c3:432f:9f69 with SMTP id m17-20020a170902db1100b001c3432f9f69mr23329345plx.23.1696882846684; Mon, 09 Oct 2023 13:20:46 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id d11-20020a170902cecb00b001c73d829fb7sm10098259plg.15.2023.10.09.13.20.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Oct 2023 13:20:40 -0700 (PDT) Message-ID: <995341e0-d2d7-451e-bd8b-0741cb98bcff@gmail.com> Date: Mon, 9 Oct 2023 13:20:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v7 3/3] net: axienet: Introduce dmaengine support Content-Language: en-US To: Radhey Shyam Pandey , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, michal.simek@amd.com, linux@armlinux.org.uk Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, git@amd.com References: <1695843151-1919509-1-git-send-email-radhey.shyam.pandey@amd.com> <1695843151-1919509-4-git-send-email-radhey.shyam.pandey@amd.com> From: Florian Fainelli In-Reply-To: <1695843151-1919509-4-git-send-email-radhey.shyam.pandey@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231009_132051_373580_6F9C1F94 X-CRM114-Status: GOOD ( 16.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/27/23 12:32, Radhey Shyam Pandey wrote: > Add dmaengine framework to communicate with the xilinx DMAengine > driver(AXIDMA). > > Axi ethernet driver uses separate channels for transmit and receive. > Add support for these channels to handle TX and RX with skb and > appropriate callbacks. Also add axi ethernet core interrupt for > dmaengine framework support. > > The dmaengine framework was extended for metadata API support. > However it still needs further enhancements to make it well suited for > ethernet usecases. The ethernet features i.e ethtool set/get of DMA IP > properties, ndo_poll_controller,(mentioned in TODO) are not supported > and it requires follow-up discussions. > > dmaengine support has a dependency on xilinx_dma as it uses > xilinx_vdma_channel_set_config() API to reset the DMA IP > which internally reset MAC prior to accessing MDIO. > > Benchmark with netperf: > > xilinx-zcu102-20232:~$ netperf -H 192.168.10.20 -t TCP_STREAM > MIGRATED TCP STREAM TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET > to 192.168.10.20 () port 0 AF_INET > Recv Send Send > Socket Socket Message Elapsed > Size Size Size Time Throughput > bytes bytes bytes secs. 10^6bits/sec > > 131072 16384 16384 10.03 915.55 > > xilinx-zcu102-20232:~$ netperf -H 192.168.10.20 -t UDP_STREAM > MIGRATED UDP STREAM TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET > to 192.168.10.20 () port 0 AF_INET > Socket Message Elapsed Messages > Size Size Time Okay Errors Throughput > bytes bytes secs # # 10^6bits/sec > > 212992 65507 10.00 18192 0 953.35 > 212992 10.00 18192 953.35 > > Signed-off-by: Radhey Shyam Pandey > --- [snip] > /** > * axienet_tx_poll - Invoked once a transmit is completed by the > * Axi DMA Tx channel. > @@ -911,7 +1036,43 @@ axienet_start_xmit(struct sk_buff *skb, struct net_device *ndev) > if (!lp->use_dmaengine) > return axienet_start_xmit_legacy(skb, ndev); > else > - return NETDEV_TX_BUSY; > + return axienet_start_xmit_dmaengine(skb, ndev); Did not notice this before, but should consider using a separate set of net_device_ops with a different ndo_start_xmit() implementation, rather than add another layer of indirection here. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel