Re: [PATCH v7 1/2] perf: Fujitsu: Add the Uncore MAC PMU driver

Jonathan Cameron
2025-08-15T17:30:28Z

> > +static struct attribute *fujitsu_mac_pmu_events[] = {
> > + MAC_EVENT_ATTR(cycles, MAC_EVENT_CYCLES),
> > + MAC_EVENT_ATTR(read-count, MAC_EVENT_READ_COUNT),
> > + MAC_EVENT_ATTR(read-count-request, MAC_EVENT_READ_COUNT_REQUEST),
> > + MAC_EVENT_ATTR(read-count-return, MAC_EVENT_READ_COUNT_RETURN),
> > + MAC_EVENT_ATTR(read-count-request-pftgt, MAC_EVENT_READ_COUNT_REQUEST_PFTGT),
> > + MAC_EVENT_ATTR(read-count-request-normal, MAC_EVENT_READ_COUNT_REQUEST_NORMAL),
> > + MAC_EVENT_ATTR(read-count-return-pftgt-hit, MAC_EVENT_READ_COUNT_RETURN_PFTGT_HIT),
> > + MAC_EVENT_ATTR(read-count-return-pftgt-miss, MAC_EVENT_READ_COUNT_RETURN_PFTGT_MISS),
> > + MAC_EVENT_ATTR(read-wait, MAC_EVENT_READ_WAIT),
> > + MAC_EVENT_ATTR(write-count, MAC_EVENT_WRITE_COUNT),
> > + MAC_EVENT_ATTR(write-count-write, MAC_EVENT_WRITE_COUNT_WRITE),
> > + MAC_EVENT_ATTR(write-count-pwrite, MAC_EVENT_WRITE_COUNT_PWRITE),
> > + MAC_EVENT_ATTR(memory-read-count, MAC_EVENT_MEMORY_READ_COUNT),
> > + MAC_EVENT_ATTR(memory-write-count, MAC_EVENT_MEMORY_WRITE_COUNT),
> > + MAC_EVENT_ATTR(memory-pwrite-count, MAC_EVENT_MEMORY_PWRITE_COUNT),
> > + MAC_EVENT_ATTR(ea-mac, MAC_EVENT_EA_MAC),
> > + MAC_EVENT_ATTR(ea-memory, MAC_EVENT_EA_MEMORY),
> > + MAC_EVENT_ATTR(ea-memory-mac-write, MAC_EVENT_EA_MEMORY_MAC_WRITE),
> > + MAC_EVENT_ATTR(ea-ha, MAC_EVENT_EA_HA),
> I firmly maintain my opinion that if this is the only place the event
> numbers are referenced then the extra layer of macros actually makes it
> *harder* to read and follow, compared to simply:
>
> MAC_EVENT_ATTR(ea-ha, 0xa0),
>
> but that is very much just one reviewer's personal opinion :)

I'll second this suggestion! I failed to notice they were only used here.

Jonathan