* [PATCH] dt-bindings: clock: Add SAMA7D65 PMC compatible string
@ 2024-08-29 9:38 Dharma Balasubiramani
2024-08-29 14:10 ` Alexandre Belloni
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Dharma Balasubiramani @ 2024-08-29 9:38 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Nicolas Ferre, Alexandre Belloni, Claudiu Beznea
Cc: linux-clk, devicetree, linux-arm-kernel, linux-kernel,
Dharma Balasubiramani
Add the `microchip,sama7d65-pmc` compatible string to the existing binding,
since the SAMA7D65 PMC shares the same properties and clock requirements
as the SAMA7G5.
Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
---
Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
index c9eb60776b4d..885d47dd5724 100644
--- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
+++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
@@ -43,6 +43,7 @@ properties:
- atmel,sama5d4-pmc
- microchip,sam9x60-pmc
- microchip,sam9x7-pmc
+ - microchip,sama7d65-pmc
- microchip,sama7g5-pmc
- const: syscon
@@ -90,6 +91,7 @@ allOf:
enum:
- microchip,sam9x60-pmc
- microchip,sam9x7-pmc
+ - microchip,sama7d65-pmc
- microchip,sama7g5-pmc
then:
properties:
---
base-commit: b18bbfc14a38b5234e09c2adcf713e38063a7e6e
change-id: 20240829-sama7d65-next-a91d089b56a3
Best regards,
--
Dharma Balasubiramani <dharma.b@microchip.com>
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: clock: Add SAMA7D65 PMC compatible string
2024-08-29 9:38 [PATCH] dt-bindings: clock: Add SAMA7D65 PMC compatible string Dharma Balasubiramani
@ 2024-08-29 14:10 ` Alexandre Belloni
2024-08-29 14:42 ` Nicolas Ferre
2024-08-29 16:14 ` Conor Dooley
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Alexandre Belloni @ 2024-08-29 14:10 UTC (permalink / raw)
To: Dharma Balasubiramani
Cc: Rob Herring, Conor Dooley, devicetree, Stephen Boyd, linux-kernel,
Michael Turquette, Claudiu Beznea, Krzysztof Kozlowski, linux-clk,
linux-arm-kernel
On 29/08/2024 15:08:45+0530, Dharma Balasubiramani wrote:
> Add the `microchip,sama7d65-pmc` compatible string to the existing binding,
> since the SAMA7D65 PMC shares the same properties and clock requirements
> as the SAMA7G5.
Shouldn't you rather use a fallback if you currently have no driver
change?
>
> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
> ---
> Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
> index c9eb60776b4d..885d47dd5724 100644
> --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
> +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
> @@ -43,6 +43,7 @@ properties:
> - atmel,sama5d4-pmc
> - microchip,sam9x60-pmc
> - microchip,sam9x7-pmc
> + - microchip,sama7d65-pmc
> - microchip,sama7g5-pmc
> - const: syscon
>
> @@ -90,6 +91,7 @@ allOf:
> enum:
> - microchip,sam9x60-pmc
> - microchip,sam9x7-pmc
> + - microchip,sama7d65-pmc
> - microchip,sama7g5-pmc
> then:
> properties:
>
> ---
> base-commit: b18bbfc14a38b5234e09c2adcf713e38063a7e6e
> change-id: 20240829-sama7d65-next-a91d089b56a3
>
> Best regards,
> --
> Dharma Balasubiramani <dharma.b@microchip.com>
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: clock: Add SAMA7D65 PMC compatible string
2024-08-29 14:10 ` Alexandre Belloni
@ 2024-08-29 14:42 ` Nicolas Ferre
2024-08-31 13:37 ` Krzysztof Kozlowski
0 siblings, 1 reply; 8+ messages in thread
From: Nicolas Ferre @ 2024-08-29 14:42 UTC (permalink / raw)
To: Alexandre Belloni, Dharma Balasubiramani
Cc: Michael Turquette, Stephen Boyd, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Claudiu Beznea, linux-clk, devicetree,
linux-arm-kernel, linux-kernel
Alexandre,
On 29/08/2024 at 16:10, Alexandre Belloni wrote:
> On 29/08/2024 15:08:45+0530, Dharma Balasubiramani wrote:
>> Add the `microchip,sama7d65-pmc` compatible string to the existing binding,
>> since the SAMA7D65 PMC shares the same properties and clock requirements
>> as the SAMA7G5.
>
> Shouldn't you rather use a fallback if you currently have no driver
> change?
The clock/pmc driver is (will be) different. Only the binding of the PMC
uses the same properties and clocks specification as our recent SoCs (so
can be added to the "enum").
Regards,
Nicolas
>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
>> ---
>> Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>> index c9eb60776b4d..885d47dd5724 100644
>> --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>> @@ -43,6 +43,7 @@ properties:
>> - atmel,sama5d4-pmc
>> - microchip,sam9x60-pmc
>> - microchip,sam9x7-pmc
>> + - microchip,sama7d65-pmc
>> - microchip,sama7g5-pmc
>> - const: syscon
>>
>> @@ -90,6 +91,7 @@ allOf:
>> enum:
>> - microchip,sam9x60-pmc
>> - microchip,sam9x7-pmc
>> + - microchip,sama7d65-pmc
>> - microchip,sama7g5-pmc
>> then:
>> properties:
>>
>> ---
>> base-commit: b18bbfc14a38b5234e09c2adcf713e38063a7e6e
>> change-id: 20240829-sama7d65-next-a91d089b56a3
>>
>> Best regards,
>> --
>> Dharma Balasubiramani <dharma.b@microchip.com>
>>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: clock: Add SAMA7D65 PMC compatible string
2024-08-29 9:38 [PATCH] dt-bindings: clock: Add SAMA7D65 PMC compatible string Dharma Balasubiramani
2024-08-29 14:10 ` Alexandre Belloni
@ 2024-08-29 16:14 ` Conor Dooley
2024-08-31 13:32 ` claudiu beznea
2024-09-05 15:18 ` Nicolas Ferre
3 siblings, 0 replies; 8+ messages in thread
From: Conor Dooley @ 2024-08-29 16:14 UTC (permalink / raw)
To: Dharma Balasubiramani
Cc: Rob Herring, Conor Dooley, Alexandre Belloni, devicetree,
Stephen Boyd, linux-kernel, Michael Turquette, Claudiu Beznea,
Krzysztof Kozlowski, linux-clk, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 370 bytes --]
On Thu, Aug 29, 2024 at 03:08:45PM +0530, Dharma Balasubiramani wrote:
> Add the `microchip,sama7d65-pmc` compatible string to the existing binding,
> since the SAMA7D65 PMC shares the same properties and clock requirements
> as the SAMA7G5.
>
> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: clock: Add SAMA7D65 PMC compatible string
2024-08-29 9:38 [PATCH] dt-bindings: clock: Add SAMA7D65 PMC compatible string Dharma Balasubiramani
2024-08-29 14:10 ` Alexandre Belloni
2024-08-29 16:14 ` Conor Dooley
@ 2024-08-31 13:32 ` claudiu beznea
2024-09-05 15:18 ` Nicolas Ferre
3 siblings, 0 replies; 8+ messages in thread
From: claudiu beznea @ 2024-08-31 13:32 UTC (permalink / raw)
To: Dharma Balasubiramani, Michael Turquette, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Nicolas Ferre,
Alexandre Belloni
Cc: linux-clk, devicetree, linux-arm-kernel, linux-kernel
On 29.08.2024 12:38, Dharma Balasubiramani wrote:
> Add the `microchip,sama7d65-pmc` compatible string to the existing binding,
> since the SAMA7D65 PMC shares the same properties and clock requirements
> as the SAMA7G5.
Looks a bit odd to me to publish bindings and driver chances by 2 different
people, at exactly the same time. Maybe coordinate and publish it together
(at least for the future).
Other than this:
Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
>
> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
> ---
> Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
> index c9eb60776b4d..885d47dd5724 100644
> --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
> +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
> @@ -43,6 +43,7 @@ properties:
> - atmel,sama5d4-pmc
> - microchip,sam9x60-pmc
> - microchip,sam9x7-pmc
> + - microchip,sama7d65-pmc
> - microchip,sama7g5-pmc
> - const: syscon
>
> @@ -90,6 +91,7 @@ allOf:
> enum:
> - microchip,sam9x60-pmc
> - microchip,sam9x7-pmc
> + - microchip,sama7d65-pmc
> - microchip,sama7g5-pmc
> then:
> properties:
>
> ---
> base-commit: b18bbfc14a38b5234e09c2adcf713e38063a7e6e
> change-id: 20240829-sama7d65-next-a91d089b56a3
>
> Best regards,
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: clock: Add SAMA7D65 PMC compatible string
2024-08-29 14:42 ` Nicolas Ferre
@ 2024-08-31 13:37 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-31 13:37 UTC (permalink / raw)
To: Nicolas Ferre, Alexandre Belloni, Dharma Balasubiramani
Cc: Michael Turquette, Stephen Boyd, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Claudiu Beznea, linux-clk, devicetree,
linux-arm-kernel, linux-kernel
On 29/08/2024 16:42, Nicolas Ferre wrote:
> Alexandre,
>
> On 29/08/2024 at 16:10, Alexandre Belloni wrote:
>> On 29/08/2024 15:08:45+0530, Dharma Balasubiramani wrote:
>>> Add the `microchip,sama7d65-pmc` compatible string to the existing binding,
>>> since the SAMA7D65 PMC shares the same properties and clock requirements
>>> as the SAMA7G5.
>>
>> Shouldn't you rather use a fallback if you currently have no driver
>> change?
>
> The clock/pmc driver is (will be) different. Only the binding of the PMC
> uses the same properties and clocks specification as our recent SoCs (so
> can be added to the "enum").
I don't understand this patch. The binding without any users makes no
sense. For bindings without drivers, I understand you send it in
parallel from the DTS. But this one here will have a driver, right? In
such case IT MUST GO with the driver.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: clock: Add SAMA7D65 PMC compatible string
2024-08-29 9:38 [PATCH] dt-bindings: clock: Add SAMA7D65 PMC compatible string Dharma Balasubiramani
` (2 preceding siblings ...)
2024-08-31 13:32 ` claudiu beznea
@ 2024-09-05 15:18 ` Nicolas Ferre
2024-09-05 15:53 ` Krzysztof Kozlowski
3 siblings, 1 reply; 8+ messages in thread
From: Nicolas Ferre @ 2024-09-05 15:18 UTC (permalink / raw)
To: Dharma Balasubiramani, Michael Turquette, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alexandre Belloni,
Claudiu Beznea
Cc: linux-clk, devicetree, linux-arm-kernel, linux-kernel
On 29/08/2024 at 11:38, Dharma Balasubiramani wrote:
> Add the `microchip,sama7d65-pmc` compatible string to the existing binding,
> since the SAMA7D65 PMC shares the same properties and clock requirements
> as the SAMA7G5.
>
> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
For the record, driver addition is here:
v1:
https://lore.kernel.org/linux-arm-kernel/cover.1724948760.git.Ryan.Wanner@microchip.com/
v2:
https://lore.kernel.org/linux-arm-kernel/cover.1725392645.git.Ryan.Wanner@microchip.com/
Best regards,
Nicolas
> ---
> Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
> index c9eb60776b4d..885d47dd5724 100644
> --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
> +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
> @@ -43,6 +43,7 @@ properties:
> - atmel,sama5d4-pmc
> - microchip,sam9x60-pmc
> - microchip,sam9x7-pmc
> + - microchip,sama7d65-pmc
> - microchip,sama7g5-pmc
> - const: syscon
>
> @@ -90,6 +91,7 @@ allOf:
> enum:
> - microchip,sam9x60-pmc
> - microchip,sam9x7-pmc
> + - microchip,sama7d65-pmc
> - microchip,sama7g5-pmc
> then:
> properties:
>
> ---
> base-commit: b18bbfc14a38b5234e09c2adcf713e38063a7e6e
> change-id: 20240829-sama7d65-next-a91d089b56a3
>
> Best regards,
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: clock: Add SAMA7D65 PMC compatible string
2024-09-05 15:18 ` Nicolas Ferre
@ 2024-09-05 15:53 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-09-05 15:53 UTC (permalink / raw)
To: Nicolas Ferre, Dharma Balasubiramani, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alexandre Belloni, Claudiu Beznea
Cc: linux-clk, devicetree, linux-arm-kernel, linux-kernel
On 05/09/2024 17:18, Nicolas Ferre wrote:
> On 29/08/2024 at 11:38, Dharma Balasubiramani wrote:
>> Add the `microchip,sama7d65-pmc` compatible string to the existing binding,
>> since the SAMA7D65 PMC shares the same properties and clock requirements
>> as the SAMA7G5.
>>
>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
>
> For the record, driver addition is here:
> v1:
> https://lore.kernel.org/linux-arm-kernel/cover.1724948760.git.Ryan.Wanner@microchip.com/
>
> v2:
> https://lore.kernel.org/linux-arm-kernel/cover.1725392645.git.Ryan.Wanner@microchip.com/
>
Sending driver separately from the binding means there are warnings of
undocumented compatibles. Submitting bindings also documents this. This
must be one patchset.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-09-05 15:56 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-29 9:38 [PATCH] dt-bindings: clock: Add SAMA7D65 PMC compatible string Dharma Balasubiramani
2024-08-29 14:10 ` Alexandre Belloni
2024-08-29 14:42 ` Nicolas Ferre
2024-08-31 13:37 ` Krzysztof Kozlowski
2024-08-29 16:14 ` Conor Dooley
2024-08-31 13:32 ` claudiu beznea
2024-09-05 15:18 ` Nicolas Ferre
2024-09-05 15:53 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).