From: Claudiu Beznea <claudiu.beznea@tuxon.dev>
To: Mihai Sain <mihai.sain@microchip.com>,
mturquette@baylibre.com, sboyd@kernel.org,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
varshini.rajendran@microchip.com, cristian.birsan@microchip.com,
balamanikandan.gunasundar@microchip.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
ryan.wanner@microchip.com
Subject: Re: [PATCH v2 1/4] clk: at91: sam9x7: Remove gmac peripheral and generic clock entries with ID 67
Date: Sat, 28 Feb 2026 16:22:21 +0200 [thread overview]
Message-ID: <9965d2fb-e1ee-4103-a5d3-01cb94468db0@tuxon.dev> (raw)
In-Reply-To: <20260212100147.5007-2-mihai.sain@microchip.com>
Hi, Mihai,
On 2/12/26 12:01, Mihai Sain wrote:
> According with datasheet table 12.1 the instance ID 67 is reserved.
Could you please mention the datasheet revision ID?
> This change drops the gmactsu_clk and gmac_gclk entries from
> the SAM9X7 clock description tables.
>
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> ---
> drivers/clk/at91/sam9x7.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/clk/at91/sam9x7.c b/drivers/clk/at91/sam9x7.c
> index 89868a0aeaba..d9603f1124d0 100644
> --- a/drivers/clk/at91/sam9x7.c
> +++ b/drivers/clk/at91/sam9x7.c
> @@ -420,7 +420,6 @@ static const struct {
> { .n = "lvdsc_clk", .id = 56, },
> { .n = "pit64b1_clk", .id = 58, },
> { .n = "puf_clk", .id = 59, },
> - { .n = "gmactsu_clk", .id = 67, },
Could you please keep this in a separate patch?
> };
>
> /*
> @@ -702,15 +701,6 @@ static const struct {
> .pp_count = 1,
> .pp_chg_id = INT_MIN,
> },
> -
> - {
> - .n = "gmac_gclk",
> - .id = 67,
> - .pp = { "audiopll_divpmcck", "plla_div2pmcck", },
> - .pp_mux_table = { 6, 8, },
> - .pp_count = 2,
> - .pp_chg_id = INT_MIN,
> - },
And squash this changes with patch 3/4 "clk: at91: sam9x7: Add gmac generic
clock entry with ID 24" and also provide a fixes tag for it?
Thank you,
Claudiu
next prev parent reply other threads:[~2026-02-28 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 10:01 [PATCH v2 0/4] Update gmac clocks and devicetree for sam9x7 mpu Mihai Sain
2026-02-12 10:01 ` [PATCH v2 1/4] clk: at91: sam9x7: Remove gmac peripheral and generic clock entries with ID 67 Mihai Sain
2026-02-28 14:22 ` Claudiu Beznea [this message]
2026-02-12 10:01 ` [PATCH v2 2/4] clk: at91: sam9x7: Rename macb0_clk to gmac_clk Mihai Sain
2026-02-28 14:22 ` Claudiu Beznea
2026-02-12 10:01 ` [PATCH v2 3/4] clk: at91: sam9x7: Add gmac generic clock entry with ID 24 Mihai Sain
2026-02-12 10:01 ` [PATCH v2 4/4] ARM: dts: microchip: sam9x7: fix GMAC clock configuration Mihai Sain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9965d2fb-e1ee-4103-a5d3-01cb94468db0@tuxon.dev \
--to=claudiu.beznea@tuxon.dev \
--cc=alexandre.belloni@bootlin.com \
--cc=balamanikandan.gunasundar@microchip.com \
--cc=conor+dt@kernel.org \
--cc=cristian.birsan@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.sain@microchip.com \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
--cc=ryan.wanner@microchip.com \
--cc=sboyd@kernel.org \
--cc=varshini.rajendran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox