From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3775C001DB for ; Mon, 7 Aug 2023 13:51:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dRm8DNRWMbiaS0sxCXU2wFgie/V9YT3I9YvAwQ/agUs=; b=FKzt9daqtG/0Iv 78XsGYgn1Or1IEgUX9O4Gg/v/WrblFbMOZCf7w/8u03CWewf0V6or3ZK1nxrvWApvaQBBvoqz1qIU 4OWqE5ZNFFHosm14ivPY5aHEWj/FwiaOcG+8HL4SjCrBLAHh2H0JOa3JBskSUqgsKGJ89V3YdYIk6 EY4VkihZ/omLC6KRv0Eslwd8jVjHMHKUgHapUnPtWXMQV4tLKNTGTYorUvwjfLU077etyTFI1caTe ip6KROqV/BCvJtOuyIxhjWphUilC4/TA1ZPDtz0X+/nq6iRz95aS/X1xV8MZK8wAtDi/ZxiyO5KXr 7ky9zSEIPXFI5PRtosHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qT0dB-00HSMB-0s; Mon, 07 Aug 2023 13:50:45 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qT0d8-00HSL5-1g for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 13:50:43 +0000 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-52164adea19so5892349a12.1 for ; Mon, 07 Aug 2023 06:50:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691416238; x=1692021038; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TJvK32hfp7W2IiN/EvVttylVS5EgMni1Y/4T65DWePg=; b=L5ZeOA4RaGuzqdd+ADcWzq9s/f1sZ4yf3ThmLa07nCL0zuDUx5mgGPA6nvy47kNdyj S+ASwiMDNoWGciC4wW+UaqyQLBhvyiQhSlwp+Ikr6iIKtqp4iC65B7YKOU7mBzPKFQFL Awn/67aAFv+VBTrNhXedHHEIY/3ka9vR6MyKCE/nDoNm64E7/1VVxGHPdnGWQZ+Akw6K ZJlEOJilxd/sOHVsJ0uDEYOOAtKHhMC4Dx60yd+PJQ+mGgO+GipECtK4d+WJ/8TI9XuU j2E/qNXWukiehaVOAAsh+2/R8fIrJEe/ro1EupSBg+nzTbaRbhNh0kaMqjTrrKfvHwKn RVCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691416238; x=1692021038; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TJvK32hfp7W2IiN/EvVttylVS5EgMni1Y/4T65DWePg=; b=AzFgKsTgAHadf2XD0j5bZRbJeZdJA09fCNWGr5rXmWzrMmQCHyhGVA2jJ9rSYeilfO 657++/NsulYsxCt25YYfWXV4Iy3f8jS3ScKhBX10udigg6+1nSweVn/4Pv786ijxdd2g DjkBv9Yc7niSwY441DKLKimFTv92vN5VA4VycNTpR0jg5VNhdC+tvpcKVagrrI/JRL7K 7CDvEtCGQgIgT17qjKGEeRttSgrnLfZhx4200gxhgcziNEHP/SvMHxZtq4JmAtu3vnDh czac9XTvwY8WiCSVPyHwmStbsKpuwxWov5LIDP84o/ZMxuEBFbnbRG3lIa6LDFBDRc80 xBVA== X-Gm-Message-State: AOJu0YzL/ZmoBaxgPAyBn7jLFdT1jVwaZl7HW0Uc2NSkBe4akL+KFfos 6HoBHoQN4Bhyz0YFXrm6TLt/zw== X-Google-Smtp-Source: AGHT+IEpZcOZrB1JjhLGm3EtdG7FGURcI374JR8G6zMsbVKzVKzlpVS/LBHaKsa06lDjpvqguJ0d1g== X-Received: by 2002:aa7:c651:0:b0:522:3ea4:81a9 with SMTP id z17-20020aa7c651000000b005223ea481a9mr7731992edr.34.1691416238152; Mon, 07 Aug 2023 06:50:38 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id i22-20020a50fc16000000b005232e637c24sm2512196edr.84.2023.08.07.06.50.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Aug 2023 06:50:37 -0700 (PDT) Message-ID: <9967fa81-f3f4-04c4-a837-d507a19989cc@linaro.org> Date: Mon, 7 Aug 2023 15:50:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] tty: serial: samsung: Set missing PM ops for hibernation support Content-Language: en-US To: Anton Eliasson , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@axis.com References: <20230803-samsung_tty_pm_ops-v1-1-1ea7be72194d@axis.com> From: Krzysztof Kozlowski In-Reply-To: <20230803-samsung_tty_pm_ops-v1-1-1ea7be72194d@axis.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230807_065042_576977_1B687E95 X-CRM114-Status: GOOD ( 10.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/08/2023 13:26, Anton Eliasson wrote: > At least freeze, restore and thaw need to be set in order for the driver > to support system hibernation. The existing suspend/resume functions can > be reused since those functions don't touch the device's power state or > wakeup capability. Use the helper macros SET_SYSTEM_SLEEP_PM_OPS and > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS for symmetry with similar drivers. > Looks sensible, although you should also test the other sleep methods, e.g. suspend to idle. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel