From: Baolu Lu <baolu.lu@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>, Joerg Roedel <joro@8bytes.org>,
Sven Peter <sven@svenpeter.dev>,
David Woodhouse <dwmw2@infradead.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Yong Wu <yong.wu@mediatek.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: baolu.lu@linux.intel.com, iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] iommu: remove the unused dev_has_feat method
Date: Fri, 8 Jul 2022 16:43:04 +0800 [thread overview]
Message-ID: <9973a21c-ac5e-7b16-e5bb-4242bcec1a82@linux.intel.com> (raw)
In-Reply-To: <20220708080616.238833-2-hch@lst.de>
On 2022/7/8 16:06, Christoph Hellwig wrote:
> This method is never actually called.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Best regards,
baolu
> ---
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 1 -
> include/linux/iommu.h | 4 +---
> 2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> index d9c1623ec1a9a..1b6c17dd81ee4 100644
> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> @@ -2853,7 +2853,6 @@ static struct iommu_ops arm_smmu_ops = {
> .of_xlate = arm_smmu_of_xlate,
> .get_resv_regions = arm_smmu_get_resv_regions,
> .put_resv_regions = generic_iommu_put_resv_regions,
> - .dev_has_feat = arm_smmu_dev_has_feature,
> .dev_feat_enabled = arm_smmu_dev_feature_enabled,
> .dev_enable_feat = arm_smmu_dev_enable_feature,
> .dev_disable_feat = arm_smmu_dev_disable_feature,
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index e6abd998dbe73..a3acdb46b9391 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -164,8 +164,7 @@ struct iommu_iort_rmr_data {
> * supported, this feature must be enabled before and
> * disabled after %IOMMU_DEV_FEAT_SVA.
> *
> - * Device drivers query whether a feature is supported using
> - * iommu_dev_has_feature(), and enable it using iommu_dev_enable_feature().
> + * Device drivers enable a feature using iommu_dev_enable_feature().
> */
> enum iommu_dev_features {
> IOMMU_DEV_FEAT_SVA,
> @@ -248,7 +247,6 @@ struct iommu_ops {
> bool (*is_attach_deferred)(struct device *dev);
>
> /* Per device IOMMU features */
> - bool (*dev_has_feat)(struct device *dev, enum iommu_dev_features f);
> bool (*dev_feat_enabled)(struct device *dev, enum iommu_dev_features f);
> int (*dev_enable_feat)(struct device *dev, enum iommu_dev_features f);
> int (*dev_disable_feat)(struct device *dev, enum iommu_dev_features f);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-08 8:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 8:06 remove dead iommu code v2 Christoph Hellwig
2022-07-08 8:06 ` [PATCH 1/4] iommu: remove the unused dev_has_feat method Christoph Hellwig
2022-07-08 8:43 ` Baolu Lu [this message]
2022-07-08 8:06 ` [PATCH 2/4] iommu: remove iommu_dev_feature_enabled Christoph Hellwig
2022-07-08 8:47 ` Baolu Lu
2022-07-08 8:06 ` [PATCH 3/4] iommu: remove the put_resv_regions method Christoph Hellwig
2022-07-08 9:00 ` Baolu Lu
2022-07-08 9:33 ` Christoph Hellwig
2022-07-08 10:03 ` Baolu Lu
2022-07-08 10:12 ` Will Deacon
2022-07-08 10:19 ` Christoph Hellwig
2022-07-08 10:32 ` Will Deacon
2022-07-08 8:06 ` [PATCH 4/4] iommu/arm-smmu-v3: cleanup arm_smmu_dev_{enable,disable}_feature Christoph Hellwig
2022-07-08 10:33 ` Will Deacon
2022-07-15 8:14 ` remove dead iommu code v2 Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9973a21c-ac5e-7b16-e5bb-4242bcec1a82@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robin.murphy@arm.com \
--cc=sven@svenpeter.dev \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).