From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5CE9C43334 for ; Fri, 8 Jul 2022 08:44:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:Cc: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8Eq7gQV5+4vSMp/a6hd2BZQDbC5zXHGE5L9Kgg94PSI=; b=gD+ZKZRV0auo0h nMqSrYeKc5RGJ/bp8EkKLYEQMJUCYyLTLyW4vIqbuZG8BkDD8N6jjI+wMIbv4EH/dsi74lyPkvOJb daHNYzZIPJ7f5urOwmuWQuZ37eyxAw1b4sixRDqUqir50Be0sJqInmN9zTsM77J+lHbEfoPURbcVH CsC+U0ljJhKbXIfk1eACg3ZiGtGf5b/XZXZdRA+p7S7OcyfFxZE1tnORyfJgpZZhHE7tNNyM484b6 OlzkEXFB2DAJM2VcxJM7jb3Cd1AoT0Nf2Z9L/sPcbNZ0cKzisA9SjlL8RbfcOyrkiauFWB6fzMy1O 4Lc0F/FaalfrawnFE1ow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9jZz-002dYf-DN; Fri, 08 Jul 2022 08:43:15 +0000 Received: from mga05.intel.com ([192.55.52.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9jZw-002dXh-7o for linux-arm-kernel@lists.infradead.org; Fri, 08 Jul 2022 08:43:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657269792; x=1688805792; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=ZL5aFr3l1jc3K8HSJ5uF7UCrQDZrFncEqq7wzvxfLVE=; b=VjWFLH8Zj/7jlWPmAPArCaTjSUFd+SCm/xZfs3rJKAsT9VBAeRR5On9/ z3mzZmBnESl1uNaytBkgC/y6PsMhC2T939f+gLUKpaEFzUTAFmy5ee/y3 imQoYiwA2Q/9oWRv8zid2YODA3nOkvg1eG/KSO3LP8EoG2nL4xcfQ31M9 B8N0AHh6jppEIkGSBshwP4sIqd3R0f7t+LW5tel7tMKrxLuw+giveUuM1 9oPd7FwRyarAYsHeIltHtLelv3ZrKaxgKpptpAYoYVt4azuGcZE/PmJ75 C9mDdEYVwvdJC0lyAdZOsMHcGq16GXFLjKh3I4QQz34QzyAakLCAHxGtn w==; X-IronPort-AV: E=McAfee;i="6400,9594,10401"; a="370546618" X-IronPort-AV: E=Sophos;i="5.92,255,1650956400"; d="scan'208";a="370546618" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 01:43:09 -0700 X-IronPort-AV: E=Sophos;i="5.92,255,1650956400"; d="scan'208";a="621139616" Received: from yanc1-mobl.ccr.corp.intel.com (HELO [10.255.28.91]) ([10.255.28.91]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 01:43:06 -0700 Message-ID: <9973a21c-ac5e-7b16-e5bb-4242bcec1a82@linux.intel.com> Date: Fri, 8 Jul 2022 16:43:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Cc: baolu.lu@linux.intel.com, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/4] iommu: remove the unused dev_has_feat method Content-Language: en-US To: Christoph Hellwig , Joerg Roedel , Sven Peter , David Woodhouse , Will Deacon , Robin Murphy , Yong Wu , Jean-Philippe Brucker References: <20220708080616.238833-1-hch@lst.de> <20220708080616.238833-2-hch@lst.de> From: Baolu Lu In-Reply-To: <20220708080616.238833-2-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220708_014312_346480_D4556B45 X-CRM114-Status: GOOD ( 17.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/7/8 16:06, Christoph Hellwig wrote: > This method is never actually called. > > Signed-off-by: Christoph Hellwig Reviewed-by: Lu Baolu Best regards, baolu > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 1 - > include/linux/iommu.h | 4 +--- > 2 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index d9c1623ec1a9a..1b6c17dd81ee4 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -2853,7 +2853,6 @@ static struct iommu_ops arm_smmu_ops = { > .of_xlate = arm_smmu_of_xlate, > .get_resv_regions = arm_smmu_get_resv_regions, > .put_resv_regions = generic_iommu_put_resv_regions, > - .dev_has_feat = arm_smmu_dev_has_feature, > .dev_feat_enabled = arm_smmu_dev_feature_enabled, > .dev_enable_feat = arm_smmu_dev_enable_feature, > .dev_disable_feat = arm_smmu_dev_disable_feature, > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index e6abd998dbe73..a3acdb46b9391 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -164,8 +164,7 @@ struct iommu_iort_rmr_data { > * supported, this feature must be enabled before and > * disabled after %IOMMU_DEV_FEAT_SVA. > * > - * Device drivers query whether a feature is supported using > - * iommu_dev_has_feature(), and enable it using iommu_dev_enable_feature(). > + * Device drivers enable a feature using iommu_dev_enable_feature(). > */ > enum iommu_dev_features { > IOMMU_DEV_FEAT_SVA, > @@ -248,7 +247,6 @@ struct iommu_ops { > bool (*is_attach_deferred)(struct device *dev); > > /* Per device IOMMU features */ > - bool (*dev_has_feat)(struct device *dev, enum iommu_dev_features f); > bool (*dev_feat_enabled)(struct device *dev, enum iommu_dev_features f); > int (*dev_enable_feat)(struct device *dev, enum iommu_dev_features f); > int (*dev_disable_feat)(struct device *dev, enum iommu_dev_features f); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel