Re: [PATCH v2 05/16] dt-bindings: interrupt-controller: apple,aic2: Add apple,t8112-aic compatible

Krzysztof Kozlowski
2023-02-14T11:08:03Z

> The Apple M2 SoC uses AICv2 and is compatible with the existing driver.
> Add its per-SoC compatible.
> Since multi-die versions of the M2 are not expected decrease
> '#interrupt-cells' to 3 for apple,t8112-aic. This is seamlessly handled
> inside the driver.
>

Thank you for your patch. There is something to discuss/improve.

>
> - The 2nd cell contains the die ID.
> + The 2nd cell contains the die ID (only present on apple,t6000-aic).
>
> The next cell contains the interrupt number.
> - HW IRQs: interrupt number
> @@ -110,6 +113,20 @@ additionalProperties: false
> allOf:
> - $ref: /schemas/interrupt-controller.yaml#
>
> +if:

This should be under "allOf" (as next entry so " - if:").

> + properties:
> + compatible:
> + contains:
> + const: apple,t8112-aic
> +then:
> + properties:
> + '#interrupt-cells':
> + const: 3
> +else:
> + properties:
> + '#interrupt-cells':
> + const: 4
> +
> examples:
> - |
> soc {