From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91FDCD2F7CF for ; Fri, 5 Dec 2025 10:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id: Content-Transfer-Encoding:Cc:Date:In-Reply-To:From:Subject:Mime-Version: Content-Type:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UrPIgvsg58eOsedSnhLH7or6+6ch9iVeKdBWBSvRqYc=; b=j9HwOPBqhjJ3duowh3TeXCNjz0 nfSBDIRVXRDLnCXIBGaE2uWPAZD3RX6rVjRCEZUQIPHM0gXU+6CsVWQXkkQ2jaO7mGCLJZQEHnhog ZQnUCT3hhYGpbxAdUi1pDgY0Wlg2dG11moxArcZgpkL9Wskd/4xQL/lRGT3yj/L/EX38h/QmOHW/M gVoNZiwQ7+kIYwzHmaoNvq8GqM14sQL6QEX32tsLScyuC+demp5RFT5hltjxjuGcV8kcJiSI6kbFL GDkprnu6U2cfOVyHtj0ODPyEv73zqnNtEuCN9NUNj6n2NchfE4R2hZGusNNGhTbNo7uShnnqjKbiB dKejyk+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vRSfT-00000009MOy-36TV; Fri, 05 Dec 2025 10:04:03 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vRSfQ-00000009MMG-3thA for linux-arm-kernel@lists.infradead.org; Fri, 05 Dec 2025 10:04:02 +0000 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-b7277324054so275789366b.0 for ; Fri, 05 Dec 2025 02:04:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764929039; x=1765533839; darn=lists.infradead.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UrPIgvsg58eOsedSnhLH7or6+6ch9iVeKdBWBSvRqYc=; b=ZnDZv3PQP3ByVrgBY/Ueq3nld3LMZOl+jrP9s5fVTpJGoxw0aqfg+rge0qbM3OElTB aLQIqqKqOBLjmFXqWhHJMy+vn3kJzPKOML2C7M1PQpt14mukRwz69838DXIS7/4pOZhM mRn8m7G/ffmSqbi3Xrxz3+dReGhzRz0BEKdd+zT0J/oy93avxRfxk3ldwHZdiy/s6yDN r1SvUmmf9ON6VMz2hdy5iIq29V/Bm7HTKY84DC4mgdBuAunRrhyw1XsGrwtDNikg7AGd VDkqfJKtAivFTQW7//vTvJOrBvOv31XMrpWc/wKIKFWMr7Zo2twY10PXou98/ahzx6PZ ucJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764929039; x=1765533839; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UrPIgvsg58eOsedSnhLH7or6+6ch9iVeKdBWBSvRqYc=; b=UqsUu2zZ3CLa1XyV141vJzp4BiCCAO1YiD6jZzK8J9ZOD/ACUoQBlyMMXFBlo2gTjq OKy94OdOWuq26kFI/ewcS/8LfTXttb7h4XqmQmZD3TrMGmArJuCXWgI9OTaGViDQHdFW 3QVw+cWe2Y6o8NTm9ZNmhCtorVNDDpjASXFpRK1A2lSXwRVl4Lt7btQR/3kDT/B7ei0k S9D+kmU82xIgYRyb8SH/wQNE0Rz+NKcJXkklNEunVKsXzfTMOiy9Tz/VNjDyk0wwmzkO WgwzaUsn83jZbDN3uhvI8lYs56Kq9e6YUimLWzW+4o+zjcSYGhwe9WK/h7A4C43TSn3v y0xg== X-Forwarded-Encrypted: i=1; AJvYcCXX/kG2r++j0wg6WA/SN9QtYKQwg86DWOP5WBUDYYxjZ4PC1m+AYxJeOEeH8SqDLa33ckMn7GCbVFytSmcMYEca@lists.infradead.org X-Gm-Message-State: AOJu0YxbugaeRByOugfgGblygZ7i8J4ki5x6jKI8KrjHy5PjL41lTdjl bVGc3FeM1AiHx/JybVZCfJSkay6x8c8S2lAPtzrwt9jbEECCSmCWJwXX X-Gm-Gg: ASbGncvwExppqOTWl/xliYj7dvB4fgFXjiY7on8JvZ6oqYm7biB39vzaUti2jupM7n5 FzKS+cBf4qwpqR6kqMRgy2MmeRr5lhmVb0R+AppxK3ncTycHj36cEj6XSHyhE1WjjT4pJ0AN9LA P4xzwQYWY9Ze+E/nU1EuYyYp6Zgf4TGNokrYLrVHCQ20/tuEQ8en5cVj+2d1h1Kx0L2fHMgtayd RCsAEGk2269oxv3xhhPQ1tpz+laf6IxhrWN05+nT1xLH9/Eyzhl70LnKlIgS66ZbfAltAW1y0aZ NpWTSEejaCFGnLHg2DWUkmHW2yDMG7ned6HrwbhDPl4rAxCVcGPasR5UXVqGgVi4JdvYdk+yW4x wQWIIhwmrVX2+JYmYJff6jRCFjn4U7paJrajkynFdnemsfOvc1JI69CGVCV1HbauxJVSFA96jsO tNGvvM9Lnn2MAiI3MsGz4UbwdG4B352r7vsu1Hs22bgujFO++JCHLHlTCLwdYgaHvJpKZQfOFrF 4E= X-Google-Smtp-Source: AGHT+IGmVNPybgxaTnBEjYF9iUoQvCh+If0y7frV3hE4t1NG2W8NXsB234VYEXtYlgdaKQwxequung== X-Received: by 2002:a17:907:daa:b0:b72:fd32:a463 with SMTP id a640c23a62f3a-b79dbe9000bmr989333866b.23.1764929038231; Fri, 05 Dec 2025 02:03:58 -0800 (PST) Received: from smtpclient.apple (89-66-237-154.dynamic.play.pl. [89.66.237.154]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b79f4a2f401sm333937766b.65.2025.12.05.02.03.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Dec 2025 02:03:57 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: [PATCH 01/11] dt-bindings: display: meson-dw-hdmi: Add compatible for S4 HDMI controller From: Piotr Oniszczuk In-Reply-To: Date: Fri, 5 Dec 2025 11:03:44 +0100 Cc: Chuan Liu , Neil Armstrong , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <9BCB2E8F-F8FA-4CA4-9039-FADE0D875404@gmail.com> References: <20250110-drm-s4-v1-0-cbc2d5edaae8@amlogic.com> <20250110-drm-s4-v1-1-cbc2d5edaae8@amlogic.com> <3AC316FA-A633-4B6C-81BA-CCCA290E7F03@gmail.com> <8c3b9fa4-326e-4791-8154-07b268faa132@amlogic.com> <7703796D-35D4-4AD2-B7F8-B75D2BE0F7AD@gmail.com> <070eb0a3-2f6e-41ef-8310-0c592a2816dc@amlogic.com> To: Ao Xu X-Mailer: Apple Mail (2.3826.700.81) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251205_020401_011105_AABFA27E X-CRM114-Status: GOOD ( 26.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ao, Thx! Indeed patch helps with boot freeze. I started to see on monitor - with correct resolution - 4 tuxes in upper = left corner :-) Now i'm getting user space oops like this:=20 https://gist.github.com/warpme/b8b757bc1444be8a137849301698ee4b i'm pretty sure it is related to lack of (or issue with) console at = kernel early init in user space. As kernel with s4 hdmi code works for you - but traps for me - i think = there is still issue with s4 hdmi code. I suspect it is because diff between: my kernel config and yours. (so it is exposing existing hidden issue) btw: I'm not surprised by this as my kernel config is multi-soc (common = for = bcm25xx/27xx/s905/s912/g12/sm1/s4/h6/h616/a523/h700/rk33xx/rk35xx/qcs6490)= Usually kernel configs done for single soc (probably config you are = using to test s4 hdmi code) are not exposing hidden issues exposed by = multi-soc config (like mine config).=20 I deal with such issues multiple times in past. multi-soc config i'm using is like this: = https://github.com/warpme/minimyth2/blob/master/script/kernel/linux-6.18/f= iles/linux-6.18-arm64-armv8.config May you pls try to compile your s4 hdmi code with above config? I'm quite sure it will expose to you issue i'm getting.... > Wiadomo=C5=9B=C4=87 napisana przez Ao Xu w dniu 5 = gru 2025, o godz. 08:09: >=20 > Hi Piotr=EF=BC=8C >=20 > I applied this patch: = https://github.com/warpme/minimyth2/blob/master/script/kernel/linux-6.18/f= iles/0312-drm-meson-add-vpu-clk-setting-for-S4.patch, and ran it on the = board. >=20 > I encountered the same issue=E2=80=94the system froze. >=20 > I found that the patch has a few minor problems. After fixing = them, the system runs normally. Could you try the following patch? >=20 >=20 > =E5=9C=A8 2025/12/3 13:56, Ao Xu =E5=86=99=E9=81=93: >> Hi Piotr=EF=BC=8C >>=20 >> I will need about two more days to look into it. I will follow up = with you ASAP. >>=20 >>=20 >> =E5=9C=A8 2025/12/2 16:29, Piotr Oniszczuk =E5=86=99=E9=81=93: >>> [You don't often get email from piotr.oniszczuk@gmail.com. Learn why = this is important at https://aka.ms/LearnAboutSenderIdentification ] >>>=20 >>> [ EXTERNAL EMAIL ] >>>=20 >>> Ao, >>> Any chance for updated s4 hdmi series for 6.18? >>>=20 >>>=20 >>>> Wiadomo=C5=9B=C4=87 napisana przez Ao Xu w dniu = 21 lis 2025, o godz. 03:55: >>>>=20 >>>> Hi Piotr=EF=BC=8C >>>>=20 >>>> I will check this issue >>>>=20 >>>> =E5=9C=A8 2025/11/19 18:27, Piotr Oniszczuk =E5=86=99=E9=81=93: >>>>> [You don't often get email from piotr.oniszczuk@gmail.com. Learn = why this is important at https://aka.ms/LearnAboutSenderIdentification ] >>>>>=20 >>>>> [ EXTERNAL EMAIL ] >>>>>=20 >>>>> Pls see inline >>>>>=20 >>>>>> Wiadomo=C5=9B=C4=87 napisana przez Chuan Liu = w dniu 19 lis 2025, o godz. 03:57: >>>>>>=20 >>>>>> Hi Piotr, >>>>>>=20 >>>>>>=20 >>>>>> On 11/18/2025 10:50 PM, Piotr Oniszczuk wrote: >>>>>>> [You don't often get email from piotr.oniszczuk@gmail.com. Learn = why this is important at https://aka.ms/LearnAboutSenderIdentification ] >>>>>>> [ EXTERNAL EMAIL ] >>>>>>> Ao, >>>>>>> Is there any chance to get this s4 drm hdmi series for current = 6.18? >>>>>>> (i tried backport this series to 6.18 but have some issues with = reparent vpu_0_sel to sysclk_b_sel) >>>>>> Why do we need to reparent vpu_0_sel to sysclk_b_sel? is there = any >>>>>> background here? >>>>> Well - it looks it is because bug.... >>>>> Martin Blumenstingl had perfect eye and catch typo in patch = https://lore.kernel.org/all/20250110-drm-s4-v1-11-cbc2d5edaae8@amlogic.com= /:=20 >>>>>=20 >>>>> By replacing: >>>>> assigned-clock-parents =3D <&clkc_periphs CLKID_FCLK_DIV3>, >>>>> <0>, /* Do Nothing */ >>>>> <&clkc_periphs CLKID_VPU_0>, >>>>> <&clkc_periphs CLKID_FCLK_DIV4>, >>>>> <0>, /* Do Nothing */ >>>>> <&clkc_periphs CLKID_VAPB_0>; >>>>>=20 >>>>> with: >>>>> assigned-clock-parents =3D <&clkc_pll CLKID_FCLK_DIV3>, >>>>> <0>, /* Do Nothing */ >>>>> <&clkc_periphs CLKID_VPU_0>, >>>>> <&clkc_pll CLKID_FCLK_DIV4>, >>>>> <0>, /* Do Nothing */ >>>>> <&clkc_periphs CLKID_VAPB_0>; >>>>>=20 >>>>> dmesg is like this https://termbin.com/6020 >>>>>=20 >>>>> So i'm getting hdmi working - but only when device boots _without_ = connected hdmi at boot (and connected later) >>>>> If hdmi is connected at boot - boot hangs at: >>>>>=20 >>>>> 0.341676] meson-dw-hdmi fe300000.hdmi-tx: Detected HDMI TX = controller v2.01a with HDCP (meson_dw_hdmi_phy) >>>>> [ 0.342750] meson-dw-hdmi fe300000.hdmi-tx: registered = DesignWare HDMI I2C bus driver >>>>> [ 0.343660] meson-drm ff000000.vpu: bound fe300000.hdmi-tx (ops = meson_dw_hdmi_ops) >>>>> [ 0.344832] [drm] Initialized meson 1.0.0 for ff000000.vpu on = minor 0 >>>>>=20 >>>>> FYI: It is after applying = https://patchwork.kernel.org/project/linux-amlogic/cover/20250110-drm-s4-v= 1-0-cbc2d5edaae8@amlogic.com/ on mainline 6.18 (with some my adjustments = on this series required by changes in 6.18). >>>>> For VPU clk changes see = https://github.com/warpme/minimyth2/blob/master/script/kernel/linux-6.18/f= iles/0312-drm-meson-add-vpu-clk-setting-for-S4.patch >>>>> It is 6.18 adaptation of = https://patchwork.kernel.org/project/linux-amlogic/patch/20250110-drm-s4-v= 1-9-cbc2d5edaae8@amlogic.com/ >>>>>=20 >>>>> As kernel hangs - i have limited caps to drill where root cause = is. >>>>>=20 >>>>> Maybe above hang is reason of my backports or missing any pre-req = required to get s4 drm working? >>>>> Anyway - it will be good to test with updated to 6.18 series of = Add DRM support for Amlogic S4 (plus info about any pre-req required to = get s4 drm working) >>>>>=20 >>>>>=20 >>>>>> The vpu_clk on S4 doesn't support sysclk_b_sel as one of its >>>>>> selectable clock sources, so this reparent operation will = definitely >>>>>> fail. This has nothing to do with the kernel version. >>>>>>=20 >>>>>>>> Wiadomo=C5=9B=C4=87 napisana przez Ao Xu via B4 Relay = w dniu 10 sty 2025, o godz. = 06:39: >>>>>>>>=20 >>>>>>>> From: Ao Xu >>>>>>>>=20 >>>>>>>> Add devicetree document for S4 HDMI controller >>>>>>>>=20 >>>>>>>> Signed-off-by: Ao Xu >>>>>>>> --- >>>>>>>> = Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml | 1 = + >>>>>>>> 1 file changed, 1 insertion(+) >>>>>>>>=20 >>>>>>>> diff --git = a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml = b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml=20= >>>>>>>> index = 84d68b8cfccc86fd87a6a0fd2b70af12e51eb8a4..6e0a8369eee915fab55af24d450a6c40= e08def38 100644 >>>>>>>> --- = a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml=20= >>>>>>>> +++ = b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml=20= >>>>>>>> @@ -55,6 +55,7 @@ properties: >>>>>>>> - const: amlogic,meson-gx-dw-hdmi >>>>>>>> - enum: >>>>>>>> - amlogic,meson-g12a-dw-hdmi # G12A (S905X2, S905Y2, = S905D2) >>>>>>>> + - amlogic,meson-s4-dw-hdmi # S4 (S905Y4) >>>>>>>>=20 >>>>>>>> reg: >>>>>>>> maxItems: 1 >>>>>>>>=20 >>>>>>>> --=20 >>>>>>>> 2.43.0 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>> _______________________________________________ >>>>>>>> linux-amlogic mailing list >>>>>>>> linux-amlogic@lists.infradead.org >>>>>>>> http://lists.infradead.org/mailman/listinfo/linux-amlogic >>>>>>> _______________________________________________ >>>>>>> linux-amlogic mailing list >>>>>>> linux-amlogic@lists.infradead.org >>>>>>> http://lists.infradead.org/mailman/listinfo/linux-amlogic >