From: Christian Hewitt <christianshewitt@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
Linux Amlogic <linux-amlogic@lists.infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: meson: add support for BananaPi M2S variants
Date: Sun, 5 Mar 2023 17:47:38 +0400 [thread overview]
Message-ID: <9CC246C2-28A7-46DF-924F-8FBF5CDE16CA@gmail.com> (raw)
In-Reply-To: <0d2184ee-679e-371e-8433-c38b22c97799@linaro.org>
> On 5 Mar 2023, at 5:30 pm, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
> On 05/03/2023 14:20, Christian Hewitt wrote:
>> BananaPi M2S ships in Amlogic S922X and A311D variants with the
>> following common specifications:
>>
> (...)
>
>> +
>> + leds {
>> + compatible = "gpio-leds";
>> +
>> + blue {
>
> led-0
>
> Does not look like you tested the DTS against bindings. Please run `make
> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
> for instructions).
I’m building everything in a cross-compile build system that doesn’t allow
this to be done without a problem amount of hoop jumping. I need to work on
another arrangement to do this testing (work-in-progress). Thanks for the
input.
Christian
>> + color = <LED_COLOR_ID_BLUE>;
>> + function = LED_FUNCTION_STATUS;
>> + gpios = <&gpio_ao GPIOAO_7 GPIO_ACTIVE_LOW>;
>> + linux,default-trigger = "heartbeat";
>> + };
>> +
>> + green {
>
> led-1
>
>> + color = <LED_COLOR_ID_GREEN>;
>> + function = LED_FUNCTION_STATUS;
>> + gpios = <&gpio_ao GPIOAO_2 GPIO_ACTIVE_LOW>;
>> + };
>
> Best regards,
> Krzysztof
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-05 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-05 13:20 [PATCH 0/2] arm64: amlogic: Add initial support for BPI-M2S variants Christian Hewitt
2023-03-05 13:20 ` [PATCH 1/2] dt-bindings: arm: amlogic: add support for BananaPi M2S variants Christian Hewitt
2023-03-05 13:31 ` Krzysztof Kozlowski
2023-03-05 13:20 ` [PATCH 2/2] arm64: dts: meson: " Christian Hewitt
2023-03-05 13:30 ` Krzysztof Kozlowski
2023-03-05 13:47 ` Christian Hewitt [this message]
2023-03-05 14:15 ` Krzysztof Kozlowski
2023-03-05 14:31 ` Christian Hewitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9CC246C2-28A7-46DF-924F-8FBF5CDE16CA@gmail.com \
--to=christianshewitt@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox