From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAF5DC2D0CD for ; Mon, 19 May 2025 18:23:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=quBnvz6Q1eWs28SV8NyU7RTxL0s+aGY8AAVgIZv5Xd0=; b=FbkeKep+lxuyayVEdqjjZMBt2o us7sUTiwrIPrUabAYgzwesjf0b9tbFjTlh78Zz+IsOS4Z2stNUooacPNU+TvD1AmgxvZ6NJeqyihM 30nYwE7VzypR5StS5fz+VgUvrd0XB6vGcaOFEzCPmaH3O2Bgk237+/jRIs0fnq5uvf/J6fMI9mp/i Uw+bNpmIkfEVpxaSUGohkeyfv7fQYvNrqnUZ1rKnDltEk4kZV5DwbGaGM3Fu62nwjv1hJqIiEYM3U qYFMQd0GwAEaF5OIWvq/QcTttQL3JNOnmJgapH/V94Dz4iKD3bY22MqzUwkr0ZqZwbmX13tiiLEwB b6b7W+IA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uH58b-0000000A8Cv-1BTI; Mon, 19 May 2025 18:22:57 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uH4bj-0000000A15C-2H6w for linux-arm-kernel@lists.infradead.org; Mon, 19 May 2025 17:49:00 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 74F0115A1; Mon, 19 May 2025 10:48:45 -0700 (PDT) Received: from [10.57.50.157] (unknown [10.57.50.157]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 441CF3F673; Mon, 19 May 2025 10:48:55 -0700 (PDT) Message-ID: <9a09a3fe-c91c-457f-b6da-9fccbf98e649@arm.com> Date: Mon, 19 May 2025 18:48:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 21/43] KVM: arm64: Handle realm VCPU load Content-Language: en-GB To: Steven Price , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" References: <20250416134208.383984-1-steven.price@arm.com> <20250416134208.383984-22-steven.price@arm.com> From: Suzuki K Poulose In-Reply-To: <20250416134208.383984-22-steven.price@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250519_104859_624527_0E78BD41 X-CRM114-Status: GOOD ( 15.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/04/2025 14:41, Steven Price wrote: > When loading a realm VCPU much of the work is handled by the RMM so only > some of the actions are required. Rearrange kvm_arch_vcpu_load() > slightly so we can bail out early for a realm guest. > > Signed-off-by: Steven Price > Reviewed-by: Gavin Shan > --- > arch/arm64/kvm/arm.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index cf707130ef66..08d5e0d76749 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -644,10 +644,6 @@ void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu) I think we use the pkvm hook to skip to the nommu goto, to avoid the VMID allocation and context flush. > kvm_timer_vcpu_load(vcpu); > kvm_vgic_load(vcpu); > kvm_vcpu_load_debug(vcpu); > - if (has_vhe()) > - kvm_vcpu_load_vhe(vcpu); > - kvm_arch_vcpu_load_fp(vcpu); > - kvm_vcpu_pmu_restore_guest(vcpu); > if (kvm_arm_is_pvtime_enabled(&vcpu->arch)) > kvm_make_request(KVM_REQ_RECORD_STEAL, vcpu); We could also move thise pvtime to the bottom too ? > > @@ -671,6 +667,15 @@ void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu) > &vcpu->arch.vgic_cpu.vgic_v3); > } > > + /* No additional state needs to be loaded on Realmed VMs */ > + if (vcpu_is_rec(vcpu)) > + return; > + > + if (has_vhe()) > + kvm_vcpu_load_vhe(vcpu); > + kvm_arch_vcpu_load_fp(vcpu); > + kvm_vcpu_pmu_restore_guest(vcpu); > + With the above addressed: Reviewed-by: Suzuki K Poulose > if (!cpumask_test_cpu(cpu, vcpu->kvm->arch.supported_cpus)) > vcpu_set_on_unsupported_cpu(vcpu); > }