From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qL1Q2-00BKYJ-1H for linux-arm-kernel@lists.infradead.org; Sun, 16 Jul 2023 13:04:14 +0000 Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2b708e49059so53074991fa.3 for ; Sun, 16 Jul 2023 06:04:08 -0700 (PDT) Message-ID: <9a0cb190-9344-dc26-b3dd-9895690e886f@tuxon.dev> Date: Sun, 16 Jul 2023 16:04:03 +0300 MIME-Version: 1.0 Subject: Re: [PATCH 02/10] pwm: atmel-hlcdc: Use consistent variable naming References: <20230714205623.2496590-1-u.kleine-koenig@pengutronix.de> <20230714205623.2496590-3-u.kleine-koenig@pengutronix.de> Content-Language: en-US From: claudiu beznea In-Reply-To: <20230714205623.2496590-3-u.kleine-koenig@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+lwn-linux-arm-kernel=archive.lwn.net@lists.infradead.org List-Archive: To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Thierry Reding , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de T24gMTQuMDcuMjAyMyAyMzo1NiwgVXdlIEtsZWluZS1Lw7ZuaWcgd3JvdGU6Cj4gSW4gcHdtIGRy aXZlcnMgdGhlIHZhcmlhYmxlIG5hbWUgImNoaXAiIGlzIHVzdWFsbHkgb25seSB1c2VkIGZvciBz dHJ1Y3QKPiBwd21fY2hpcCBwb2ludGVycy4gVGhpcyBkcml2ZXIgaG93ZXZlciB1c2VkICJjaGlw IiBmb3IgaXRzIGRyaXZlciBkYXRhCj4gYW5kIHB3bV9jaGlwIHBvaW50ZXJzIGFyZSBuYW1lZCAi Y2hpcCIsIHRvbywgd2hlbiB0aGVyZSBpcyBubyBkcml2ZXIKPiBkYXRhIGFyb3VuZCBhbmQgImMi IG90aGVyd2lzZS4gSW5zdGVhZCB1c2UgImRkYXRhIiBmb3IgZHJpdmVyIGRhdGEgYW5kCj4gYWx3 YXlzICJjaGlwIiBmb3IgcHdtX2NoaXBzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFV3ZSBLbGVpbmUt S8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+CgpSZXZpZXdlZC1ieTogQ2xh dWRpdSBCZXpuZWEgPGNsYXVkaXUuYmV6bmVhQHR1eG9uLmRldj4KCj4gLS0tCj4gICBkcml2ZXJz L3B3bS9wd20tYXRtZWwtaGxjZGMuYyB8IDY0ICsrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0t LS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMzIgaW5zZXJ0aW9ucygrKSwgMzIgZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcHdtL3B3bS1hdG1lbC1obGNkYy5jIGIvZHJp dmVycy9wd20vcHdtLWF0bWVsLWhsY2RjLmMKPiBpbmRleCA5NmE3MDlhOWQ0OWEuLjliMDE2NWQ2 MWM0OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3B3bS9wd20tYXRtZWwtaGxjZGMuYwo+ICsrKyBi L2RyaXZlcnMvcHdtL3B3bS1hdG1lbC1obGNkYy5jCj4gQEAgLTM4LDExICszOCwxMSBAQCBzdGF0 aWMgaW5saW5lIHN0cnVjdCBhdG1lbF9obGNkY19wd20gKnRvX2F0bWVsX2hsY2RjX3B3bShzdHJ1 Y3QgcHdtX2NoaXAgKmNoaXApCj4gICAJcmV0dXJuIGNvbnRhaW5lcl9vZihjaGlwLCBzdHJ1Y3Qg YXRtZWxfaGxjZGNfcHdtLCBjaGlwKTsKPiAgIH0KPiAgIAo+IC1zdGF0aWMgaW50IGF0bWVsX2hs Y2RjX3B3bV9hcHBseShzdHJ1Y3QgcHdtX2NoaXAgKmMsIHN0cnVjdCBwd21fZGV2aWNlICpwd20s Cj4gK3N0YXRpYyBpbnQgYXRtZWxfaGxjZGNfcHdtX2FwcGx5KHN0cnVjdCBwd21fY2hpcCAqY2hp cCwgc3RydWN0IHB3bV9kZXZpY2UgKnB3bSwKPiAgIAkJCQkgY29uc3Qgc3RydWN0IHB3bV9zdGF0 ZSAqc3RhdGUpCj4gICB7Cj4gLQlzdHJ1Y3QgYXRtZWxfaGxjZGNfcHdtICpjaGlwID0gdG9fYXRt ZWxfaGxjZGNfcHdtKGMpOwo+IC0Jc3RydWN0IGF0bWVsX2hsY2RjICpobGNkYyA9IGNoaXAtPmhs Y2RjOwo+ICsJc3RydWN0IGF0bWVsX2hsY2RjX3B3bSAqZGRhdGEgPSB0b19hdG1lbF9obGNkY19w d20oY2hpcCk7Cj4gKwlzdHJ1Y3QgYXRtZWxfaGxjZGMgKmhsY2RjID0gZGRhdGEtPmhsY2RjOwo+ ICAgCXVuc2lnbmVkIGludCBzdGF0dXM7Cj4gICAJaW50IHJldDsKPiAgIAo+IEBAIC01NCw3ICs1 NCw3IEBAIHN0YXRpYyBpbnQgYXRtZWxfaGxjZGNfcHdtX2FwcGx5KHN0cnVjdCBwd21fY2hpcCAq Yywgc3RydWN0IHB3bV9kZXZpY2UgKnB3bSwKPiAgIAkJdTMyIHB3bWNmZzsKPiAgIAkJaW50IHBy ZXM7Cj4gICAKPiAtCQlpZiAoIWNoaXAtPmVycmF0YSB8fCAhY2hpcC0+ZXJyYXRhLT5zbG93X2Ns a19lcnJhdHVtKSB7Cj4gKwkJaWYgKCFkZGF0YS0+ZXJyYXRhIHx8ICFkZGF0YS0+ZXJyYXRhLT5z bG93X2Nsa19lcnJhdHVtKSB7Cj4gICAJCQljbGtfZnJlcSA9IGNsa19nZXRfcmF0ZShuZXdfY2xr KTsKPiAgIAkJCWlmICghY2xrX2ZyZXEpCj4gICAJCQkJcmV0dXJuIC1FSU5WQUw7Cj4gQEAgLTY0 LDcgKzY0LDcgQEAgc3RhdGljIGludCBhdG1lbF9obGNkY19wd21fYXBwbHkoc3RydWN0IHB3bV9j aGlwICpjLCBzdHJ1Y3QgcHdtX2RldmljZSAqcHdtLAo+ICAgCQl9Cj4gICAKPiAgIAkJLyogRXJy YXRhOiBjYW5ub3QgdXNlIHNsb3cgY2xrIG9uIHNvbWUgSVAgcmV2aXNpb25zICovCj4gLQkJaWYg KChjaGlwLT5lcnJhdGEgJiYgY2hpcC0+ZXJyYXRhLT5zbG93X2Nsa19lcnJhdHVtKSB8fAo+ICsJ CWlmICgoZGRhdGEtPmVycmF0YSAmJiBkZGF0YS0+ZXJyYXRhLT5zbG93X2Nsa19lcnJhdHVtKSB8 fAo+ICAgCQkgICAgY2xrX3BlcmlvZF9ucyA+IHN0YXRlLT5wZXJpb2QpIHsKPiAgIAkJCW5ld19j bGsgPSBobGNkYy0+c3lzX2NsazsKPiAgIAkJCWNsa19mcmVxID0gY2xrX2dldF9yYXRlKG5ld19j bGspOwo+IEBAIC03Nyw4ICs3Nyw4IEBAIHN0YXRpYyBpbnQgYXRtZWxfaGxjZGNfcHdtX2FwcGx5 KHN0cnVjdCBwd21fY2hpcCAqYywgc3RydWN0IHB3bV9kZXZpY2UgKnB3bSwKPiAgIAo+ICAgCQlm b3IgKHByZXMgPSAwOyBwcmVzIDw9IEFUTUVMX0hMQ0RDX1BXTVBTX01BWDsgcHJlcysrKSB7Cj4g ICAJCS8qIEVycmF0YTogY2Fubm90IGRpdmlkZSBieSAxIG9uIHNvbWUgSVAgcmV2aXNpb25zICov Cj4gLQkJCWlmICghcHJlcyAmJiBjaGlwLT5lcnJhdGEgJiYKPiAtCQkJICAgIGNoaXAtPmVycmF0 YS0+ZGl2MV9jbGtfZXJyYXR1bSkKPiArCQkJaWYgKCFwcmVzICYmIGRkYXRhLT5lcnJhdGEgJiYK PiArCQkJICAgIGRkYXRhLT5lcnJhdGEtPmRpdjFfY2xrX2VycmF0dW0pCj4gICAJCQkJY29udGlu dWU7Cj4gICAKPiAgIAkJCWlmICgoY2xrX3BlcmlvZF9ucyA8PCBwcmVzKSA+PSBzdGF0ZS0+cGVy aW9kKQo+IEBAIC05MCw3ICs5MCw3IEBAIHN0YXRpYyBpbnQgYXRtZWxfaGxjZGNfcHdtX2FwcGx5 KHN0cnVjdCBwd21fY2hpcCAqYywgc3RydWN0IHB3bV9kZXZpY2UgKnB3bSwKPiAgIAo+ICAgCQlw d21jZmcgPSBBVE1FTF9ITENEQ19QV01QUyhwcmVzKTsKPiAgIAo+IC0JCWlmIChuZXdfY2xrICE9 IGNoaXAtPmN1cl9jbGspIHsKPiArCQlpZiAobmV3X2NsayAhPSBkZGF0YS0+Y3VyX2Nsaykgewo+ ICAgCQkJdTMyIGdlbmNmZyA9IDA7Cj4gICAJCQlpbnQgcmV0Owo+ICAgCj4gQEAgLTk4LDggKzk4 LDggQEAgc3RhdGljIGludCBhdG1lbF9obGNkY19wd21fYXBwbHkoc3RydWN0IHB3bV9jaGlwICpj LCBzdHJ1Y3QgcHdtX2RldmljZSAqcHdtLAo+ICAgCQkJaWYgKHJldCkKPiAgIAkJCQlyZXR1cm4g cmV0Owo+ICAgCj4gLQkJCWNsa19kaXNhYmxlX3VucHJlcGFyZShjaGlwLT5jdXJfY2xrKTsKPiAt CQkJY2hpcC0+Y3VyX2NsayA9IG5ld19jbGs7Cj4gKwkJCWNsa19kaXNhYmxlX3VucHJlcGFyZShk ZGF0YS0+Y3VyX2Nsayk7Cj4gKwkJCWRkYXRhLT5jdXJfY2xrID0gbmV3X2NsazsKPiAgIAo+ICAg CQkJaWYgKG5ld19jbGsgPT0gaGxjZGMtPnN5c19jbGspCj4gICAJCQkJZ2VuY2ZnID0gQVRNRUxf SExDRENfQ0xLUFdNU0VMOwo+IEBAIC0xNjAsOCArMTYwLDggQEAgc3RhdGljIGludCBhdG1lbF9o bGNkY19wd21fYXBwbHkoc3RydWN0IHB3bV9jaGlwICpjLCBzdHJ1Y3QgcHdtX2RldmljZSAqcHdt LAo+ICAgCQlpZiAocmV0KQo+ICAgCQkJcmV0dXJuIHJldDsKPiAgIAo+IC0JCWNsa19kaXNhYmxl X3VucHJlcGFyZShjaGlwLT5jdXJfY2xrKTsKPiAtCQljaGlwLT5jdXJfY2xrID0gTlVMTDsKPiAr CQljbGtfZGlzYWJsZV91bnByZXBhcmUoZGRhdGEtPmN1cl9jbGspOwo+ICsJCWRkYXRhLT5jdXJf Y2xrID0gTlVMTDsKPiAgIAl9Cj4gICAKPiAgIAlyZXR1cm4gMDsKPiBAQCAtMTgzLDMxICsxODMs MzEgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBhdG1lbF9obGNkY19wd21fZXJyYXRhIGF0bWVsX2hs Y2RjX3B3bV9zYW1hNWQzX2VycmF0YSA9IHsKPiAgICNpZmRlZiBDT05GSUdfUE1fU0xFRVAKPiAg IHN0YXRpYyBpbnQgYXRtZWxfaGxjZGNfcHdtX3N1c3BlbmQoc3RydWN0IGRldmljZSAqZGV2KQo+ ICAgewo+IC0Jc3RydWN0IGF0bWVsX2hsY2RjX3B3bSAqY2hpcCA9IGRldl9nZXRfZHJ2ZGF0YShk ZXYpOwo+ICsJc3RydWN0IGF0bWVsX2hsY2RjX3B3bSAqZGRhdGEgPSBkZXZfZ2V0X2RydmRhdGEo ZGV2KTsKPiAgIAo+ICAgCS8qIEtlZXAgdGhlIHBlcmlwaCBjbG9jayBlbmFibGVkIGlmIHRoZSBQ V00gaXMgc3RpbGwgcnVubmluZy4gKi8KPiAtCWlmIChwd21faXNfZW5hYmxlZCgmY2hpcC0+Y2hp cC5wd21zWzBdKSkKPiAtCQljbGtfZGlzYWJsZV91bnByZXBhcmUoY2hpcC0+aGxjZGMtPnBlcmlw aF9jbGspOwo+ICsJaWYgKHB3bV9pc19lbmFibGVkKCZkZGF0YS0+Y2hpcC5wd21zWzBdKSkKPiAr CQljbGtfZGlzYWJsZV91bnByZXBhcmUoZGRhdGEtPmhsY2RjLT5wZXJpcGhfY2xrKTsKPiAgIAo+ ICAgCXJldHVybiAwOwo+ICAgfQo+ICAgCj4gICBzdGF0aWMgaW50IGF0bWVsX2hsY2RjX3B3bV9y ZXN1bWUoc3RydWN0IGRldmljZSAqZGV2KQo+ICAgewo+IC0Jc3RydWN0IGF0bWVsX2hsY2RjX3B3 bSAqY2hpcCA9IGRldl9nZXRfZHJ2ZGF0YShkZXYpOwo+ICsJc3RydWN0IGF0bWVsX2hsY2RjX3B3 bSAqZGRhdGEgPSBkZXZfZ2V0X2RydmRhdGEoZGV2KTsKPiAgIAlzdHJ1Y3QgcHdtX3N0YXRlIHN0 YXRlOwo+ICAgCWludCByZXQ7Cj4gICAKPiAtCXB3bV9nZXRfc3RhdGUoJmNoaXAtPmNoaXAucHdt c1swXSwgJnN0YXRlKTsKPiArCXB3bV9nZXRfc3RhdGUoJmRkYXRhLT5jaGlwLnB3bXNbMF0sICZz dGF0ZSk7Cj4gICAKPiAgIAkvKiBSZS1lbmFibGUgdGhlIHBlcmlwaCBjbG9jayBpdCB3YXMgc3Rv cHBlZCBkdXJpbmcgc3VzcGVuZC4gKi8KPiAgIAlpZiAoIXN0YXRlLmVuYWJsZWQpIHsKPiAtCQly ZXQgPSBjbGtfcHJlcGFyZV9lbmFibGUoY2hpcC0+aGxjZGMtPnBlcmlwaF9jbGspOwo+ICsJCXJl dCA9IGNsa19wcmVwYXJlX2VuYWJsZShkZGF0YS0+aGxjZGMtPnBlcmlwaF9jbGspOwo+ICAgCQlp ZiAocmV0KQo+ICAgCQkJcmV0dXJuIHJldDsKPiAgIAl9Cj4gICAKPiAtCXJldHVybiBhdG1lbF9o bGNkY19wd21fYXBwbHkoJmNoaXAtPmNoaXAsICZjaGlwLT5jaGlwLnB3bXNbMF0sICZzdGF0ZSk7 Cj4gKwlyZXR1cm4gYXRtZWxfaGxjZGNfcHdtX2FwcGx5KCZkZGF0YS0+Y2hpcCwgJmRkYXRhLT5j aGlwLnB3bXNbMF0sICZzdGF0ZSk7Cj4gICB9Cj4gICAjZW5kaWYKPiAgIAo+IEBAIC0yNDQsMTQg KzI0NCwxNCBAQCBzdGF0aWMgaW50IGF0bWVsX2hsY2RjX3B3bV9wcm9iZShzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpwZGV2KQo+ICAgewo+ICAgCWNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgKm1h dGNoOwo+ICAgCXN0cnVjdCBkZXZpY2UgKmRldiA9ICZwZGV2LT5kZXY7Cj4gLQlzdHJ1Y3QgYXRt ZWxfaGxjZGNfcHdtICpjaGlwOwo+ICsJc3RydWN0IGF0bWVsX2hsY2RjX3B3bSAqZGRhdGE7Cj4g ICAJc3RydWN0IGF0bWVsX2hsY2RjICpobGNkYzsKPiAgIAlpbnQgcmV0Owo+ICAgCj4gICAJaGxj ZGMgPSBkZXZfZ2V0X2RydmRhdGEoZGV2LT5wYXJlbnQpOwo+ICAgCj4gLQljaGlwID0gZGV2bV9r emFsbG9jKGRldiwgc2l6ZW9mKCpjaGlwKSwgR0ZQX0tFUk5FTCk7Cj4gLQlpZiAoIWNoaXApCj4g KwlkZGF0YSA9IGRldm1fa3phbGxvYyhkZXYsIHNpemVvZigqZGRhdGEpLCBHRlBfS0VSTkVMKTsK PiArCWlmICghZGRhdGEpCj4gICAJCXJldHVybiAtRU5PTUVNOwo+ICAgCj4gICAJcmV0ID0gY2xr X3ByZXBhcmVfZW5hYmxlKGhsY2RjLT5wZXJpcGhfY2xrKTsKPiBAQCAtMjYwLDMxICsyNjAsMzEg QEAgc3RhdGljIGludCBhdG1lbF9obGNkY19wd21fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2Rldmlj ZSAqcGRldikKPiAgIAo+ICAgCW1hdGNoID0gb2ZfbWF0Y2hfbm9kZShhdG1lbF9obGNkY19kdF9p ZHMsIGRldi0+cGFyZW50LT5vZl9ub2RlKTsKPiAgIAlpZiAobWF0Y2gpCj4gLQkJY2hpcC0+ZXJy YXRhID0gbWF0Y2gtPmRhdGE7Cj4gKwkJZGRhdGEtPmVycmF0YSA9IG1hdGNoLT5kYXRhOwo+ICAg Cj4gLQljaGlwLT5obGNkYyA9IGhsY2RjOwo+IC0JY2hpcC0+Y2hpcC5vcHMgPSAmYXRtZWxfaGxj ZGNfcHdtX29wczsKPiAtCWNoaXAtPmNoaXAuZGV2ID0gZGV2Owo+IC0JY2hpcC0+Y2hpcC5ucHdt ID0gMTsKPiArCWRkYXRhLT5obGNkYyA9IGhsY2RjOwo+ICsJZGRhdGEtPmNoaXAub3BzID0gJmF0 bWVsX2hsY2RjX3B3bV9vcHM7Cj4gKwlkZGF0YS0+Y2hpcC5kZXYgPSBkZXY7Cj4gKwlkZGF0YS0+ Y2hpcC5ucHdtID0gMTsKPiAgIAo+IC0JcmV0ID0gcHdtY2hpcF9hZGQoJmNoaXAtPmNoaXApOwo+ ICsJcmV0ID0gcHdtY2hpcF9hZGQoJmRkYXRhLT5jaGlwKTsKPiAgIAlpZiAocmV0KSB7Cj4gICAJ CWNsa19kaXNhYmxlX3VucHJlcGFyZShobGNkYy0+cGVyaXBoX2Nsayk7Cj4gICAJCXJldHVybiBy ZXQ7Cj4gICAJfQo+ICAgCj4gLQlwbGF0Zm9ybV9zZXRfZHJ2ZGF0YShwZGV2LCBjaGlwKTsKPiAr CXBsYXRmb3JtX3NldF9kcnZkYXRhKHBkZXYsIGRkYXRhKTsKPiAgIAo+ICAgCXJldHVybiAwOwo+ ICAgfQo+ICAgCj4gICBzdGF0aWMgdm9pZCBhdG1lbF9obGNkY19wd21fcmVtb3ZlKHN0cnVjdCBw bGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gICB7Cj4gLQlzdHJ1Y3QgYXRtZWxfaGxjZGNfcHdtICpj aGlwID0gcGxhdGZvcm1fZ2V0X2RydmRhdGEocGRldik7Cj4gKwlzdHJ1Y3QgYXRtZWxfaGxjZGNf cHdtICpkZGF0YSA9IHBsYXRmb3JtX2dldF9kcnZkYXRhKHBkZXYpOwo+ICAgCj4gLQlwd21jaGlw X3JlbW92ZSgmY2hpcC0+Y2hpcCk7Cj4gKwlwd21jaGlwX3JlbW92ZSgmZGRhdGEtPmNoaXApOwo+ ICAgCj4gLQljbGtfZGlzYWJsZV91bnByZXBhcmUoY2hpcC0+aGxjZGMtPnBlcmlwaF9jbGspOwo+ ICsJY2xrX2Rpc2FibGVfdW5wcmVwYXJlKGRkYXRhLT5obGNkYy0+cGVyaXBoX2Nsayk7Cj4gICB9 Cj4gICAKPiAgIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIGF0bWVsX2hsY2RjX3B3 bV9kdF9pZHNbXSA9IHsKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK