From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87A42C3DA49 for ; Thu, 18 Jul 2024 04:21:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CD7dNLN6zqi6YcYtZcfrfWnkDlKeK6NkwYpMRxN/J/U=; b=WrpNq0o1UPfYu1kVzRQzwb2NeP lMBy9uwOasUZpJgr3ZsYenHSryA0dXQ9ZD93++EMOH8dLP3148pNaA3pN4RxN4btT3QGf3elHly1L 86DhVrdwxh8YQbzvIkW5OsF7ANoebRn1V5Vy/7nh8b4DA2gCEPmQuFsOiLdgcxkFnFdEQWZGfCdJN jM8YCc70Gu60tuJqfST2DkftjJFJUdGb4ybyBXVHhJYrftLUWP2oqKITDwg7IK5WU8DGCCtNRkLF8 3lHRdVBK4IpudSlU9BHM1aFTJIDiygaby7ZLKYzjNN9gquWX5eYYW5l0CFa58SX2IfYgJbqjm55XI oJerHGSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUIdO-0000000FizG-31rb; Thu, 18 Jul 2024 04:20:50 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUId2-0000000FivW-2XX4; Thu, 18 Jul 2024 04:20:30 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1721276423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CD7dNLN6zqi6YcYtZcfrfWnkDlKeK6NkwYpMRxN/J/U=; b=OCODp+DEr140wZQqm5OccISLNFJY2LIydXCsOWwb+jJYkMgG4/uJpvoJLdoHB/Xbn9XXPI ZJtiYH8B173JQEEacV7rd3WzMCpbAikkA6F1vJATASxpV/zCyu2nic68gSMU9MRKSJODzT 29CDEER82Z0y/eqWd5JBDDaMxskov7gR3FozoPosBqmE9V8I6uWTjY3yg8TCOK4GpY913I H45G8orfLJhsxW7UHH5UlW0BeEoLKYHTYQaRPK7y6mSSwXVGEcKtXw82cfCZlxZcNLb9M1 1+dmsD0HcCGwN4C3FwKPQSDmgLh+rMNnXwgY+VfigzgPhUwJyofjJ3SiLcqjaw== Date: Thu, 18 Jul 2024 06:20:21 +0200 From: Dragan Simic To: Conor Dooley Cc: linux-kernel@vger.kernel.org, Conor Dooley , Dinh Nguyen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Huacai Chen , WANG Xuerui , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, imx@lists.linux.dev, loongarch@lists.linux.dev Subject: Re: [PATCH v1 2/4] ARM: dts: rockchip: remove unlikly-to-exist DAC from elgin-r1 In-Reply-To: <20240717-parrot-malt-83cc04bf6b36@spud> References: <20240717-anvil-ashy-544e80a1317c@spud> <20240717-parrot-malt-83cc04bf6b36@spud> Message-ID: <9a492f785e0851a828e0864c33204920@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240717_212029_133587_7A4B0F11 X-CRM114-Status: GOOD ( 19.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Conor, On 2024-07-17 11:37, Conor Dooley wrote: > From: Conor Dooley > > The Rohm dh2228fv (really the bh2228fv, the compatible in the kernel > has > a typo) does not support frequencies above 10 MHz, nor per the > datasheet appear to use either CPOL or CPHA. I suspect that this > devicetree is abusing the compatible in order to bind the spidev driver > in Linux. Pretending to have devices on a board for this purpose is not > acceptable, so remove it. > > Signed-off-by: Conor Dooley There's a small typo in the patch subject: s/unlikly/unlikely/ > --- > I could not find any documentation for this board online, and it does > not blatantly say that the device is a "spidev" like other [ab]users, > so > it is possible there's actually a DAC here - but I doubt it is a > bh2228fv given the other incompatibilities. > --- > arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts > b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts > index 2d9994379eb2..9df1cef406c5 100644 > --- a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts > +++ b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts > @@ -167,14 +167,6 @@ &spi { > pinctrl-names = "default"; > pinctrl-0 = <&spim1_clk &spim1_cs0 &spim1_tx &spim1_rx>; > status = "okay"; > - > - dh2228fv: dac@0 { > - compatible = "rohm,dh2228fv"; > - reg = <0>; > - spi-max-frequency = <24000000>; > - spi-cpha; > - spi-cpol; > - }; > }; > > &u2phy {