From: Marc Zyngier <marc.zyngier@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: Suzuki K Pouloze <suzuki.poulose@arm.com>,
Julien Thierry <julien.thierry@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
James Morse <james.morse@arm.com>,
Dave Martin <Dave.Martin@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] KVM: arm64: Drop 'const' from argument of vq_present()
Date: Tue, 4 Jun 2019 10:01:25 +0100 [thread overview]
Message-ID: <9a7681c3-f09e-8b8d-35d7-051268ce6d54@arm.com> (raw)
In-Reply-To: <20190604084349.prnnvjvjaeuhsmgs@mbp>
On 04/06/2019 09:43, Catalin Marinas wrote:
> On Tue, Jun 04, 2019 at 10:13:19AM +0530, Viresh Kumar wrote:
>> We currently get following compilation warning:
>>
>> arch/arm64/kvm/guest.c: In function 'set_sve_vls':
>> arch/arm64/kvm/guest.c:262:18: warning: passing argument 1 of 'vq_present' from incompatible pointer type
>> arch/arm64/kvm/guest.c:212:13: note: expected 'const u64 (* const)[8]' but argument is of type 'u64 (*)[8]'
>
> Since the vq_present() function does not modify the vqs array, I don't
> understand why this warning. Compiler bug?
Yeah, I'm a bit puzzled by that one. Also checked with clang, which is
usually much more picky about things, but it didn't complain.
We could drop the const without much harm, but I really wish we weed out
these ancient compilers...
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-04 9:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 4:43 [PATCH] KVM: arm64: Drop 'const' from argument of vq_present() Viresh Kumar
2019-06-04 8:30 ` Marc Zyngier
2019-06-04 8:39 ` Viresh Kumar
2019-06-04 8:43 ` Catalin Marinas
2019-06-04 8:55 ` Viresh Kumar
2019-06-04 9:26 ` Dave Martin
2019-06-04 9:31 ` Viresh Kumar
2019-06-04 9:57 ` Dave Martin
2019-06-04 9:01 ` Marc Zyngier [this message]
2019-06-04 9:59 ` Dave Martin
2019-06-07 6:00 ` Viresh Kumar
2019-06-07 14:42 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a7681c3-f09e-8b8d-35d7-051268ce6d54@arm.com \
--to=marc.zyngier@arm.com \
--cc=Dave.Martin@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=julien.thierry@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=viresh.kumar@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox