From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC025C61D92 for ; Wed, 22 Nov 2023 04:17:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XAacZiduxuBhK8AeKEv86sSc/0ObUXSPaiVp6Oe/zBw=; b=EZnyQ9c5UkykiN dLhbMPnklFWENLUwOUvyvUii+2hvJBKlBLRuuIqkOmBHAaWV7rybieJEoi6hp1pJiH59gCvQJQoJf lRbG0T0X2HvIlZ3wn1tW5yfEIUiIwRpfQ7ibEriGWs4GK40OuCN64PirA5NPoGyTblN+QieOoGzMf Sdp56CuU8aSAvSFoS9vGATt5FAIpU54NXyWUYYjnFRINrg0gNJyJid9sqAyRDmACz+kLVdR0Z42d1 W7eF8ku4V7mnLwfTcEWo3153x74YRyF7cm7cSkxIbdPqwSNUwQVQZ7nih3G6ZMpqxQ0MtE0540ZN1 03KcVwOtVYFDzodedKNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r5efS-000bpm-0e; Wed, 22 Nov 2023 04:16:50 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r5efO-000boS-0h; Wed, 22 Nov 2023 04:16:48 +0000 X-UUID: ef2e3a1488ed11ee86758d4a7c00f3a0-20231121 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=MYCxEtyKV8YAitv6kgGbBkDe1UKnPEWQPdc5Y0VPrtY=; b=FauqbHqe1BDC8PH7FNyXUDugVrwdNhfv73LL+uX7sMvdfRvJ8Gb/bxtnPnbwF6ZHuUZb6W1hjiKgfj5wtrnvVpvA7/vPN7DDZ9XkaMcPAz5botYGi+WxJuiU5TMSqLUvD8MECbG9LQru4oElsrlN2zK7K1RKH3+XmmUqx4UFzB0=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.33,REQID:a474a025-2650-4f3b-b461-fdf683a67347,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:364b77b,CLOUDID:53f6ed72-1bd3-4f48-b671-ada88705968c,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO, DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULS X-UUID: ef2e3a1488ed11ee86758d4a7c00f3a0-20231121 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 2040138495; Tue, 21 Nov 2023 21:16:39 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Wed, 22 Nov 2023 12:16:02 +0800 Received: from APC01-PSA-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Wed, 22 Nov 2023 12:16:02 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WmZKIPq4acxiIoCYepHoRZJHNhAchi7VOANRqLBoe6RQ1m8N40U9qxj8kJGZzLailLUfD4LKegluOVUIlTaj7SuJ1EIeRLN5ZCrsSS6gHkmaPUJ8zKRgaGZavfoqCQYGh3r73y1Ny+PU+p+szuujcEzvHG/xDutymgPn3rUL6fvT7OhQUJNJaaFEOXAnfpBvY+oIzurP0+ZJWR+HEWfi+zqwy6CoEBN25xSwRUU6ww2CbeBJAovIO02b4dIlry5qA8Oqv/19DqQbpXKXwz/t/2igiXgOtR1kDea0ihNOwTXzfCqMeBcl7+H/LbjuLs0hwk8/YeyMA0YJC38EVNe/vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MYCxEtyKV8YAitv6kgGbBkDe1UKnPEWQPdc5Y0VPrtY=; b=N870805KxbhIYKdSItGc3I5kyRN62hdHh8qZVq2QRR9f1qqavi7Vnk1T2svwtihu5Pwokm1eCLqtSwhdPJQdBAsnIQPwyKmCQwXbXicXYha+w51eYjTAaDwRu6IB2xhHucAylk2fG2Wb254KjPBl0eGSICLwqi/RsA3VwSBkLDip2Lxahs4s3aWSPNmDeNgS2Dt1exG7fJ41lSd+EMAmb/nds3UuCRPPqX4GR94WEy8xH0EbW5x1bjgoYbdAE+Jf8VNAGNlMiIu63Frdr0fQSzBFRc10Qtoz5NJ+ZYUYYzTvbonmKuT6MBDUbwLIHHXnCVvmmYbxqTdzmV+Ioe/jXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MYCxEtyKV8YAitv6kgGbBkDe1UKnPEWQPdc5Y0VPrtY=; b=USNUG7nDZ9x0sYnpQQ2ov0rEgG4NY6zfEvsaw9JpQt6/4+3M+hRWonBflafab5CMiI92i+P5stBQqFJuFKMsZYcUapNdWtGjgcC5nUGBbHR/wFtp5zoFoVp23Gchzf8hv32jzZcZE8WGVKMwuHq+ov/z9p4mMfvQbUSbR2Iul8U= Received: from PSAPR03MB5365.apcprd03.prod.outlook.com (2603:1096:301:17::5) by SEYPR03MB8202.apcprd03.prod.outlook.com (2603:1096:101:1ae::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.28; Wed, 22 Nov 2023 04:15:59 +0000 Received: from PSAPR03MB5365.apcprd03.prod.outlook.com ([fe80::bad5:5c99:1d71:2631]) by PSAPR03MB5365.apcprd03.prod.outlook.com ([fe80::bad5:5c99:1d71:2631%4]) with mapi id 15.20.7025.017; Wed, 22 Nov 2023 04:15:59 +0000 From: =?utf-8?B?Smlhbmp1biBXYW5nICjnjovlu7rlhpsp?= To: "skinsburskii@linux.microsoft.com" , "helgaas@kernel.org" CC: "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "skinsburskii@gmail.com" , "robh@kernel.org" , "kw@linux.com" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "bhelgaas@google.com" , "lpieralisi@kernel.org" , Ryder Lee , "angelogioacchino.delregno@collabora.com" , "linux-pci@vger.kernel.org" Subject: Re: [PATCH] PCI: mediatek: Fix sparse warning caused to virt_to_phys() prototype change Thread-Topic: [PATCH] PCI: mediatek: Fix sparse warning caused to virt_to_phys() prototype change Thread-Index: AQHaHAr95uYvd7q87U2/EzC5eIJsV7CFTeOAgAAH1ACAAATigIAAAwEAgABfYoA= Date: Wed, 22 Nov 2023 04:15:59 +0000 Message-ID: <9a774508cc54914bd50b649218a3a17b632f31d2.camel@mediatek.com> References: <20231121220556.GA21969@skinsburskii.> <20231121222325.GA260057@bhelgaas> <20231121223410.GA23977@skinsburskii.> In-Reply-To: <20231121223410.GA23977@skinsburskii.> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PSAPR03MB5365:EE_|SEYPR03MB8202:EE_ x-ms-office365-filtering-correlation-id: ac5547ab-e7b6-444a-de39-08dbeb11bb87 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jcPs5vdZ0SQRfl5ET/SMcXqngexDY3lpEgkt8hrt124muohNv8JqgCUZ3fBX8d7i2immZT8vsDtDTU1E/cGe/IhWe9Slm6ERhKsUh3kAZIOT1CcpWF1aj6uE1bCIZf/XVh9IKlqaPo1EXgIsQLMXFVcptuNd16Ibf9u1ATF1wmWhyLmxzBs+j1WYXb46eFVIyL4zmGleD/ytdN2lYCNK8iN0kf2T2IZSLI35jnNLsk6ta/T+3MYxcLL5bfxbbjGJheViDl996nCkHvGVx8wd3UTOhoGuzkMAo7xgfAP8cCqsjZ5KgZFZZjnvGbQ8ly0hUtUCFLG6OJmYzOJpJVPg++bO3bP3lMmj7lw9qII2eJYy0N1vxIsVPKT43ooolM01o/B933pXStyc6FVFlHuzjpNyUe6g9J/xSvWFu3FW1vWvf1xh2ShwgxSAj2GKWee3KOdbalX2/IhKJz9MjMT8RIuuBdoETsU++4vNKRMW6EknzkfqoM7EkUUDoTYmW+Zcduzaql57opQau2DgNBkBtSSBOcYma63JJ1RIxZvAZUOZN71N+HNcjV3Hjo42DAEgldDUsDKw0BXQ/SW+o7P4XqCPiCiVuXPcNmBxOb1mQUFd1cj0Llhvig5fHe7FIop9faJvAtKNhFnaVcAhQkvNpbfSx75dB17oJR4mwIs4f6cWYN2ttWk7UtLQ2gRHzQJh x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PSAPR03MB5365.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(346002)(136003)(396003)(366004)(376002)(230273577357003)(230173577357003)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(71200400001)(76116006)(66446008)(66556008)(66476007)(66946007)(91956017)(316002)(110136005)(54906003)(64756008)(36756003)(6506007)(6512007)(2616005)(6486002)(122000001)(26005)(38070700009)(38100700002)(966005)(85182001)(478600001)(83380400001)(86362001)(7416002)(5660300002)(4001150100001)(2906002)(41300700001)(8936002)(8676002)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?LzdqcWtJaTNCM0RXN2VySGNraVdKRjNzcWFMM2VYMFRKclJqRVBUV3FZS0lw?= =?utf-8?B?Mjh0dmsweEMyeUZnOWJudVVaRDAzVU5Ba0gvaFBER0t1eWVHNVB4T01sMUxt?= =?utf-8?B?cDdzZTdpakRBN2N4S1FlcGUrSXVmd0ZENTVqcDJ4ejZkcXNmZERJSnh3bTEy?= =?utf-8?B?OFhydklCTm5lVTBxMlNsTWhLVFVKY21CSzhkcW4vYzAyTU5sRU91Q3V4MFNV?= =?utf-8?B?MFdHR0ZkaXJkZGpyQzcwVTB1V2hoc0x2ZTVuL3NvL2xpL21IdVhtZG5Xbkt2?= =?utf-8?B?VVFCZ2dzL0RwSWJSZTZnTUpMeG5UdWp2SlZacFB0ZnhiWk5NT0hhQ2xTNVVH?= =?utf-8?B?ZDR1VFozK2lrVHNOWDhLcFduRkpUZWpyekl6Nk5nKzFURGMrRnprbEJOdSs5?= =?utf-8?B?OUFSTHZqYjNEaVNMWTAxSlcxZS9ZOFVONmpDR2RhNTZDbElvZG5TekJzZ05o?= =?utf-8?B?SElUS2J3SmpwQjloMWVaK1EwZ2g0K21QTXVJUmpqTGFyUGQrTU1OZExxZDJM?= =?utf-8?B?VVdhUE1OU0g1VGlhcm0rM1JiRlJqV2ZBTEdPZy9DRFcxd01vVVI5cHgzK2ha?= =?utf-8?B?U2JJMVVWVUVPd2VpRHFBK3gxankrUHZ3STdtRGJYZ2xxQWJHUVdWOVVXdS9E?= =?utf-8?B?RHZXMUdnOFFjU3F4N1FNa3g0MUdVbytEUXAxOVpFN08yRzNTb0JqYjlCYVV3?= =?utf-8?B?ejh5VVl5MUUvVk1XNkxtbk9LSXBLTVlmd0RCdkwxa3BlYU93RTlpQ2o4QnU1?= =?utf-8?B?WXNPcjFsVE9Jc1E1b2QrTmNjZzExV29hV1BiaHdiR00wUU9VWEZqK0V3Tklo?= =?utf-8?B?UTlMRE5pQXFsRVJGZ3FnVDRtTnczY01taTRaTC9TcVpXbGFic2ZGREY0Y1BQ?= =?utf-8?B?M0hldVYyY0JUMFJBZGVHRTZQRk9NelNKOUw1MWRYbUFWdWsxZERXa3dya2Qr?= =?utf-8?B?ODZSenZXNTBkSEJMc2xKbGdzQk5JdDE2V3NjSkRSRzI3QWVWSjY2ZlBTVU9O?= =?utf-8?B?RVhTSk9vWWxVeWJ2ZW1FdGR1cUhyT0g4cEFpbFNUWGFoRHdVZzA3NjFYWVpj?= =?utf-8?B?TnlhQXNabElKZkxUdW1ZVkdEblN3bURtOUtZa1FrdGxZL1ZxOHJFTzJHeVdK?= =?utf-8?B?d2hvaTl5MWVhQ2NoS3FhNkZMWlF3RG1aNzhjbUhaSHZhN253b2xoR00vYXZF?= =?utf-8?B?N0VBVzNoTnlqOTdCaGRVRThLdzJmMEo3MFFwU1A3L2Nmb2Rleit2bit1LytC?= =?utf-8?B?QS8vR1c3RzI2U2ZEamFlckU2WlVhSTZNSDQ1WWt2dUU1eDBZWjdVdEJaWkRl?= =?utf-8?B?eXhidUZhUDdJWkdreEF1SUNzQmtEeEp6NVJKZHRDNzJsazhKYm9aSWFpOEc1?= =?utf-8?B?dHQxbEF4dW9xSTdBRVpBZDBXTDlPVW1VUHBLaGs4Y3lZZ0FiTmovVmM1SGJs?= =?utf-8?B?R1dORkF0eS9XYTdTMGRDeVVxSWZISlR2TXAzRzVqWWJFR3R1cHpFK0tkSC81?= =?utf-8?B?M0xkWUw2ZkRqSDdWYnhLd05xYzVNRGR3TDRDdS93Q0J5cnUzY094Z3YyQTVD?= =?utf-8?B?NHZ1LzNEdzFXNXkwZms0Ynh4S005bkxNeXpkYUNNalFJY1pMcW9qRFQyVG11?= =?utf-8?B?NS94bXYvd0E4UkdETTY3MTJwamZrVThybnlnbkFFQkM5czc3OVF6NlVzc0Rx?= =?utf-8?B?T3NVTXk3ZFFDd1F1c2xORGJaa1BETjc5Sys3aS9UWmVSSDhBcEpIUmR5bG1L?= =?utf-8?B?VVZjWXdvMFB4VkFFY2NvYVFMRGhtSk9sY1N6Q0dDMFFqOEpQTWg1WEphZXBN?= =?utf-8?B?MEFWN2hwZkYxNVhnSENvMXRtTGFJV2ZGQ2ZMNktjQUZaZmY2VGNsRzkvc01u?= =?utf-8?B?ekNoQ2ZIMDM0WThHQnpzUHVoci9mQW1GQkp5T3JQek5hbXJMRFVyS21LNFE3?= =?utf-8?B?WkdTL2RnaStKUDJnV2RoMjJjVjR4TllkQktlREg1UWZvMGcxMHVLbys0TVNv?= =?utf-8?B?dzgrVE5SN0hoTWtiUVBxQ2NtdGpRa0tYWDkxTkRwbmpNZkF4YzBKZEtPUnh1?= =?utf-8?B?ODBEOTN1RG1CT0R1TFFTS0F2SWpCUjgvVmoyRmQzbGQwekZOVjlzQ3ZSRmI2?= =?utf-8?B?Z28yQUZxdkwreStKOVpGclVmQ2hlL0VKRkVNZ2l0WlBFNjd1T1hCNytzK0hl?= =?utf-8?B?T1E9PQ==?= Content-ID: <19C61E1312C5D54783AB3661C936FCCE@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PSAPR03MB5365.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac5547ab-e7b6-444a-de39-08dbeb11bb87 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2023 04:15:59.6258 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vrP0HmcPziWRqq8cyhe+f55arx2h4noOWLy6zpTnsSjvxTKJU0/rrFfrNg+PL869PmeaWkov78Dd7+uVcXz0Q2HA4s1zP9vMZ3jHxBDe7nU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR03MB8202 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231121_201646_260778_95F6F887 X-CRM114-Status: GOOD ( 41.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Tue, 2023-11-21 at 14:34 -0800, Stanislav Kinsburskii wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On Tue, Nov 21, 2023 at 04:23:25PM -0600, Bjorn Helgaas wrote: > > On Tue, Nov 21, 2023 at 02:05:56PM -0800, Stanislav Kinsburskii > wrote: > > > On Tue, Nov 21, 2023 at 03:37:55PM -0600, Bjorn Helgaas wrote: > > > > On Mon, Nov 20, 2023 at 03:40:33PM -0800, Stanislav Kinsburskii > wrote: > > > > > Explicitly cast __iomem pointer to const void* with __force > to fix the > > > > > following warning: > > > > > > > > > > warning: incorrect type in argument 1 (different address > spaces) > > > > > expected void const volatile *address > > > > > got void [noderef] __iomem * > > > > > > > > I have two questions about this: > > > > > > > > 1) There's no other use of __force in drivers/pci, so I don't > know > > > > what's special about pcie-mediatek.c. There should be a way > to fix > > > > the types so it's not needed. > > > > > > __force suppreses the following sparse warning: > > > > > > warning: cast removes address space '__iomem' of expression > > > > I'm suggesting that the cast is a band-aid that covers up a type > > mismatch, and there shouldn't be a mismatch in the first place. > > > > > > 2) virt_to_phys() is not quite right to begin with because > what we > > > > want is a *bus* address, not the CPU physical address we get > from > > > > virt_to_phys(). Obviously the current platforms that use > this must > > > > not apply any offset between bus and CPU physical addresses, > but > > > > it's not something we should rely on. > > > > > > > > There are only three drivers (pci-aardvark.c, pcie-xilinx.c, > and > > > > this one) that use virt_to_phys(), and they're all slightly > wrong > > > > here. > > > > > > > > The *_compose_msi_msg() methods could use a little more > consistency > > > > across the board. > > > > > > Could you elaborate on what do you suggest? > > > Should virt_to_phys() be simply removed? > > > > The DMA API (Documentation/core-api/dma-api.rst) is the usual way > to > > get bus addresses, since an MSI is basically a DMA on the PCI bus. > > > > https://lore.kernel.org/linux-pci/20230914203146.GA77870@bhelgaas/ > > > > Nobody is very motivated to fix these, I guess ;) I sort of hate > to > > just throw in a cast to shut up the warning because it doesn't > really > > solve the problem. > > > > This is fair. > However I have neither expertize to assess, no hardware to test such > intrusive > changes. > I guess it's a no-op then, is it? I think I can try and test 'dmam_alloc_coherent()' or other proper APIs on the MediaTek platform, and if it works as expected, I can send the patch to fix this. Thanks. > > > > > > Signed-off-by: Stanislav Kinsburskii < > skinsburskii@linux.microsoft.com> > > > > > --- > > > > > drivers/pci/controller/pcie-mediatek.c | 4 ++-- > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/drivers/pci/controller/pcie-mediatek.c > b/drivers/pci/controller/pcie-mediatek.c > > > > > index 66a8f73296fc..27f0f79810a1 100644 > > > > > --- a/drivers/pci/controller/pcie-mediatek.c > > > > > +++ b/drivers/pci/controller/pcie-mediatek.c > > > > > @@ -397,7 +397,7 @@ static void mtk_compose_msi_msg(struct > irq_data *data, struct msi_msg *msg) > > > > > phys_addr_t addr; > > > > > > > > > > /* MT2712/MT7622 only support 32-bit MSI addresses */ > > > > > -addr = virt_to_phys(port->base + PCIE_MSI_VECTOR); > > > > > +addr = virt_to_phys((__force const void *)port->base + > PCIE_MSI_VECTOR); > > > > > msg->address_hi = 0; > > > > > msg->address_lo = lower_32_bits(addr); > > > > > > > > > > @@ -520,7 +520,7 @@ static void mtk_pcie_enable_msi(struct > mtk_pcie_port *port) > > > > > u32 val; > > > > > phys_addr_t msg_addr; > > > > > > > > > > -msg_addr = virt_to_phys(port->base + PCIE_MSI_VECTOR); > > > > > +msg_addr = virt_to_phys((__force const void *)port->base + > PCIE_MSI_VECTOR); > > > > > val = lower_32_bits(msg_addr); > > > > > writel(val, port->base + PCIE_IMSI_ADDR); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel