From: Florian Fainelli <f.fainelli@gmail.com>
To: Carlo Caione <ccaione@baylibre.com>,
andrew@lunn.ch, hkallweit1@gmail.com, robh+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, fabio.estevam@nxp.com, linux-imx@nxp.com,
mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, aisheng.dong@nxp.com,
abailon@baylibre.com
Subject: Re: [PATCH 2/3] dt-bindings: net: at803x: Document at803x,smarteee-disabled property
Date: Fri, 25 Jan 2019 10:42:38 -0800 [thread overview]
Message-ID: <9a8d238c-eb22-16f8-13be-f5e078edaf82@gmail.com> (raw)
In-Reply-To: <20190125125513.23656-3-ccaione@baylibre.com>
On 1/25/19 4:55 AM, Carlo Caione wrote:
> SmartEEE is a proprietary protocol that allows legacy MAC/SoC devices
> without 802.3az support to function as a complete 802.3az system.
>
> This is know to cause issues so a new property is added to optionally
> disable this feature.
>
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
> ---
> .../devicetree/bindings/net/at803x.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/at803x.txt
>
> diff --git a/Documentation/devicetree/bindings/net/at803x.txt b/Documentation/devicetree/bindings/net/at803x.txt
> new file mode 100644
> index 000000000000..931cb34534fb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/at803x.txt
> @@ -0,0 +1,18 @@
> +* Atheros AR803x Integrated 10/100/1000 Mbps Ethernet Transceiver
> +
> +Required properties:
> + - reg - The ID number for the phy, usually a small integer
> +
> +Optional property:
> + - at803x,smarteee-disabled: Disable SmartEEE feature
Should this be named at803x,smarteee-broken instead of "disabled"?
Because disabled is effectively what will happen after the driver looks
up that property and acts on it, but this does not really describe the
HW state unless there is appropriate software running.
Similar question to Heiner, how do SmartEEE and standard EEE relate to
each other? Can we use the existing broken-eee properties?
> +
> +Example:
> +
> + ethernet-phy@0 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0>;
> + at803x,smarteee-disabled
> + };
> +
> +Datasheet can be found:
> +https://media.digikey.com/pdf/Data%20Sheets/CSR%20PDFs/AR8031_DS_(Atheros)_Rev1.0_Aug2011.pdf
>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-25 18:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 12:55 [PATCH 0/3] at803x: Add quirk to disable SmartEEE Carlo Caione
2019-01-25 12:55 ` [PATCH 1/3] net: phy: at803x: Introduce " Carlo Caione
2019-01-25 12:55 ` [PATCH 2/3] dt-bindings: net: at803x: Document at803x, smarteee-disabled property Carlo Caione
2019-01-25 18:42 ` Florian Fainelli [this message]
2019-01-25 12:55 ` [PATCH 3/3] arm64: dts: imx8mq-evk: Disable SmartEEE Carlo Caione
2019-01-25 13:06 ` [PATCH 0/3] at803x: Add quirk to disable SmartEEE Russell King - ARM Linux admin
2019-01-25 18:15 ` Heiner Kallweit
2019-01-25 18:48 ` Carlo Caione
2019-01-25 19:07 ` Heiner Kallweit
2019-01-25 19:19 ` Russell King - ARM Linux admin
2019-01-25 19:27 ` Heiner Kallweit
2019-01-28 10:46 ` Carlo Caione
2019-01-28 15:57 ` Russell King - ARM Linux admin
2019-01-28 18:23 ` Heiner Kallweit
2019-01-28 19:04 ` Russell King - ARM Linux admin
2019-01-30 10:16 ` Carlo Caione
2019-01-30 10:47 ` Russell King - ARM Linux admin
2019-04-12 0:25 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8d238c-eb22-16f8-13be-f5e078edaf82@gmail.com \
--to=f.fainelli@gmail.com \
--cc=abailon@baylibre.com \
--cc=aisheng.dong@nxp.com \
--cc=andrew@lunn.ch \
--cc=ccaione@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).